Skip to content

flutter update-packages --force-upgrade #128908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 7 commits into from
Jun 15, 2023
Merged

flutter update-packages --force-upgrade #128908

auto-submit merged 7 commits into from
Jun 15, 2023

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Jun 14, 2023

  • Bumps vm_service from 11.6.0 to 11.7.1
  • Bumps web from 0.1.3-beta to 0.1.4-beta and adds it everywhere.
  • Moves js from dependencies to dev_dependencies

@github-actions github-actions bot added a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Jun 14, 2023
@christopherfujino christopherfujino mentioned this pull request Jun 14, 2023
Closed
@christopherfujino
Copy link
Contributor

christopherfujino commented Jun 14, 2023

Looks like build failures:

[2023-06-14 15:12:01.930667] [STDOUT] stderr: lib/web_benchmarks.dart:157:69:
[2023-06-14 15:12:01.930706] [STDOUT] stderr: Error: The argument type 'JSString' can't be assigned to the parameter type 'String'.
[2023-06-14 15:12:01.930763] [STDOUT] stderr:  - 'JSString' is from 'dart:_js_types'.
[2023-06-14 15:12:01.930801] [STDOUT] stderr:     final web.HTMLDivElement div = web.document.createElement('div'.toJS) as

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8778276070166452225/+/u/run_web_benchmarks_html/test_stdout

@github-actions github-actions bot added the f: scrolling Viewports, list views, slivers, etc. label Jun 14, 2023
@github-actions github-actions bot added the a: text input Entering text in a text field or keyboard related problems label Jun 15, 2023
@mdebbar
Copy link
Contributor Author

mdebbar commented Jun 15, 2023

@christopherfujino would you mind taking another look? I fixed the build failures caused by the upgrade to package:[email protected].

christopherfujino
christopherfujino approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 15, 2023
@auto-submit auto-submit bot merged commit a162d75 into flutter:master Jun 15, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 16, 2023
@engine-flutter-autoroll
a162d75 flutter update-packages --force-upgrade (flutter/flutter#128908)
9f4294a
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 16, 2023
@engine-flutter-autoroll
Roll Flutter from b0188cd to fc8856e (14 revisions) (#4231)
08ab0af 
flutter/flutter@b0188cd...fc8856e

2023-06-16 [email protected] [web] Don't crash on `const HtmlElementView()` (flutter/flutter#128965)
2023-06-16 [email protected] Roll Packages from 0507297 to f9314a3 (3 revisions) (flutter/flutter#128878)
2023-06-16 [email protected] Update getProperties to handle Diagnosticable as input. (flutter/flutter#128897)
2023-06-15 [email protected] Roll Flutter Engine from 48e0b4e66422 to fb5fed432e59 (1 revision) (flutter/flutter#128967)
2023-06-15 [email protected] Fix dart pub cache clean command on pub.dart (flutter/flutter#128171)
2023-06-15 [email protected] [flutter_tools] Migrate more integration tests to process result matcher (flutter/flutter#128737)
2023-06-15 [email protected] [flutter_tools] refactor license collector (flutter/flutter#128748)
2023-06-15 [email protected] Set Semantics.button to true for date widget (flutter/flutter#128824)
2023-06-15 [email protected] Update golden tests (flutter/flutter#128914)
2023-06-15 [email protected] Roll Flutter Engine from 9934c0de738c to 48e0b4e66422 (26 revisions) (flutter/flutter#128959)
2023-06-15 [email protected] flutter update-packages --cherry-pick-package (flutter/flutter#128917)
2023-06-15 [email protected] add .pub-cache back to .gitignore (flutter/flutter#128894)
2023-06-15 [email protected] Roll Flutter Engine from 2d8d5ecfe4a8 to 9934c0de738c (2 revisions) (flutter/flutter#128849)
2023-06-15 [email protected] flutter update-packages --force-upgrade (flutter/flutter#128908)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
a162d75 flutter update-packages --force-upgrade (flutter/flutter#128908)
2ea0756
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
a162d75 flutter update-packages --force-upgrade (flutter/flutter#128908)
3f08757
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
a162d75 flutter update-packages --force-upgrade (flutter/flutter#128908)
047e4eb
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
a162d75 flutter update-packages --force-upgrade (flutter/flutter#128908)
e8fbf69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mdebbar @christopherfujino