Skip to content

Conversation

@polina-c
Copy link
Contributor

Contributes to dart-lang/leak_tracker#59

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Jun 13, 2023
@polina-c polina-c marked this pull request as ready for review June 13, 2023 20:24
@polina-c polina-c changed the title Respect allowlisted count of leaks Respect allowlisted count of leaks. Jun 13, 2023
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 13, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 13, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 13, 2023

auto label is removed for flutter/flutter, pr: 128823, due to - The status or check suite Windows framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.

@polina-c polina-c merged commit d520b64 into flutter:master Jun 14, 2023
@polina-c polina-c deleted the count branch June 14, 2023 21:35
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 15, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 15, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 15, 2023
flutter/flutter@95be76a...b0188cd

2023-06-15 [email protected] [web] Pass creation params to the platform view factory (flutter/flutter#128146)
2023-06-15 [email protected] [flutter_tools] cache flutter sdk version to disk (flutter/flutter#124558)
2023-06-14 [email protected] Fix inconsistently suffixed macOS flavored bundle directory (flutter/flutter#127997)
2023-06-14 [email protected] Update golden tests for material (flutter/flutter#128839)
2023-06-14 [email protected] Update getChildrenSummaryTree to handle Diagnosticable as input. (flutter/flutter#128833)
2023-06-14 [email protected] Improve the error message for non-normalized constraints (flutter/flutter#127906)
2023-06-14 [email protected] ContextAction.isEnabled needs a context (flutter/flutter#127721)
2023-06-14 [email protected] Remove temporary default case for PointerSignalKind (flutter/flutter#128900)
2023-06-14 [email protected] Respect allowlisted count of leaks. (flutter/flutter#128823)
2023-06-14 [email protected] Unpin flutter_plugin_android_lifecycle (flutter/flutter#128898)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants