Update button tests for Material 3 by default #128628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
a: text input
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. Changes reported for pull request #128628 at sha 3bc45a0d9a9bb575a75e688d28eec749b9c4d43c |
QuncCccccc
approved these changes
Jun 9, 2023
Contributor
There was a problem hiding this comment.
nit: seems we can remove these two lines.
Contributor
Author
There was a problem hiding this comment.
Oops, good catch, thanks.
HansMuller
force-pushed
the
update_button_tests
branch
from
3bc45a0 to
c89d85c
Compare
|
Golden file changes are available for triage from new commit, Click here to view. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
25 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 13, 2023
tarrinneal
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 14, 2023
flutter/flutter@353b8bc...09b7e56 2023-06-13 [email protected] Roll Packages from c9865e8 to 0507297 (6 revisions) (flutter/flutter#128796) 2023-06-13 [email protected] Roll Flutter Engine from 346f051ac062 to f9a0a0dafeea (1 revision) (flutter/flutter#128786) 2023-06-13 [email protected] Roll Flutter Engine from 5951f90cbac3 to 346f051ac062 (1 revision) (flutter/flutter#128783) 2023-06-13 [email protected] Roll Flutter Engine from 3b70103f53bc to 5951f90cbac3 (1 revision) (flutter/flutter#128781) 2023-06-13 [email protected] Roll Flutter Engine from 04ffeb4ab103 to 3b70103f53bc (1 revision) (flutter/flutter#128778) 2023-06-13 [email protected] Roll Flutter Engine from 42ccd12a14c2 to 04ffeb4ab103 (4 revisions) (flutter/flutter#128772) 2023-06-13 [email protected] Roll Flutter Engine from aa1693f6aaeb to 42ccd12a14c2 (1 revision) (flutter/flutter#128761) 2023-06-13 [email protected] Roll Flutter Engine from d02b15ef34ef to aa1693f6aaeb (3 revisions) (flutter/flutter#128759) 2023-06-13 [email protected] Roll Flutter Engine from f67ed35b142e to d02b15ef34ef (2 revisions) (flutter/flutter#128754) 2023-06-13 [email protected] Roll Flutter Engine from 1714d73e681b to f67ed35b142e (3 revisions) (flutter/flutter#128751) 2023-06-12 [email protected] Roll Flutter Engine from 12def739b1f6 to 1714d73e681b (2 revisions) (flutter/flutter#128738) 2023-06-12 [email protected] Fix paint offset in reverse for 2D (flutter/flutter#128724) 2023-06-12 [email protected] [flutter_tools] pass through enable impeller flag to macOS. (flutter/flutter#128720) 2023-06-12 [email protected] Roll Flutter Engine from de68fba09338 to 12def739b1f6 (2 revisions) (flutter/flutter#128726) 2023-06-12 [email protected] Roll Flutter Engine from 33e06934daed to de68fba09338 (10 revisions) (flutter/flutter#128721) 2023-06-12 [email protected] Roll Flutter Engine from 4b022f4e871f to 33e06934daed (6 revisions) (flutter/flutter#128706) 2023-06-12 [email protected] Update button tests for Material 3 by default (flutter/flutter#128628) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates all of the button tests so that they'll pass if ThemeData.useMaterial3 defaults to true.
The extensive changes to the toggle_buttons_test.dart was to refactor the
boilerplatefunction to include the Material widget every use of the boilerplate function started with.Most of the tests that have wired
useMaterial3to false will need to be updated with a M3 version.