Skip to content

[CP] rename generated asset manifest file back to AssetManifest.bin (from AssetManifest.smcbin) #128621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Jun 12, 2023
Merged

[CP] rename generated asset manifest file back to AssetManifest.bin (from AssetManifest.smcbin) #128621

auto-submit merged 1 commit into from
Jun 12, 2023

Conversation

@andrewkolos
Copy link
Contributor

@andrewkolos andrewkolos commented Jun 9, 2023 •
edited
Loading

Cherry-picks #128529 onto stable.
Fixes #128230

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@andrewkolos
rename generated asset manifest file back to AssetManifest.bin (fro…
a3ceb95 
…m `AssetManifest.smcbin`) (flutter#128529)

Closes flutter#128456, which is now linked to in a code comment in this change.
Reopens flutter#124883.

This effectively reverts flutter#126077 and is intended to be cherry-picked into stable.
@andrewkolos andrewkolos requested a review from eliasyishak June 9, 2023 21:38
@andrewkolos
Copy link
Contributor Author

andrewkolos commented Jun 9, 2023

CC @jonahwilliams

jonahwilliams
jonahwilliams approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkolos andrewkolos mentioned this pull request Jun 9, 2023
Closed
@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 12, 2023
@auto-submit auto-submit bot merged commit 681c0c3 into flutter:flutter-3.10-candidate.1 Jun 12, 2023
This was referenced Jun 12, 2023
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2023
@engine-flutter-autoroll
681c0c396 [CP] rename generated asset manifest file back to `AssetMan…
89b78b2 
…ifest.bin` (from `AssetManifest.smcbin`) (flutter/flutter#128621)
@andrewkolos andrewkolos deleted the cp-rename-asset-manifest-back-to-bin branch June 15, 2023 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eliasyishak eliasyishak Awaiting requested review from eliasyishak

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewkolos @jonahwilliams @CaseyHillers