Ignore app.stop events received before the app.detach response in attach integration tests #128593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tool
zanderso
approved these changes
Jun 9, 2023
DanTup
approved these changes
Jun 9, 2023
…ach integration tests The app.detach command will close the VM service connection, which yields an app.stop event in the daemon protocol. The daemon does not guarantee any ordering between this event and the response to the app.detach. See flutter#128546
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 10, 2023
…e in attach integration tests (flutter/flutter#128593)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 10, 2023
…e in attach integration tests (flutter/flutter#128593)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 10, 2023
…e in attach integration tests (flutter/flutter#128593)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 11, 2023
…e in attach integration tests (flutter/flutter#128593)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 11, 2023
…e in attach integration tests (flutter/flutter#128593)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 11, 2023
flutter/flutter@da127f1...3df163f 2023-06-11 [email protected] Roll Flutter Engine from 73a7af805472 to 1cca9cc6dbd1 (1 revision) (flutter/flutter#128658) 2023-06-11 [email protected] Roll Flutter Engine from 7c6770083e5c to 73a7af805472 (2 revisions) (flutter/flutter#128654) 2023-06-11 [email protected] Roll Flutter Engine from 6d615bbcfccf to 7c6770083e5c (2 revisions) (flutter/flutter#128653) 2023-06-11 [email protected] Roll Flutter Engine from b19b93de5b0a to 6d615bbcfccf (1 revision) (flutter/flutter#128650) 2023-06-11 [email protected] Roll Flutter Engine from 3d76ba6d6d5f to b19b93de5b0a (2 revisions) (flutter/flutter#128649) 2023-06-11 [email protected] Roll Flutter Engine from 962d78e0ae9c to 3d76ba6d6d5f (1 revision) (flutter/flutter#128645) 2023-06-10 [email protected] migrate `Tooltip` to use `OverlayPortal` (flutter/flutter#127728) 2023-06-10 [email protected] Roll Flutter Engine from b037db26037f to 962d78e0ae9c (10 revisions) (flutter/flutter#128643) 2023-06-10 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.2 to 3.5.3 (flutter/flutter#128625) 2023-06-10 [email protected] Roll Flutter Engine from 3e90345cdca7 to b037db26037f (1 revision) (flutter/flutter#128627) 2023-06-10 [email protected] Remove unnecessary parentheses (flutter/flutter#128620) 2023-06-09 [email protected] Roll Flutter Engine from 488876ed26c6 to 3e90345cdca7 (3 revisions) (flutter/flutter#128617) 2023-06-09 [email protected] rename generated asset manifest file back to `AssetManifest.bin` (from `AssetManifest.smcbin`) (flutter/flutter#128529) 2023-06-09 [email protected] Add Selected semantics to IconButton (flutter/flutter#128547) 2023-06-09 [email protected] Roll Flutter Engine from 071e1fb21c7a to 488876ed26c6 (5 revisions) (flutter/flutter#128612) 2023-06-09 [email protected] Clarifies semantics long press and semantics on tap documentation (flutter/flutter#128599) 2023-06-09 [email protected] Roll Flutter Engine from bc6e047570f6 to 071e1fb21c7a (1 revision) (flutter/flutter#128602) 2023-06-09 [email protected] Revert "Update `chip.dart` to use set of `MaterialState`" (flutter/flutter#128607) 2023-06-09 [email protected] Add tooltips for `SegmentedButton` (flutter/flutter#128501) 2023-06-09 [email protected] Ignore app.stop events received before the app.detach response in attach integration tests (flutter/flutter#128593) 2023-06-09 [email protected] ExpansionPanel isExpanded callback parameter (Ticket 74114) (flutter/flutter#128082) 2023-06-09 [email protected] Roll Flutter Engine from 93afba901b3b to bc6e047570f6 (3 revisions) (flutter/flutter#128594) 2023-06-09 [email protected] Updated flutter_localizations tests for Material3; (flutter/flutter#128521) 2023-06-09 [email protected] Paint SelectableFragments before text (flutter/flutter#128375) 2023-06-09 [email protected] Roll Packages from e13b8c4 to afe2f05 (7 revisions) (flutter/flutter#128582) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
…e in attach integration tests (flutter/flutter#128593)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
…e in attach integration tests (flutter/flutter#128593)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
…e in attach integration tests (flutter/flutter#128593)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
…e in attach integration tests (flutter/flutter#128593)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app.detach command will close the VM service connection, which yields an app.stop event in the daemon protocol. The daemon does not guarantee any ordering between this event and the response to the app.detach.
See #128546