Replaces `textScaleFactor` with `TextScaler` #128522

LongCatIsLooong · 2023-06-08T17:50:52Z

Deprecate textScaleFactor in favor of textScaler, in preparation for Android 14 Non-linear font scaling to 200%. The TextScaler class can be moved to dart:ui in the future, if we decide to use the Android platform API or AndroidX to get the scaling curve instead of hard coding the curve in the framework.

I haven't put the Flutter version in the deprecation message so the analyzer checks are failing. Will do so after I finish the migration guide.

Why TextScaler.textScaleFactor
The author of a TextScaler subclass should provide a fallback textScaleFactor. By making TextScaler also contain the textScaleFactor information it also makes it easier to migrate: if a widget overrides MediaQueryData.textScaler in the tree, for unmigrated widgets in the subtree it would also have to override MediaQueryData.textScaleFactor, and that makes it difficult to remove MediaQueryData.textScaleFactor in the future.

A full list of affected APIs in this PR

Deprecated: The method/getter/setter/argument is annotated with a @Deprecated() annotation in this PR, and the caller should replace it with textScaler instead. Unless otherwise specified there will be a Flutter fix available to help with migration but it's still recommended to migrate case-by-case.
Replaced: The method this textScaleFactor argument belongs to is rarely called directly by user code and is not overridden by any of the registered custom tests, so the argument is directly replaced by TextScaler.
To Be Deprecated: The method/getter/setter/argument can't be deprecated in this PR because a registered customer test depends on it and a Flutter fix isn't available (or the test was run without applying flutter fixes first). This method/getter/setter/argument will be deprecated in a followup PR once the registered test is migrated.

`Painting` Library

Affected API	State of `textScaleFactor`	Comment
`InlineSpan.build({ double textScaleFactor = 1.0 })` argument	Replaced
`TextStyle.getParagraphStyle({ double TextScaleFactor = 1.0 })` argument	Replaced
`TextStyle.getTextStyle({ double TextScaleFactor = 1.0 })` argument	Deprecated	Can't replace: https://github.com/superlistapp/super_editor/blob/c47fd38dca4b7f43611690913b551a1773c563d7/super_editor/lib/src/infrastructure/super_textfield/desktop/desktop_textfield.dart#L1903-L1905
`TextPainter({ double TextScaleFactor = 1.0 })` constructor argument	Deprecated
`TextPainter.textScaleFactor` getter and setter	Deprecated	No Flutter Fix, not expressible yet
`TextPainter.computeWidth({ double TextScaleFactor = 1.0 })` argument	Deprecated
`TextPainter.computeMaxIntrinsicWidth({ double TextScaleFactor = 1.0 })` argument	Deprecated

`Rendering` Library

Affected API	State of `textScaleFactor`	Comment
`RenderEditable({ double TextScaleFactor = 1.0 })` constructor argument	Deprecated
`RenderEditable.textScaleFactor` getter and setter	Deprecated	No Flutter Fix, not expressible yet
`RenderParagraph({ double TextScaleFactor = 1.0 })` constructor argument	Deprecated
`RenderParagraph.textScaleFactor` getter and setter	Deprecated	No Flutter Fix, not expressible yet

`Widgets` Library

Affected API	State of `textScaleFactor`	Comment
`MediaQueryData({ double TextScaleFactor = 1.0 })` constructor argument	To Be Deprecated	https://github.com/flutter/packages/blob/cd7b93532e5cb605a42735e20f1de70fc00adae7/packages/flutter_markdown/test/text_scale_factor_test.dart#LL39C21-L39C35
`MediaQueryData.textScaleFactor` getter	Deprecated
`MediaQueryData.copyWith({ double? TextScaleFactor })` argument	Deprecated
`MediaQuery.maybeTextScaleFactorOf(BuildContext context)` static method	Deprecated	No Flutter Fix, not expressible yet
`MediaQuery.textScaleFactorOf(BuildContext context)` static method	To Be Deprecated	https://github.com/flutter/packages/blob/cd7b93532e5cb605a42735e20f1de70fc00adae7/packages/flutter_markdown/lib/src/_functions_io.dart#L68-L70, No Flutter Fix, not expressible yet
`RichText({ double TextScaleFactor = 1.0 })` constructor argument	To Be Deprecated	https://github.com/flutter/packages/blob/cd7b93532e5cb605a42735e20f1de70fc00adae7/packages/flutter_markdown/lib/src/builder.dart#L829-L843
`RichText.textScaleFactor` getter	To Be Deprecated	A constructor argument can't be deprecated right away
`Text({ double? TextScaleFactor = 1.0 })` constructor argument	To Be Deprecated	https://github.com/flutter/packages/blob/914d120da12fba458c020210727831c31bd71041/packages/rfw/lib/src/flutter/core_widgets.dart#L647 , No Flutter Fix because of dart-lang/sdk#52664
`Text.rich({ double? TextScaleFactor = 1.0 })` constructor argument	To Be Deprecated	The default constructor has an argument that can't be deprecated right away. No Flutter Fix because of dart-lang/sdk#52664
`Text.textScaleFactor` getter	To Be Deprecated	A constructor argument can't be deprecated right away
`EditableText({ double? TextScaleFactor = 1.0 })` constructor argument	Deprecated	No Flutter Fix because of dart-lang/sdk#52664
`EditableText.textScaleFactor` getter	Deprecated

`Material` Library

Affected API	State of `textScaleFactor`	Comment
`SelectableText({ double? TextScaleFactor = 1.0 })` constructor argument	To Be Deprecated	https://github.com/flutter/packages/blob/cd7b93532e5cb605a42735e20f1de70fc00adae7/packages/flutter_markdown/lib/src/builder.dart#L829-L843, No Flutter Fix because of dart-lang/sdk#52664
`SelectableText.rich({ double? TextScaleFactor = 1.0 })` constructor argument	To Be Deprecated	The default constructor has an argument that can't be deprecated right away. No Flutter Fix because of dart-lang/sdk#52664
`SelectableText.textScaleFactor` getter	To Be Deprecated	A constructor argument can't be deprecated right away

A lot of material widgets (Slider, RangeSlider, TimePicker, and different types of buttons) also change their layout based on textScaleFactor. These need to be handled in a case-by-case fashion and will be migrated in follow-up PRs.

justinmc

No major issues from me, mostly smaller stuff and questions. Thanks for doing all the work to migrate everything.

justinmc · 2023-06-12T17:34:24Z

dev/integration_tests/flutter_gallery/lib/gallery/app.dart

  }

  Widget _applyTextScaleFactor(Widget child) {
+    final double? textScaleFactor = _options!.textScaleFactor!.scale;


Nit: Could this go inside the builder method?

justinmc · 2023-06-12T17:42:13Z

packages/flutter/lib/src/cupertino/nav_bar.dart

-      data: MediaQuery.of(context).copyWith(textScaleFactor: 1),
+    // the animation, such as the topLargeTitle. The text scaling is disabled to
+    // avoid odd transitions between pages.
+    return MediaQuery.disableTextScaling(


That's a convenient method 👍

justinmc · 2023-06-12T17:43:03Z

packages/flutter/lib/src/cupertino/search_field.dart

    // to follow the behavior of `UISearchTextField`.
-    final double scaledIconSize =
-        MediaQuery.textScaleFactorOf(context) * widget.itemSize;
+    final double scaledIconSize = MediaQuery.textScalerOf(context).textScaleFactor * widget.itemSize;


Why not use .scale here?

widget.itemSize isn't font size. I'll try to migrate it in the future.

justinmc · 2023-06-12T17:44:31Z

packages/flutter/lib/src/material/button_style_button.dart

-      return EdgeInsetsGeometry.lerp(geometry1x, geometry2x, textScaleFactor - 1)!;
-    }
-    return EdgeInsetsGeometry.lerp(geometry2x, geometry3x, textScaleFactor - 2)!;
+    return switch (textScaleFactor) {


I keep forgetting we can do this now.

justinmc · 2023-06-12T17:45:45Z

packages/flutter/lib/src/material/date_picker.dart

+        child: MediaQuery.withClampedTextScaling(
+          // Constrain the textScaleFactor to the largest supported value to prevent
+          // layout issues.
+          maxScaleFactor: 1.3,


Nit: Maybe make 1.3 a constant since it's used a couple of times here.

Looks like this is still unresolved, but looks like a great idea!

justinmc · 2023-06-12T18:13:17Z

packages/flutter/test/cupertino/scaffold_test.dart

    expect(richTextList.any((RichText text) => text.textScaleFactor != 1), isFalse);

-    expect(tester.widget<RichText>(find.descendant(of: find.text('content'), matching: find.byType(RichText))).textScaleFactor, 99);
+    expect(tester.widget<RichText>(find.descendant(of: find.text('content'), matching: find.byType(RichText))).textScaler, const TextScaler.linear(99.0));


I appreciate all of the times in this PR that you added .0 to a double. Doubles without .0 is a pet peeve of mine.

justinmc · 2023-06-12T18:14:15Z

packages/flutter/test/widgets/media_query_test.dart

    const Size customSize = Size(3.14, 2.72);
    const double customDevicePixelRatio = 1.41;
-    const double customTextScaleFactor = 1.62;
+    const TextScaler customTextScaler = TextScaler.linear(1.23);


Why did the scale change here?

These are random values I think I just copied them over. Shouldn't really matter.

justinmc · 2023-06-12T18:16:56Z

packages/flutter/test/widgets/media_query_test.dart

    ]
  ));
+
+  group('Linear TextScaler', () {


Nit: If you do end up creating a separate text_scaler.dart file, you could put these tests in a new text_scaler_test.dart file. But it's fine either way.

Looks like the TextScaler was moved to its own file. Let's move these tests to their own file as well since they don't relate much to media_quqery_test.dart.

justinmc · 2023-06-12T18:17:50Z

packages/flutter/test/widgets/text_scaler_backward_compatibility_test.dart

+        const TextScaler.linear(2.0),
+      );
+    });
+  });


Thanks for writing these backwards compatibility tests even though they're short lived!

justinmc · 2023-06-12T18:20:02Z

packages/flutter/lib/src/painting/text_painter.dart

+/// [TextScaler] changes. Consider overridding the [==] operator if applicable
+/// to avoid unnecessary rebuilds.
+@immutable
+abstract class TextScaler {


Nit: Could this go into its own new file if you wanted?

goderbauer · 2023-06-12T20:40:48Z

lol @ the title of this PR. Isn't this more accurately described as "Implements TextScaler" or "Replaces textScaleFactor with TextScaler"? 😄

goderbauer · 2023-06-12T20:43:57Z

packages/flutter/lib/fix_data/fix_material/fix_selectable_text.yaml

+# For documentation about this file format, see
+# https://dart.dev/go/data-driven-fixes.
+
+# * Fixes in this file are for RichText from the widgets library. *


RichText (as per this comment) or selectable_text (as per the file name)?

ugh sorry forgot to change those. Updated.

goderbauer · 2023-06-12T20:44:24Z

packages/flutter/lib/fix_data/fix_material/fix_selectable_text.yaml

+# For documentation about this file format, see
+# https://dart.dev/go/data-driven-fixes.
+
+# * Fixes in this file are for RichText from the widgets library. *


Also, widget library (as per this comment) or material (as per the file path)?

goderbauer · 2023-06-12T20:46:15Z

packages/flutter/lib/fix_data/fix_material/fix_selectable_text.yaml

+  - title: "Migrate to 'textScaler'"
+    date: 2023-06-09
+    element:
+      uris: [ 'widgets.dart' ]


this one isn't re-exported by material and cuppertino? (I believe for most (all?) widget.dart fixes we include those two as well...)

changed to material.dart

goderbauer · 2023-06-12T20:47:39Z

packages/flutter/lib/fix_data/fix_widgets/fix_editable_text.yaml

+# For documentation about this file format, see
+# https://dart.dev/go/data-driven-fixes.
+
+# * Fixes in this file are for RichText from the widgets library. *


RichText or EditableText?

goderbauer · 2023-06-12T20:56:30Z

packages/flutter/lib/src/material/selectable_text.dart

  final TextDirection? textDirection;

  /// {@macro flutter.widgets.editableText.textScaleFactor}
  final double? textScaleFactor;


Should this property be deprecated?

I see you list this in the PR description as to be deprecated, would be helpful to mark these with a TODO in the code so we don't forget to do this and people that read this code in the current state are not confused why there are two different ways.

Also, what is your plan for actually doing the deprecation for the "to be deprecated" items?

I'll migrate the packages and then add the Deprecated annotation.

I'll migrate the packages

I can't find where we document it, but we guarantee that the packages in https://github.com/flutter/packages are backwards compatible with x old stable versions. So, it will be quite some time before you can actually migrate these packages to the new API. We shouldn't wait that long to deprecate these - it will just be confusing to have to parallel APIs with no clear indicator which one to use. Typically, we just add ignores for the deprecation message to the lines they appear on in https://github.com/flutter/packages and then land the change in the framework that deprecates them.

Created flutter/packages#4209 to add ignores. But I'm not sure if changes like that needs a version bump or not.

goderbauer · 2023-06-12T22:04:34Z

packages/flutter/lib/src/widgets/media_query.dart

+    double maxScaleFactor = double.infinity,
+    required Widget child,
+  }) {
+    return Builder(builder: (BuildContext context) {


assert that minScaleFactor and maxScaleFactor are in a legal range?

packages/flutter/lib/src/widgets/widget_span.dart

goderbauer · 2023-06-12T22:10:08Z

packages/flutter/lib/src/widgets/widget_span.dart

+      final double? fontSize = switch (span.style?.fontSize) {
+        final double size when size != fontSizeStack.last => size,
+        _ => null,
+      };
+      if (fontSize != null) {
+        fontSizeStack.add(fontSize);
+      }


Isnt' this simply:

final double? fontSize = span.style?.fontSize; if (fontSize != null && fontSize != fontSizeStack.last) { fontSizeStack.add(fontSize); }

This is pushing the fontSize to the stack. Whether fontSize is null also indicates if a pop operation is needed at the end. I guess I'll rename the variable to fontSizeToPush

goderbauer · 2023-06-12T22:12:12Z

packages/flutter/test/widgets/text_scaler_backward_compatibility_test.dart

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Remove this file once textScaleFactor is removed.


nit: phrase this as a TODO?

goderbauer · 2023-06-12T22:12:43Z

packages/flutter/test/widgets/text_scaler_backward_compatibility_test.dart

+    }, skip: kIsWeb); // [intended] CkTextStyle doesn't have a custom toString implementation.
+  });
+  group('TextPainter', () {
+    test('textScaleFactor translates to testScaler', () {


Suggested change

test('textScaleFactor translates to testScaler', () {

test('textScaleFactor translates to textScaler', () {

chunhtai · 2023-06-12T22:28:21Z

packages/flutter/lib/src/painting/text_painter.dart

+  /// The value of this property is only an estimate, so it may not reflect the
+  /// exact text scaling strategy this [TextScaler] represents, especially when
+  /// this [TextScaler] is not linear. Consider using [TextScaler.scale] instead.
+  /// This property exists solely for backward compatibility purposes, such that


If so, we should mark this @Deprecated

otherwise, we should be more confident about the usage of this property. Right now the document sounds like this will probably go away in the future.

chunhtai · 2023-06-12T22:30:09Z

packages/flutter/lib/fix_data/fix_widgets/fix_rich_text.yaml

+      inClass: 'RichText'
+    changes:
+      - kind: 'rename'
+        newName: 'textScaler.textScaleFactor'


are we going to keep this getter forever? otherwise this fix just place them on a temporary state.

It looks like that textScaler.textScaleFactor is deprecated as well. We should remove this dart fix, otherwise the deprecated warning will persist even after the dart fix.

same applies to other dart fix that migrate people to textScaler.textScaleFactor

This is going to be a 2-stage deprecation process: RichText.textScaleFactor will be removed, and after a while TextScaler.textScaleFactor will be removed. In a sense RichText.textScaleFactor is more deprecated than TextScaler.textScaleFactor is and will have a shorter deprecation grace period than textScaler.textScaleFactor.

It does look confusing that dart fix replaces a deprecated getter with another, are you OK if the deprecation message of TextScaler.textScaleFactor is changed to something that tells the developer "this is also deprecated but it's better to use this instead of other textscalefactor"?

Our deprecation policy will remove deprecated field in terms of per stable release, so if they are deprecated in the same stable release, they will also be remove together.

I also suggest we remove them together since it just prolong the time developer will eventually need to migrate to the scale method, and they are already given long enough time to migrate. It also doesn't make it easier to complete the whole migration if they are in this temporary state.

chunhtai · 2023-06-12T22:38:08Z

dev/manual_tests/lib/density.dart

                textDirection: _model.rtl ? TextDirection.rtl : TextDirection.ltr,
-                child: MediaQuery(
-                  data: MediaQuery.of(context).copyWith(textScaleFactor: _model.size),
+                child: MediaQuery.withClampedTextScaling(


This seems like a obscure way to create a linear text scalar

should this do a copyWith TextScaler.linear?

chunhtai · 2023-06-12T22:42:51Z

packages/flutter/lib/src/cupertino/date_picker.dart


-    return MediaQuery(
-      data: MediaQuery.of(context).copyWith(textScaleFactor: 1.0),
+    return MediaQuery.disableTextScaling(


is the disableTextScaling method necessary? It looks like either way of setting textScaleFactor = 1.0 or textScaler.noScaling would work. I assume disableTextScaling is here so that there will just be one way to disable scaling, but once textScaleFactor is removed, this method will be redundant.

That's a convenience method so yes it doesn't do anything special. But I think the implementation is slightly better than just getting MediaQuery.of from CupertinoDatePicker's context, since when MediaQueryData changes only the Builder widget will rebuild (instead of the date picker widget).

…#128522)

This reverts commit b2e22d3.

…#128522)

…aler` (#8903) Corresponds to the framework PR: flutter/flutter#128522 ## Presubmit checklist - [ ] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [ ] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [ ] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. --------- Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]> Co-authored-by: Michael Goderbauer <[email protected]>

Deprecate `textScaleFactor` in favor of `textScaler`, in preparation for Android 14 [Non-linear font scaling to 200%](https://developer.android.com/about/versions/14/features#non-linear-font-scaling). The `TextScaler` class can be moved to `dart:ui` in the future, if we decide to use the Android platform API or AndroidX to get the scaling curve instead of hard coding the curve in the framework. I haven't put the Flutter version in the deprecation message so the analyzer checks are failing. Will do so after I finish the migration guide. **Why `TextScaler.textScaleFactor`** The author of a `TextScaler` subclass should provide a fallback `textScaleFactor`. By making `TextScaler` also contain the `textScaleFactor` information it also makes it easier to migrate: if a widget overrides `MediaQueryData.textScaler` in the tree, for unmigrated widgets in the subtree it would also have to override `MediaQueryData.textScaleFactor`, and that makes it difficult to remove `MediaQueryData.textScaleFactor` in the future. ## A full list of affected APIs in this PR Deprecated: The method/getter/setter/argument is annotated with a `@Deprecated()` annotation in this PR, and the caller should replace it with `textScaler` instead. Unless otherwise specified there will be a Flutter fix available to help with migration but it's still recommended to migrate case-by-case. **Replaced**: The method this `textScaleFactor` argument belongs to is rarely called directly by user code and is not overridden by any of the registered custom tests, so the argument is directly replaced by `TextScaler`. **To Be Deprecated**: The method/getter/setter/argument can't be deprecated in this PR because a registered customer test depends on it and a Flutter fix isn't available (or the test was run without applying flutter fixes first). This method/getter/setter/argument will be deprecated in a followup PR once the registered test is migrated. ### `Painting` Library | Affected API | State of `textScaleFactor` | Comment | | --- | --- | --- | | `InlineSpan.build({ double textScaleFactor = 1.0 })` argument | **Replaced** | | | `TextStyle.getParagraphStyle({ double TextScaleFactor = 1.0 })` argument | **Replaced** | | | `TextStyle.getTextStyle({ double TextScaleFactor = 1.0 })` argument| Deprecated | Can't replace: https://github.com/superlistapp/super_editor/blob/c47fd38dca4b7f43611690913b551a1773c563d7/super_editor/lib/src/infrastructure/super_textfield/desktop/desktop_textfield.dart#L1903-L1905| | `TextPainter({ double TextScaleFactor = 1.0 })` constructor argument | Deprecated | | | `TextPainter.textScaleFactor` getter and setter | Deprecated | No Flutter Fix, not expressible yet | | `TextPainter.computeWidth({ double TextScaleFactor = 1.0 })` argument | Deprecated | | | `TextPainter.computeMaxIntrinsicWidth({ double TextScaleFactor = 1.0 })` argument | Deprecated | | ### `Rendering` Library | Affected API | State of `textScaleFactor` | Comment | | --- | --- | --- | | `RenderEditable({ double TextScaleFactor = 1.0 })` constructor argument | Deprecated | | | `RenderEditable.textScaleFactor` getter and setter | Deprecated | No Flutter Fix, not expressible yet | | `RenderParagraph({ double TextScaleFactor = 1.0 })` constructor argument | Deprecated | | | `RenderParagraph.textScaleFactor` getter and setter | Deprecated | No Flutter Fix, not expressible yet | ### `Widgets` Library | Affected API | State of `textScaleFactor` | Comment | | --- | --- | --- | | `MediaQueryData({ double TextScaleFactor = 1.0 })` constructor argument | **To Be Deprecated** | https://github.com/flutter/packages/blob/cd7b93532e5cb605a42735e20f1de70fc00adae7/packages/flutter_markdown/test/text_scale_factor_test.dart#LL39C21-L39C35 | | `MediaQueryData.textScaleFactor` getter | Deprecated | | | `MediaQueryData.copyWith({ double? TextScaleFactor })` argument | Deprecated | | | `MediaQuery.maybeTextScaleFactorOf(BuildContext context)` static method | Deprecated | No Flutter Fix, not expressible yet | | `MediaQuery.textScaleFactorOf(BuildContext context)` static method | **To Be Deprecated** | https://github.com/flutter/packages/blob/cd7b93532e5cb605a42735e20f1de70fc00adae7/packages/flutter_markdown/lib/src/_functions_io.dart#L68-L70, No Flutter Fix, not expressible yet | | `RichText({ double TextScaleFactor = 1.0 })` constructor argument | **To Be Deprecated** | https://github.com/flutter/packages/blob/cd7b93532e5cb605a42735e20f1de70fc00adae7/packages/flutter_markdown/lib/src/builder.dart#L829-L843 | | `RichText.textScaleFactor` getter | **To Be Deprecated** | A constructor argument can't be deprecated right away| | `Text({ double? TextScaleFactor = 1.0 })` constructor argument | **To Be Deprecated** | https://github.com/flutter/packages/blob/914d120da12fba458c020210727831c31bd71041/packages/rfw/lib/src/flutter/core_widgets.dart#L647 , No Flutter Fix because of dart-lang/sdk#52664 | | `Text.rich({ double? TextScaleFactor = 1.0 })` constructor argument | **To Be Deprecated** | The default constructor has an argument that can't be deprecated right away. No Flutter Fix because of dart-lang/sdk#52664 | | `Text.textScaleFactor` getter | **To Be Deprecated** | A constructor argument can't be deprecated right away | | `EditableText({ double? TextScaleFactor = 1.0 })` constructor argument | Deprecated | No Flutter Fix because of dart-lang/sdk#52664 | | `EditableText.textScaleFactor` getter | Deprecated | | ### `Material` Library | Affected API | State of `textScaleFactor` | Comment | | --- | --- | --- | | `SelectableText({ double? TextScaleFactor = 1.0 })` constructor argument | **To Be Deprecated** | https://github.com/flutter/packages/blob/cd7b93532e5cb605a42735e20f1de70fc00adae7/packages/flutter_markdown/lib/src/builder.dart#L829-L843, No Flutter Fix because of dart-lang/sdk#52664 | | `SelectableText.rich({ double? TextScaleFactor = 1.0 })` constructor argument | **To Be Deprecated** | The default constructor has an argument that can't be deprecated right away. No Flutter Fix because of dart-lang/sdk#52664 | | `SelectableText.textScaleFactor` getter | **To Be Deprecated** | A constructor argument can't be deprecated right away | A lot of material widgets (`Slider`, `RangeSlider`, `TimePicker`, and different types of buttons) also change their layout based on `textScaleFactor`. These need to be handled in a case-by-case fashion and will be migrated in follow-up PRs.

paulobreim · 2023-12-15T23:36:02Z

In all my applications, I use things like:
child: Text('My Text', textScaleFactor: 1.0),

This ensures that even if the user changes the font size in the Android configuration, the text will be presented in the default font, without the risk of "overflowing" the screen.

The problem is that I haven't found the solution yet, to do the same thing with textScaler.
Could anyone give me an example?

tks
paulo

joelrose2 · 2023-12-22T07:27:19Z

The problem is that I haven't found the solution yet, to do the same thing with textScaler. Could anyone give me an example?

See: https://docs.flutter.dev/release/breaking-changes/deprecate-textscalefactor

LongCatIsLooong force-pushed the text-scale-factor-api-changes branch from 17aa8d7 to 3fe3250 Compare June 8, 2023 22:21

github-actions bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: scrolling Viewports, list views, slivers, etc. labels Jun 9, 2023

squash commits

acadd43

LongCatIsLooong force-pushed the text-scale-factor-api-changes branch from a10f938 to acadd43 Compare June 9, 2023 05:09

dart fixes

4bd3f47

github-actions bot added the c: tech-debt Technical debt, code quality, testing, etc. label Jun 9, 2023

LongCatIsLooong added 3 commits June 9, 2023 13:47

fix RichText.textScaleFactor

145b8e3

dart fix

ad84373

Undeprecate textScaleFactor from Text

b7b0691

LongCatIsLooong force-pushed the text-scale-factor-api-changes branch from ab55c7f to 84fe8c3 Compare June 10, 2023 02:20

undeprecate for flutter_markdown

2008762

LongCatIsLooong force-pushed the text-scale-factor-api-changes branch from 84fe8c3 to 2008762 Compare June 10, 2023 05:17

consistent arg names

a583be8

LongCatIsLooong marked this pull request as ready for review June 10, 2023 07:08

LongCatIsLooong requested review from chunhtai, goderbauer and justinmc June 10, 2023 07:08

justinmc reviewed Jun 12, 2023

View reviewed changes

goderbauer reviewed Jun 12, 2023

View reviewed changes

chunhtai reviewed Jun 12, 2023

View reviewed changes

LongCatIsLooong mentioned this pull request Jun 13, 2023

Clean up code introduced during textScaleFactor deprecation. #128825

Open

engine-flutter-autoroll mentioned this pull request Jul 17, 2023

Roll Flutter from c40173f114fa to 0df4496cdb50 (87 revisions) flutter/packages#4500

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

b2e22d3 Replaces textScaleFactor with TextScaler (flutter/flutter…

ff6afcb

…#128522)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Roll Flutter from c40173f114fa to 203ef6f7a32f (111 revisions) flutter/packages#4503

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

b2e22d3 Replaces textScaleFactor with TextScaler (flutter/flutter…

cbf7a88

…#128522)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Roll Flutter from c40173f114fa to 3b0b8348fd3e (112 revisions) flutter/packages#4505

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

b2e22d3 Replaces textScaleFactor with TextScaler (flutter/flutter…

470ae0d

…#128522)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Roll Flutter from c40173f114fa to 8b768de18f29 (113 revisions) flutter/packages#4506

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

b2e22d3 Replaces textScaleFactor with TextScaler (flutter/flutter…

6c33718

…#128522)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Roll Flutter from c40173f114fa to 86385dce684e (114 revisions) flutter/packages#4507

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

b2e22d3 Replaces textScaleFactor with TextScaler (flutter/flutter…

92570bb

…#128522)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Roll Flutter from c40173f114fa to b460d49199e5 (115 revisions) flutter/packages#4508

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

b2e22d3 Replaces textScaleFactor with TextScaler (flutter/flutter…

29077e4

…#128522)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Manual roll Flutter from c40173f114fa to 86385dce684e (114 revisions) flutter/packages#4509

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

b2e22d3 Replaces textScaleFactor with TextScaler (flutter/flutter…

0d1842f

…#128522)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Roll Flutter from c40173f114fa to 94179a8e3fd3 (116 revisions) flutter/packages#4510

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

b2e22d3 Replaces textScaleFactor with TextScaler (flutter/flutter…

fa359cf

…#128522)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Roll Flutter from c40173f114fa to fc2626a790ae (117 revisions) flutter/packages#4512

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

b2e22d3 Replaces textScaleFactor with TextScaler (flutter/flutter…

85cbd49

…#128522)

CaseyHillers added a commit that referenced this pull request Jul 18, 2023

Revert "Replaces textScaleFactor with TextScaler (#128522)"

a3140a8

This reverts commit b2e22d3.

CaseyHillers mentioned this pull request Jul 18, 2023

Revert "Replaces textScaleFactor with TextScaler" #130815

Closed

angelosilvestre mentioned this pull request Jul 19, 2023

Replace textScaleFactor with TextScaler on main Flutter-Bounty-Hunters/super_editor#1238

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2023

b2e22d3 Replaces textScaleFactor with TextScaler (flutter/flutter…

dfb097e

…#128522)

HansMuller mentioned this pull request Jul 21, 2023

Flutter Framework Team: Notable Commits #121415

Closed

MarkOSullivan94 mentioned this pull request Nov 9, 2023

Add support for TextScaler widgetbook/widgetbook#1037

Closed

stuartmorgan-g mentioned this pull request Feb 13, 2024

Replace deprecated textScaleFactor and textScaleFactorOf #143400

Closed

	test('textScaleFactor translates to testScaler', () {
	test('textScaleFactor translates to textScaler', () {

Replaces textScaleFactor with TextScaler #128522

Replaces textScaleFactor with TextScaler #128522

Uh oh!

Conversation

LongCatIsLooong commented Jun 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

A full list of affected APIs in this PR

Painting Library

Rendering Library

Widgets Library

Material Library

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

goderbauer commented Jun 12, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Replaces `textScaleFactor` with `TextScaler` #128522

Replaces `textScaleFactor` with `TextScaler` #128522

LongCatIsLooong commented Jun 8, 2023 •

edited

Loading

`Painting` Library

`Rendering` Library

`Widgets` Library

`Material` Library