Skip to content

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Jun 8, 2023

Fixes #128025

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 8, 2023
fix

wire through workingDirectory

wip try to fix test

fix

fix tests

fix analysis

fix args test

suppress git output during flutter channel

allow testing processStartMode with FakeProcessManager

fix analysis
@christopherfujino christopherfujino force-pushed the suppress-git-output-in-flutter-channel branch from e632e95 to 19486d7 Compare June 13, 2023 17:54
Copy link
Contributor

@andrewkolos andrewkolos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 13, 2023
@auto-submit auto-submit bot merged commit d499533 into flutter:master Jun 13, 2023
@christopherfujino christopherfujino deleted the suppress-git-output-in-flutter-channel branch June 13, 2023 19:28
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 14, 2023
Manual roll requested by [email protected]

flutter/flutter@09b7e56...95be76a

2023-06-14 [email protected] [web] Migrate framework away from dart:html and package:js (flutter/flutter#128580)
2023-06-14 [email protected] Fixed slider value indicator not disappearing after a bit on desktop platform when slider is clicked not dragged (flutter/flutter#128137)
2023-06-14 [email protected] Inline AbstractNode into SemanticsNode and Layer (flutter/flutter#128467)
2023-06-14 [email protected] Roll Flutter Engine from 727b4413fe6f to 2d8d5ecfe4a8 (5 revisions) (flutter/flutter#128842)
2023-06-14 [email protected] Roll Flutter Engine from 66a5761412f9 to 727b4413fe6f (10 revisions) (flutter/flutter#128841)
2023-06-14 [email protected] Roll Flutter Engine from b6bf3a6f1ccd to 66a5761412f9 (1 revision) (flutter/flutter#128813)
2023-06-13 [email protected] Fix syntax error in docstring (flutter/flutter#128692)
2023-06-13 [email protected] Update unit tests in material library for Material 3 (flutter/flutter#128725)
2023-06-13 [email protected] [flutter_tools] Suppress git output in flutter channel (flutter/flutter#128475)
2023-06-13 [email protected] Fix ensureVisible and default focus traversal for reversed scrollables (flutter/flutter#128756)
2023-06-13 [email protected] Roll Flutter Engine from f9a0a0dafeea to b6bf3a6f1ccd (2 revisions) (flutter/flutter#128797)
2023-06-13 [email protected] Update rest of the unit tests in material library for Material 3 (flutter/flutter#128747)
2023-06-13 [email protected] Update tests in material library for Material 3 by default (flutter/flutter#128300)
2023-06-13 [email protected] Update misc tests for Material3 (flutter/flutter#128712)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

the channel command prints irrelevant git output

2 participants