Skip to content

Adding migration guide for Material 3 colors #128429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Jun 8, 2023
Merged

Adding migration guide for Material 3 colors #128429

auto-submit merged 3 commits into from
Jun 8, 2023

Conversation

@leighajarett
Copy link
Contributor

@leighajarett leighajarett commented Jun 7, 2023

Fixes: #127228

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 7, 2023
@leighajarett leighajarett requested a review from HansMuller June 7, 2023 16:13
@HansMuller HansMuller changed the title Adding migration guide for materials 3 colors Adding migration guide for Material 3 colors Jun 7, 2023
HansMuller
HansMuller reviewed Jun 8, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing: to include the same text in multiple places you can use @template to define the text and @macro to include a copy. There are examples in this file.

@leighajarett
Copy link
Contributor Author

leighajarett commented Jun 8, 2023

Thanks! I made changes based on the feedback @HansMuller

@leighajarett leighajarett requested a review from HansMuller June 8, 2023 16:48
HansMuller
HansMuller approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leighajarett leighajarett added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 8, 2023
@auto-submit auto-submit bot merged commit 574a718 into master Jun 8, 2023
@auto-submit auto-submit bot deleted the update_materialcolor_docs_m3 branch June 8, 2023 23:00
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2023
@engine-flutter-autoroll
574a718 Adding migration guide for Material 3 colors (flutter/flutter…
c864dd4 
…#128429)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 9, 2023
@engine-flutter-autoroll
Roll Flutter from 6e254a3 to da127f1 (28 revisions) (#4170)
914d120 
flutter/flutter@6e254a3...da127f1

2023-06-09 [email protected] Updated material button theme tests for Material3 (flutter/flutter#128543)
2023-06-09 [email protected] Roll Flutter Engine from cb93477008d6 to 93afba901b3b (2 revisions) (flutter/flutter#128573)
2023-06-09 [email protected] Improve defaults generation with logging, stats, and token validation (flutter/flutter#128244)
2023-06-09 [email protected] [testing] Make the FLUTTER_STORAGE_BASE_URL warning non-fatal (flutter/flutter#128335)
2023-06-09 [email protected] [flutter_tools] [DAP] Don't try to restart/reload if app hasn't started yet (flutter/flutter#128267)
2023-06-09 [email protected] Roll Flutter Engine from 8f9e608d39ab to cb93477008d6 (3 revisions) (flutter/flutter#128568)
2023-06-09 [email protected] Replace `MaterialButton` from test classes (flutter/flutter#128466)
2023-06-09 [email protected] Fix `showBottomSheet` doesn't remove scrim when draggable sheet is dismissed (flutter/flutter#128455)
2023-06-09 [email protected] Manual roll Flutter Engine from a5f7d5d75ff2 to 8f9e608d39ab (31 revisions) (flutter/flutter#128554)
2023-06-09 [email protected] Revert "test owners: cyanglaz -> vashworth" (flutter/flutter#128462)
2023-06-09 [email protected] [Android] Bump integration tests using `compileSdkVersion` 31 to 33 (flutter/flutter#128072)
2023-06-09 [email protected] Remove single view assumption from MouseTracker, and unify its hit testing code flow (flutter/flutter#127060)
2023-06-09 [email protected] [flutter_tools] Precache after channel switch (flutter/flutter#118129)
2023-06-08 [email protected] Adding migration guide for Material 3 colors (flutter/flutter#128429)
2023-06-08 [email protected] Add `AppLifecycleListener`, with support for application exit handling (flutter/flutter#123274)
2023-06-08 [email protected] Sliver Main Axis Group (flutter/flutter#126596)
2023-06-08 [email protected] Reduce `_DoubleClampVisitor` false positives (flutter/flutter#128539)
2023-06-08 [email protected] Advise developers to use OverflowBar instead of ButtonBar (flutter/flutter#128437)
2023-06-08 [email protected] Reland "Migrate benchmarks to package:web" (flutter/flutter#128266)
2023-06-08 [email protected] Navigator.pop before PopupMenuItem onTap call (flutter/flutter#127446)
2023-06-08 [email protected] Fix navigation rail with long labels misplaced highlights (flutter/flutter#128324)
2023-06-08 [email protected] Update `chip.dart` to use set of `MaterialState` (flutter/flutter#128507)
2023-06-08 [email protected] Update flutter to dartdoc 6.3.0 and hide Icons implementation from doc pages (flutter/flutter#128442)
2023-06-08 [email protected] Disable blinking cursor when `EditableText.showCursor` is false (flutter/flutter#127562)
2023-06-08 [email protected] [floating_cursor_selection]add more comments on the tricky part (flutter/flutter#127227)
2023-06-08 [email protected] Move RenderObjectElement.updateChildren to Element (flutter/flutter#128458)
2023-06-08 [email protected] Fix PointerEventConverter doc (flutter/flutter#128452)
2023-06-08 [email protected] Roll Packages from a84b2c2 to e13b8c4 (9 revisions) (flutter/flutter#128508)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@HansMuller HansMuller mentioned this pull request Jun 9, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
574a718 Adding migration guide for Material 3 colors (flutter/flutter…
6ef996d 
…#128429)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
574a718 Adding migration guide for Material 3 colors (flutter/flutter…
6b2e0fd 
…#128429)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
574a718 Adding migration guide for Material 3 colors (flutter/flutter…
9d1367e 
…#128429)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
574a718 Adding migration guide for Material 3 colors (flutter/flutter…
1703054 
…#128429)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update MaterialColor API docs to migrate to ColorScheme for Material3 apps

2 participants

@leighajarett @HansMuller