Skip to content

[CP][Android] Adds namespace to module build file templates (#126963) #128360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Jun 8, 2023
Merged

[CP][Android] Adds namespace to module build file templates (#126963) #128360

auto-submit merged 2 commits into from
Jun 8, 2023

Conversation

@camsim99
Copy link
Contributor

@camsim99 camsim99 commented Jun 6, 2023 •
edited
Loading

Cherry pick of #126963 to stable.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@camsim99
[Android] Adds namespace to module build file templates (flutter#12…
3c3b1a0 
…6963)

Adds `namespace` to module `build.gradle` file templates.

Fixes flutter#126403.
@flutter-dashboard
Copy link

flutter-dashboard bot commented Jun 6, 2023

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to stable. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard bot changed the base branch from stable to master June 6, 2023 20:51
@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: internationalization Supporting other languages or locales. (aka i18n) a: text input Entering text in a text field or keyboard related problems d: examples Sample code and demos engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Jun 6, 2023
@camsim99 camsim99 changed the base branch from master to stable June 6, 2023 20:52
@camsim99 camsim99 removed a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. labels Jun 6, 2023
@camsim99 camsim99 removed engine flutter/engine related. See also e: labels. f: material design flutter/packages/flutter/material repository. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: internationalization Supporting other languages or locales. (aka i18n) f: scrolling Viewports, list views, slivers, etc. f: cupertino flutter/packages/flutter/cupertino repository d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin labels Jun 6, 2023
@camsim99 camsim99 marked this pull request as ready for review June 6, 2023 20:53
@camsim99 camsim99 mentioned this pull request Jun 6, 2023
Closed
@camsim99 camsim99 changed the title [Android] Adds namespace to module build file templates (#126963) [CP][Android] Adds namespace to module build file templates (#126963) Jun 6, 2023
@gmackall
Copy link
Member

gmackall commented Jun 6, 2023 •
edited
Loading

I believe we want to merge this into flutter-3.10-candidate.1, not stable.

See the hyperlink for stable in the cherry pick process, as well as an example one from last week: #127963

FWIW I went through the exact same set of steps by including the link to the non-cherry-pick pr in the cherry-pick issue, and then opening a PR to beta instead of the specific branch 😅 . Maybe there is room to clarify the documentation, or link in the cherry pick issue template?

@camsim99 camsim99 changed the base branch from stable to flutter-3.10-candidate.1 June 6, 2023 21:53
@camsim99
Copy link
Contributor Author

camsim99 commented Jun 6, 2023

I believe we want to merge this into flutter-3.10-candidate.1, not stable.

See the hyperlink for stable in the cherry pick process, as well as an example one from last week: #127963

FWIW I went through the exact same set of steps by including the link to the non-cherry-pick pr in the cherry-pick issue, and then opening a PR to beta instead of the specific branch 😅 . Maybe there is room to clarify the documentation, or link in the cherry pick issue template?

@gmackall thank you!! I didn't realize that -- oops!

@camsim99
Copy link
Contributor Author

camsim99 commented Jun 8, 2023

@Jasguerrero I think this needs to be submitted so the fix for #126403 is cherry-picked into stable. Sorry about the confusion!

@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 8, 2023
@auto-submit auto-submit bot merged commit d30d38f into flutter:flutter-3.10-candidate.1 Jun 8, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2023
@engine-flutter-autoroll
d30d38f06 [CP][Android] Adds namespace to module build file templat…
2c0efcc 
…es (#126963) (flutter/flutter#128360)
@poovamraj poovamraj mentioned this pull request Jul 11, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmackall gmackall gmackall approved these changes

@stuartmorgan-g stuartmorgan-g Awaiting requested review from stuartmorgan-g

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[add-to-app] error : Namespace not specified. Please specify a namespace in the module's build.gradle

3 participants

@camsim99 @gmackall @CaseyHillers