Skip to content

fix: SearchAnchor View not resizing when in nested navigator #128357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Jun 22, 2023
Merged

fix: SearchAnchor View not resizing when in nested navigator #128357

auto-submit merged 3 commits into from
Jun 22, 2023

Conversation

@VictorOhashi
Copy link
Contributor

@VictorOhashi VictorOhashi commented Jun 6, 2023

Similar to what was done on #127198, look for the closest navigator instead of screen size.

Fixes: #128344

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 6, 2023
@HansMuller HansMuller requested a review from QuncCccccc June 9, 2023 21:49
QuncCccccc
QuncCccccc approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is a nice improvement! Thanks a lot:) Just left one nit.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Jun 22, 2023

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #128357 at sha 55f7f6a

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Jun 22, 2023
Renzo-Olivares
Renzo-Olivares approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 22, 2023
@auto-submit auto-submit bot merged commit 39bf968 into flutter:master Jun 22, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
39bf968 fix: SearchAnchor View not resizing when in nested navigator (f…
d9c0bdc 
…lutter/flutter#128357)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
39bf968 fix: SearchAnchor View not resizing when in nested navigator (f…
b0e8887 
…lutter/flutter#128357)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
39bf968 fix: SearchAnchor View not resizing when in nested navigator (f…
5c5323b 
…lutter/flutter#128357)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
39bf968 fix: SearchAnchor View not resizing when in nested navigator (f…
6786737 
…lutter/flutter#128357)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
39bf968 fix: SearchAnchor View not resizing when in nested navigator (f…
f554b23 
…lutter/flutter#128357)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 24, 2023
@engine-flutter-autoroll
39bf968 fix: SearchAnchor View not resizing when in nested navigator (f…
8f057e3 
…lutter/flutter#128357)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 24, 2023
@engine-flutter-autoroll
39bf968 fix: SearchAnchor View not resizing when in nested navigator (f…
e18edfc 
…lutter/flutter#128357)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 24, 2023
@engine-flutter-autoroll
39bf968 fix: SearchAnchor View not resizing when in nested navigator (f…
cbfb1b6 
…lutter/flutter#128357)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2023
@engine-flutter-autoroll
39bf968 fix: SearchAnchor View not resizing when in nested navigator (f…
ef1b9f6 
…lutter/flutter#128357)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2023
@engine-flutter-autoroll
39bf968 fix: SearchAnchor View not resizing when in nested navigator (f…
0c02ec0 
…lutter/flutter#128357)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2023
@engine-flutter-autoroll
39bf968 fix: SearchAnchor View not resizing when in nested navigator (f…
d5c916d 
…lutter/flutter#128357)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
39bf968 fix: SearchAnchor View not resizing when in nested navigator (f…
fe3e211 
…lutter/flutter#128357)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
39bf968 fix: SearchAnchor View not resizing when in nested navigator (f…
02c5ec3 
…lutter/flutter#128357)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
39bf968 fix: SearchAnchor View not resizing when in nested navigator (f…
10171fa 
…lutter/flutter#128357)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
39bf968 fix: SearchAnchor View not resizing when in nested navigator (f…
016902b 
…lutter/flutter#128357)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
39bf968 fix: SearchAnchor View not resizing when in nested navigator (f…
24bac2e 
…lutter/flutter#128357)
@HansMuller HansMuller mentioned this pull request Jun 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
39bf968 fix: SearchAnchor View not resizing when in nested navigator (f…
4eeb53c 
…lutter/flutter#128357)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
39bf968 fix: SearchAnchor View not resizing when in nested navigator (f…
9aeaaa0 
…lutter/flutter#128357)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
39bf968 fix: SearchAnchor View not resizing when in nested navigator (f…
1733c20 
…lutter/flutter#128357)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
39bf968 fix: SearchAnchor View not resizing when in nested navigator (f…
edae975 
…lutter/flutter#128357)
@VictorOhashi VictorOhashi deleted the fix/search-anchor-128344 branch May 12, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Renzo-Olivares Renzo-Olivares Renzo-Olivares approved these changes

@QuncCccccc QuncCccccc QuncCccccc approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SearchAnchor View not resizing when in nested navigator

3 participants

@VictorOhashi @Renzo-Olivares @QuncCccccc