Fix navigation rail with long labels misplaced highlights #128324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
HansMuller
approved these changes
Jun 6, 2023
Contributor
HansMuller
left a comment
HansMuller
left a comment
There was a problem hiding this comment.
With the addition of one comment, this looks good to go.
Contributor
There was a problem hiding this comment.
A comment that explained what this flag is for would be helpful here.
bleroux
force-pushed
the
fix_navigation_rail_with_long_labels_misplaced_splashes
branch
6 times, most recently
from
f430c99 to
698e7c3
Compare
bleroux
force-pushed
the
fix_navigation_rail_with_long_labels_misplaced_splashes
branch
from
698e7c3 to
f1e62c7
Compare
Contributor
|
Why not make the offset nullable and if null don't use it, if not null use it, thus avoiding the offset boolean flag? |
Contributor
Author
|
@feinstein Because the vertical offset is always used. I considered replacing the indicatorOffset by two variables, indicatorOffsetX and indicatorOffsetY but this was less readable. |
Contributor
|
Ok, makes sense. Thanks for the contribution. |
bleroux
deleted the
fix_navigation_rail_with_long_labels_misplaced_splashes
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 9, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 9, 2023
flutter/flutter@6e254a3...da127f1 2023-06-09 [email protected] Updated material button theme tests for Material3 (flutter/flutter#128543) 2023-06-09 [email protected] Roll Flutter Engine from cb93477008d6 to 93afba901b3b (2 revisions) (flutter/flutter#128573) 2023-06-09 [email protected] Improve defaults generation with logging, stats, and token validation (flutter/flutter#128244) 2023-06-09 [email protected] [testing] Make the FLUTTER_STORAGE_BASE_URL warning non-fatal (flutter/flutter#128335) 2023-06-09 [email protected] [flutter_tools] [DAP] Don't try to restart/reload if app hasn't started yet (flutter/flutter#128267) 2023-06-09 [email protected] Roll Flutter Engine from 8f9e608d39ab to cb93477008d6 (3 revisions) (flutter/flutter#128568) 2023-06-09 [email protected] Replace `MaterialButton` from test classes (flutter/flutter#128466) 2023-06-09 [email protected] Fix `showBottomSheet` doesn't remove scrim when draggable sheet is dismissed (flutter/flutter#128455) 2023-06-09 [email protected] Manual roll Flutter Engine from a5f7d5d75ff2 to 8f9e608d39ab (31 revisions) (flutter/flutter#128554) 2023-06-09 [email protected] Revert "test owners: cyanglaz -> vashworth" (flutter/flutter#128462) 2023-06-09 [email protected] [Android] Bump integration tests using `compileSdkVersion` 31 to 33 (flutter/flutter#128072) 2023-06-09 [email protected] Remove single view assumption from MouseTracker, and unify its hit testing code flow (flutter/flutter#127060) 2023-06-09 [email protected] [flutter_tools] Precache after channel switch (flutter/flutter#118129) 2023-06-08 [email protected] Adding migration guide for Material 3 colors (flutter/flutter#128429) 2023-06-08 [email protected] Add `AppLifecycleListener`, with support for application exit handling (flutter/flutter#123274) 2023-06-08 [email protected] Sliver Main Axis Group (flutter/flutter#126596) 2023-06-08 [email protected] Reduce `_DoubleClampVisitor` false positives (flutter/flutter#128539) 2023-06-08 [email protected] Advise developers to use OverflowBar instead of ButtonBar (flutter/flutter#128437) 2023-06-08 [email protected] Reland "Migrate benchmarks to package:web" (flutter/flutter#128266) 2023-06-08 [email protected] Navigator.pop before PopupMenuItem onTap call (flutter/flutter#127446) 2023-06-08 [email protected] Fix navigation rail with long labels misplaced highlights (flutter/flutter#128324) 2023-06-08 [email protected] Update `chip.dart` to use set of `MaterialState` (flutter/flutter#128507) 2023-06-08 [email protected] Update flutter to dartdoc 6.3.0 and hide Icons implementation from doc pages (flutter/flutter#128442) 2023-06-08 [email protected] Disable blinking cursor when `EditableText.showCursor` is false (flutter/flutter#127562) 2023-06-08 [email protected] [floating_cursor_selection]add more comments on the tricky part (flutter/flutter#127227) 2023-06-08 [email protected] Move RenderObjectElement.updateChildren to Element (flutter/flutter#128458) 2023-06-08 [email protected] Fix PointerEventConverter doc (flutter/flutter#128452) 2023-06-08 [email protected] Roll Packages from a84b2c2 to e13b8c4 (9 revisions) (flutter/flutter#128508) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue related to
InkWellhighlights being misplaced for navigation rail destinations with long labels.flutter_128005_before.mp4
flutter_128005_after.mp4
Related Issue
Fixes #128005
Tests
Adds 1 test.