Pass through type, class and function information for expression evaluation. #128084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
the
tool
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jun 2, 2023
…method and class information for expression evaluation. This information is needed for correct expression compilation. Method name, for example, introduced in 48d8225 is needed for the compiler to confirm extension method context. For flutter flutter/flutter#128084 will be needed. Fixes #52522 Change-Id: I32e53a953ebfb51afb462f4e2169fac0bcee0a7a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/306908 Reviewed-by: Jens Johansen <[email protected]> Reviewed-by: Ben Konyi <[email protected]> Commit-Queue: Alexander Aprelev <[email protected]>
auto-submit bot
pushed a commit
that referenced
this pull request
Jun 2, 2023
#128124) The fix is coming as part of https://dart-review.git.corp.google.com/c/sdk/+/306908 dart sdk roll as well as #128084. BUG=dart-lang/sdk#52522
Member
Author
|
The changes in this PR were rolled as part of dart sdk roll. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This information is particularly needed for evaluating expression inside extension methods.
BUG=dart-lang/sdk#52522