It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Your test is failing on CI:

01:24 +2359 ~2 -1: test/general.shard/dart/pub_get_test.dart: shouldSkipThirdPartyGenerator skips pub get if the package config "generator" is different than "pub" [E]                                
  Expected: contains 'It can be reset by running `dart pub cache clean`'
    Actual: 'Skipping pub get: generated by third-party.\n'
              ''
     Which: does not contain 'It can be reset by running `dart pub cache clean`'
  
  package:matcher                                  expect
  test/general.shard/dart/pub_get_test.dart 249:7  main.<fn>.<fn>

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8778805477762119169/+/u/run_test.dart_for_tool_tests_shard_and_subshard_general/test_stdout

Thanks for submitting this, however, it was since fixed in #128171.

Well that's break my heart

But I understand that because of lack of skills, I'm not able to contribute the correct code as it suppose to be.

Sincerely, codenoid

Well that's break my heart

But I understand that because of lack of skills, I'm not able to contribute the correct code as it suppose to be.

It's definitely not because of a lack of skills. As this was a high profile bug, we had many PRs submitted to fix it, however only one had tests that were all passing, so I merged that one.

Please don't be discouraged from contributing in the future. To maximize the odds your PR is merged, I would suggest:

1. ensure the change you want to make is being tracked by an issue. ensure that tracking issue is not already assigned to someone.
2. If it is a non-trivial change (this was a trivial change), outline your general approach first in the issue and try to get approval from a maintainer. This is not required, but it may save you from spending time working on a feature and having a reviewer say, "I actually don't agree with this approach, sorry I have to close this PR".
3. Ensure you follow all the steps in the PR template checklist (I believe you checked that the PR had tests before you wrote one)
4. Once you open the PR, ensure all the CI checks are passing. If they're not, investigate the failures and try to fix them.

Good luck!