fix a Scrollbar example crash #127925

xu-baolin · 2023-05-31T08:02:20Z

Fix a scrollbar example crash.
https://api.flutter.dev/flutter/material/Scrollbar-class.html#material.Scrollbar.1

flutter-dashboard · 2023-05-31T08:02:24Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

TahaTesser · 2023-06-29T13:06:30Z

Hi @xu-baolin
I cannot reproduce any crash using the sample https://api.flutter.dev/flutter/material/Scrollbar-class.html#material.Scrollbar.2, on the latest stable or previous stable or master.

xu-baolin · 2023-06-29T13:56:24Z

Did you have tried to move the scrollbar thumb?

…

________________________________ 来自TT移动邮箱 / From TT mailbox

________________________________ 发件人: Taha Tesser ***@***.***> 发送时间: 2023年06月29日 21:06 收件人: flutter/flutter ***@***.***> 抄送: 徐宝林(Ava) ***@***.***>; Mention ***@***.***> 主题: Re: [flutter/flutter] fix a Scrollbar example crash (PR #127925) Hi @xu-baolin<https://github.com/xu-baolin> I cannot reproduce any crash using the sample https://api.flutter.dev/flutter/material/Scrollbar-class.html#material.Scrollbar.2, on the latest stable or previous stable or master. ― Reply to this email directly, view it on GitHub<#127925 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOR66GBHBPEJYA7TVGRGQFDXNV4WHANCNFSM6AAAAAAYVCCTDE>. You are receiving this because you were mentioned.Message ID: ***@***.***>

________________________________ OPPO 本电子邮件及其附件含有OPPO公司的保密信息，仅限于邮件指明的收件人（包含个人及群组）使用。禁止任何人在未经授权的情况下以任何形式使用。如果您错收了本邮件，切勿传播、分发、复制、印刷或使用本邮件之任何部分或其所载之任何内容，并请立即以电子邮件通知发件人并删除本邮件及其附件。网络通讯固有缺陷可能导致邮件被截留、修改、丢失、破坏或包含计算机病毒等不安全情况，OPPO对此类错误或遗漏而引致之任何损失概不承担责任并保留与本邮件相关之一切权利。除非明确说明，本邮件及其附件无意作为在任何国家或地区之要约、招揽或承诺，亦无意作为任何交易或合同之正式确认。发件人、其所属机构或所属机构之关联机构或任何上述机构之股东、董事、高级管理人员、员工或其他任何人（以下称“发件人”或“OPPO”）不因本邮件之误送而放弃其所享之任何权利，亦不对因故意或过失使用该等信息而引发或可能引发的损失承担任何责任。文化差异披露：因全球文化差异影响，单纯以YES\OK或其他简单词汇的回复并不构成发件人对任何交易或合同之正式确认或接受，请与发件人再次确认以获得明确书面意见。发件人不对任何受文化差异影响而导致故意或错误使用该等信息所造成的任何直接或间接损害承担责任。 This e-mail and its attachments contain confidential information from OPPO, which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you are not the intended recipient, please do not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. Electronic communications may contain computer viruses or other defects inherently, may not be accurately and/or timely transmitted to other systems, or may be intercepted, modified ,delayed, deleted or interfered. OPPO shall not be liable for any damages that arise or may arise from such matter and reserves all rights in connection with the email. Unless expressly stated, this e-mail and its attachments are provided without any warranty, acceptance or promise of any kind in any country or region, nor constitute a formal confirmation or acceptance of any transaction or contract. The sender, together with its affiliates or any shareholder, director, officer, employee or any other person of any such institution (hereinafter referred to as "sender" or "OPPO") does not waive any rights and shall not be liable for any damages that arise or may arise from the intentional or negligent use of such information. Cultural Differences Disclosure: Due to global cultural differences, any reply with only YES\OK or other simple words does not constitute any confirmation or acceptance of any transaction or contract, please confirm with the sender again to ensure clear opinion in written form. The sender shall not be responsible for any direct or indirect damages resulting from the intentional or misuse of such information.

TahaTesser · 2023-06-29T14:01:31Z

https://api.flutter.dev/flutter/material/Scrollbar-class.html#material.Scrollbar.2

Yes, tried all channels on Dartpad again to be sure.

xu-baolin · 2023-06-29T14:45:26Z

Sorry, the reference link maybe wrong but the sample I fixed is still crashing on api.flutter.dev

…

________________________________ 来自TT移动邮箱 / From TT mailbox

________________________________ 发件人: Taha Tesser ***@***.***> 发送时间: 2023年06月29日 22:01 收件人: flutter/flutter ***@***.***> 抄送: 徐宝林(Ava) ***@***.***>; Mention ***@***.***> 主题: Re: [flutter/flutter] fix a Scrollbar example crash (PR #127925) https://api.flutter.dev/flutter/material/Scrollbar-class.html#material.Scrollbar.2 Yes, tried all channels on Dartpad again to be sure. ― Reply to this email directly, view it on GitHub<#127925 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOR66GH2JKEQ5C7FICURKWLXNWDEPANCNFSM6AAAAAAYVCCTDE>. You are receiving this because you were mentioned.Message ID: ***@***.***>

________________________________ OPPO 本电子邮件及其附件含有OPPO公司的保密信息，仅限于邮件指明的收件人（包含个人及群组）使用。禁止任何人在未经授权的情况下以任何形式使用。如果您错收了本邮件，切勿传播、分发、复制、印刷或使用本邮件之任何部分或其所载之任何内容，并请立即以电子邮件通知发件人并删除本邮件及其附件。网络通讯固有缺陷可能导致邮件被截留、修改、丢失、破坏或包含计算机病毒等不安全情况，OPPO对此类错误或遗漏而引致之任何损失概不承担责任并保留与本邮件相关之一切权利。除非明确说明，本邮件及其附件无意作为在任何国家或地区之要约、招揽或承诺，亦无意作为任何交易或合同之正式确认。发件人、其所属机构或所属机构之关联机构或任何上述机构之股东、董事、高级管理人员、员工或其他任何人（以下称“发件人”或“OPPO”）不因本邮件之误送而放弃其所享之任何权利，亦不对因故意或过失使用该等信息而引发或可能引发的损失承担任何责任。文化差异披露：因全球文化差异影响，单纯以YES\OK或其他简单词汇的回复并不构成发件人对任何交易或合同之正式确认或接受，请与发件人再次确认以获得明确书面意见。发件人不对任何受文化差异影响而导致故意或错误使用该等信息所造成的任何直接或间接损害承担责任。 This e-mail and its attachments contain confidential information from OPPO, which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you are not the intended recipient, please do not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. Electronic communications may contain computer viruses or other defects inherently, may not be accurately and/or timely transmitted to other systems, or may be intercepted, modified ,delayed, deleted or interfered. OPPO shall not be liable for any damages that arise or may arise from such matter and reserves all rights in connection with the email. Unless expressly stated, this e-mail and its attachments are provided without any warranty, acceptance or promise of any kind in any country or region, nor constitute a formal confirmation or acceptance of any transaction or contract. The sender, together with its affiliates or any shareholder, director, officer, employee or any other person of any such institution (hereinafter referred to as "sender" or "OPPO") does not waive any rights and shall not be liable for any damages that arise or may arise from the intentional or negligent use of such information. Cultural Differences Disclosure: Due to global cultural differences, any reply with only YES\OK or other simple words does not constitute any confirmation or acceptance of any transaction or contract, please confirm with the sender again to ensure clear opinion in written form. The sender shall not be responsible for any direct or indirect damages resulting from the intentional or misuse of such information.

TahaTesser · 2023-06-29T15:01:14Z

Ah yes, its actually https://api.flutter.dev/flutter/material/Scrollbar-class.html#material.Scrollbar.1

TahaTesser · 2023-06-29T15:01:43Z

Is it a good practice to add primary: true?

xu-baolin · 2023-06-30T09:58:15Z

Yeah, I think so. It's easier than specifying a controller explicitly, isn't it?

…

________________________________ 来自TT移动邮箱 / From TT mailbox

________________________________ 发件人: Taha Tesser ***@***.***> 发送时间: 2023年06月29日 23:01 收件人: flutter/flutter ***@***.***> 抄送: 徐宝林(Ava) ***@***.***>; Mention ***@***.***> 主题: Re: [flutter/flutter] fix a Scrollbar example crash (PR #127925) Is it a good practice to add primary: true? ― Reply to this email directly, view it on GitHub<#127925 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOR66GDE3QWBWEWAKR6NSMTXNWKGHANCNFSM6AAAAAAYVCCTDE>. You are receiving this because you were mentioned.Message ID: ***@***.***>

________________________________ OPPO 本电子邮件及其附件含有OPPO公司的保密信息，仅限于邮件指明的收件人（包含个人及群组）使用。禁止任何人在未经授权的情况下以任何形式使用。如果您错收了本邮件，切勿传播、分发、复制、印刷或使用本邮件之任何部分或其所载之任何内容，并请立即以电子邮件通知发件人并删除本邮件及其附件。网络通讯固有缺陷可能导致邮件被截留、修改、丢失、破坏或包含计算机病毒等不安全情况，OPPO对此类错误或遗漏而引致之任何损失概不承担责任并保留与本邮件相关之一切权利。除非明确说明，本邮件及其附件无意作为在任何国家或地区之要约、招揽或承诺，亦无意作为任何交易或合同之正式确认。发件人、其所属机构或所属机构之关联机构或任何上述机构之股东、董事、高级管理人员、员工或其他任何人（以下称“发件人”或“OPPO”）不因本邮件之误送而放弃其所享之任何权利，亦不对因故意或过失使用该等信息而引发或可能引发的损失承担任何责任。文化差异披露：因全球文化差异影响，单纯以YES\OK或其他简单词汇的回复并不构成发件人对任何交易或合同之正式确认或接受，请与发件人再次确认以获得明确书面意见。发件人不对任何受文化差异影响而导致故意或错误使用该等信息所造成的任何直接或间接损害承担责任。 This e-mail and its attachments contain confidential information from OPPO, which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you are not the intended recipient, please do not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. Electronic communications may contain computer viruses or other defects inherently, may not be accurately and/or timely transmitted to other systems, or may be intercepted, modified ,delayed, deleted or interfered. OPPO shall not be liable for any damages that arise or may arise from such matter and reserves all rights in connection with the email. Unless expressly stated, this e-mail and its attachments are provided without any warranty, acceptance or promise of any kind in any country or region, nor constitute a formal confirmation or acceptance of any transaction or contract. The sender, together with its affiliates or any shareholder, director, officer, employee or any other person of any such institution (hereinafter referred to as "sender" or "OPPO") does not waive any rights and shall not be liable for any damages that arise or may arise from the intentional or negligent use of such information. Cultural Differences Disclosure: Due to global cultural differences, any reply with only YES\OK or other simple words does not constitute any confirmation or acceptance of any transaction or contract, please confirm with the sender again to ensure clear opinion in written form. The sender shall not be responsible for any direct or indirect damages resulting from the intentional or misuse of such information.

TahaTesser

LGTM

TahaTesser · 2023-06-30T10:03:32Z

Actually, this will need a test exemption from Hixie to land.
However given this is causing crashes, it would be better to add example test that check if takeException is null.

examples/api/lib/material/scrollbar/scrollbar.0.dart

TahaTesser · 2023-07-12T15:52:12Z

@Piinks
Is primary: true necessary for cases like this one? #127925 (comment)

Piinks

Is primary: true necessary for cases like this one?

@TahaTesser on desktop, yup. Since the api docs are often viewed on the web on desktop, this change makes sense to me. Thanks @xu-baolin!

Hixie · 2023-09-05T22:58:20Z

@xu-baolin Is writing a test for this on your radar?

TahaTesser

LGTM

TahaTesser · 2023-09-08T08:52:35Z

@xu-baolin
BTW You'll need to remove the missing test class string from sdk/dev/bots/check_code_samples.dart to land this.

auto-submit · 2023-09-08T08:53:24Z

auto label is removed for flutter/flutter/127925, due to - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

flutter/flutter@aea4552...da676f7 2023-09-08 [email protected] Marks Linux_android very_long_picture_scrolling_perf__e2e_summary to be unflaky (flutter/flutter#134116) 2023-09-08 [email protected] Make `CupertinoTextField` at least as tall as its first line of placeholder (flutter/flutter#134198) 2023-09-08 [email protected] Roll Flutter Engine from f09a139101c3 to 6d6b44886175 (3 revisions) (flutter/flutter#134306) 2023-09-08 [email protected] Update links to iOS embedder docs to point to new Doxygen docs (flutter/flutter#134246) 2023-09-08 [email protected] Roll Packages from 22d4754 to aaae5ef (7 revisions) (flutter/flutter#134301) 2023-09-08 [email protected] Roll Flutter Engine from c38feb382e96 to f09a139101c3 (1 revision) (flutter/flutter#134299) 2023-09-08 [email protected] Roll Flutter Engine from f146d4bf244b to c38feb382e96 (1 revision) (flutter/flutter#134293) 2023-09-08 [email protected] Roll Flutter Engine from a140ab4a4ec6 to f146d4bf244b (1 revision) (flutter/flutter#134290) 2023-09-08 [email protected] Roll Flutter Engine from ea1d0d28e26f to a140ab4a4ec6 (5 revisions) (flutter/flutter#134288) 2023-09-08 [email protected] fix a Scrollbar example crash (flutter/flutter#127925) 2023-09-08 [email protected] Fix `Drawer` examples are missing `dartpad` tag (flutter/flutter#134219) 2023-09-08 [email protected] Roll Flutter Engine from 4ac4429a206b to ea1d0d28e26f (1 revision) (flutter/flutter#134270) 2023-09-08 [email protected] Roll Flutter Engine from df3965a55fd8 to 4ac4429a206b (1 revision) (flutter/flutter#134267) 2023-09-08 [email protected] Roll Flutter Engine from 505ef3c33102 to df3965a55fd8 (1 revision) (flutter/flutter#134263) 2023-09-08 [email protected] _TabBarViewState should dispose created instances of PageController. (flutter/flutter#134091) 2023-09-08 [email protected] Remove non needed controllers in SegmentedButton. (flutter/flutter#134064) 2023-09-08 [email protected] EditableTextState should dispose cursorVisibilityNotifier. (flutter/flutter#133858) 2023-09-08 [email protected] TestWidgetsFlutterBinding should dispose old RestorationManager on reset. (flutter/flutter#133999) 2023-09-08 [email protected] Roll Flutter Engine from 65f6fb841c7a to 505ef3c33102 (4 revisions) (flutter/flutter#134260) 2023-09-07 [email protected] CupertinoAlertDialog should not create ScrollController on every build, if null values are passed in constructor. (flutter/flutter#134075) 2023-09-07 [email protected] Roll Flutter Engine from a828c26e7e97 to 65f6fb841c7a (1 revision) (flutter/flutter#134254) 2023-09-07 [email protected] _SearchBarState should dispose FocusNode, if it created it. (flutter/flutter#134076) 2023-09-07 [email protected] Roll Flutter Engine from 2dba8ceca824 to a828c26e7e97 (8 revisions) (flutter/flutter#134249) 2023-09-07 [email protected] [integration_test] Allow capture of screenshots for `FlutterFragmentActivity`s (flutter/flutter#132406) 2023-09-07 [email protected] Roll Flutter Engine from 8d07c2947e60 to 2dba8ceca824 (2 revisions) (flutter/flutter#134243) 2023-09-07 [email protected] Fix `ExpansionTile` properties cannot be updated with `setState` (flutter/flutter#134218) 2023-09-07 [email protected] [Windows Arm64] Remove device_type property (flutter/flutter#134181) 2023-09-07 [email protected] Roll Flutter Engine from f0b718e28779 to 8d07c2947e60 (3 revisions) (flutter/flutter#134240) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions bot removed c: contributor-productivity Team-specific productivity, code health, technical debt. f: scrolling Viewports, list views, slivers, etc. labels May 31, 2023

TahaTesser self-requested a review June 29, 2023 12:55

github-actions bot added c: contributor-productivity Team-specific productivity, code health, technical debt. f: scrolling Viewports, list views, slivers, etc. and removed f: material design flutter/packages/flutter/material repository. labels Jun 30, 2023

TahaTesser approved these changes Jun 30, 2023

View reviewed changes

TahaTesser added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Jun 30, 2023

TahaTesser requested changes Jun 30, 2023

View reviewed changes

examples/api/lib/material/scrollbar/scrollbar.0.dart Outdated Show resolved Hide resolved

Hixie removed the documentation label Jul 5, 2023

Piinks reviewed Jul 18, 2023

View reviewed changes

xu-baolin force-pushed the xbl230530 branch from 3033cda to 276b0a0 Compare September 8, 2023 08:42

github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Sep 8, 2023

add a test

b825d4f

xu-baolin force-pushed the xbl230530 branch from 276b0a0 to b825d4f Compare September 8, 2023 08:44

TahaTesser approved these changes Sep 8, 2023

View reviewed changes

TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 8, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 8, 2023

++

7313485

TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 8, 2023

auto-submit bot merged commit f4707c2 into flutter:master Sep 8, 2023

engine-flutter-autoroll mentioned this pull request Sep 8, 2023

Roll Flutter from aea4552acdc7 to 7b06874ef565 (23 revisions) flutter/packages#4871

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 8, 2023

f4707c2 fix a Scrollbar example crash (flutter/flutter#127925)

f84fb2c

engine-flutter-autoroll mentioned this pull request Sep 8, 2023

Roll Flutter from aea4552acdc7 to 53017f8525e6 (24 revisions) flutter/packages#4872

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 8, 2023

f4707c2 fix a Scrollbar example crash (flutter/flutter#127925)

8d1f08d

engine-flutter-autoroll mentioned this pull request Sep 8, 2023

Roll Flutter from aea4552acdc7 to 3ce6174e6b49 (25 revisions) flutter/packages#4873

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 8, 2023

f4707c2 fix a Scrollbar example crash (flutter/flutter#127925)

25bff37

engine-flutter-autoroll mentioned this pull request Sep 8, 2023

Roll Flutter from aea4552acdc7 to da676f79aa37 (28 revisions) flutter/packages#4874

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 8, 2023

f4707c2 fix a Scrollbar example crash (flutter/flutter#127925)

c836f43

HansMuller mentioned this pull request Sep 8, 2023

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023

f4707c2 fix a Scrollbar example crash (flutter/flutter#127925)

5fdc24a

fix a Scrollbar example crash #127925

fix a Scrollbar example crash #127925

Uh oh!

Conversation

xu-baolin commented May 31, 2023 • edited by TahaTesser Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flutter-dashboard bot commented May 31, 2023

Uh oh!

TahaTesser commented Jun 29, 2023

Uh oh!

xu-baolin commented Jun 29, 2023 via email

Uh oh!

TahaTesser commented Jun 29, 2023

Uh oh!

xu-baolin commented Jun 29, 2023 via email

Uh oh!

TahaTesser commented Jun 29, 2023

Uh oh!

TahaTesser commented Jun 29, 2023

Uh oh!

xu-baolin commented Jun 30, 2023 via email

Uh oh!

TahaTesser left a comment

Choose a reason for hiding this comment

Uh oh!

TahaTesser commented Jun 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

TahaTesser commented Jul 12, 2023

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Hixie commented Sep 5, 2023

Uh oh!

TahaTesser left a comment

Choose a reason for hiding this comment

Uh oh!

TahaTesser commented Sep 8, 2023

Uh oh!

auto-submit bot commented Sep 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

xu-baolin commented May 31, 2023 •

edited by TahaTesser

Loading

TahaTesser commented Jun 30, 2023 •

edited

Loading