Skip to content

Refactor "app plugin loader" Gradle Plugin so it can be applied using the declarative plugins {} block #127897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 38 commits into from
Sep 22, 2023
Merged

Refactor "app plugin loader" Gradle Plugin so it can be applied using the declarative plugins {} block #127897

auto-submit merged 38 commits into from
Sep 22, 2023

Conversation

@bartekpacia
Copy link
Member

@bartekpacia bartekpacia commented May 30, 2023 •
edited
Loading

This PR fixes #125009.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels May 30, 2023
@github-actions github-actions bot removed c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels May 30, 2023
@bartekpacia bartekpacia marked this pull request as ready for review May 31, 2023 00:21
@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels May 31, 2023
@flutter-dashboard
Copy link

flutter-dashboard bot commented May 31, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@bartekpacia
Copy link
Member Author

bartekpacia commented May 31, 2023

module_plugin_loader should be refactored like this as well.

@github-actions github-actions bot removed c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels May 31, 2023
@goderbauer goderbauer added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Jun 1, 2023
@bartekpacia
Copy link
Member Author

bartekpacia commented Jun 1, 2023 •
edited
Loading

Problem 1: I cannot get com.android.tools.build:gradle into FGP's runtime classpath.

Problem 2: implementation('com.android.tools.build:gradle:xxx') isn't resolved for some strange reason (aside from that we shouldn't probably use implementation at all here)

@bartekpacia
remove all debug prints
5df0a52
@bartekpacia
move FlutterPluginKts into its own file
9d20179 
fails with:

* Where:
Build file '/Users/bartek/fvm/versions/master/examples/hello_world/android/build.gradle' line: 39

* What went wrong:
A problem occurred evaluating root project 'android'.
> Build completed with 1 failures.
   > 'void Flutter_gradle.<init>(org.gradle.kotlin.dsl.support.KotlinScriptHost, org.gradle.api.Project)'
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 22, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 22, 2023

auto label is removed for flutter/flutter/127897, due to This PR has not met approval requirements for merging. Changes were requested by {dnfield}, please make the needed changes and resubmit this PR.
You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@gmackall
Copy link
Member

gmackall commented Sep 22, 2023

Dismissing review from @dnfield as stale (all points were addressed), so I can get autosubmit to stick.

@gmackall gmackall dismissed dnfield’s stale review September 22, 2023 16:28

It has been addressed

@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 22, 2023
@auto-submit auto-submit bot merged commit dbe0ccd into flutter:master Sep 22, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
dbe0ccd Refactor "app plugin loader" Gradle Plugin so it can be appli…
8a7431c 
…ed using the declarative `plugins {}` block (flutter/flutter#127897)
@bartekpacia bartekpacia deleted the declarative_app_plugin_loader_gradle_plugin branch September 22, 2023 16:39
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
dbe0ccd Refactor "app plugin loader" Gradle Plugin so it can be appli…
713149a 
…ed using the declarative `plugins {}` block (flutter/flutter#127897)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 25, 2023
@engine-flutter-autoroll
dbe0ccd Refactor "app plugin loader" Gradle Plugin so it can be appli…
41e2e4d 
…ed using the declarative `plugins {}` block (flutter/flutter#127897)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
dbe0ccd Refactor "app plugin loader" Gradle Plugin so it can be appli…
8296b63 
…ed using the declarative `plugins {}` block (flutter/flutter#127897)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
dbe0ccd Refactor "app plugin loader" Gradle Plugin so it can be appli…
2ab7b73 
…ed using the declarative `plugins {}` block (flutter/flutter#127897)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
dbe0ccd Refactor "app plugin loader" Gradle Plugin so it can be appli…
2200dbc 
…ed using the declarative `plugins {}` block (flutter/flutter#127897)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
dbe0ccd Refactor "app plugin loader" Gradle Plugin so it can be appli…
23c52ec 
…ed using the declarative `plugins {}` block (flutter/flutter#127897)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
dbe0ccd Refactor "app plugin loader" Gradle Plugin so it can be appli…
29c832a 
…ed using the declarative `plugins {}` block (flutter/flutter#127897)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
dbe0ccd Refactor "app plugin loader" Gradle Plugin so it can be appli…
d0e2518 
…ed using the declarative `plugins {}` block (flutter/flutter#127897)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
dbe0ccd Refactor "app plugin loader" Gradle Plugin so it can be appli…
3804715 
…ed using the declarative `plugins {}` block (flutter/flutter#127897)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
dbe0ccd Refactor "app plugin loader" Gradle Plugin so it can be appli…
397bc22 
…ed using the declarative `plugins {}` block (flutter/flutter#127897)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
dbe0ccd Refactor "app plugin loader" Gradle Plugin so it can be appli…
1a08e04 
…ed using the declarative `plugins {}` block (flutter/flutter#127897)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
dbe0ccd Refactor "app plugin loader" Gradle Plugin so it can be appli…
d3350b1 
…ed using the declarative `plugins {}` block (flutter/flutter#127897)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
dbe0ccd Refactor "app plugin loader" Gradle Plugin so it can be appli…
0ff9da3 
…ed using the declarative `plugins {}` block (flutter/flutter#127897)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
dbe0ccd Refactor "app plugin loader" Gradle Plugin so it can be appli…
c5f2f0d 
…ed using the declarative `plugins {}` block (flutter/flutter#127897)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
dbe0ccd Refactor "app plugin loader" Gradle Plugin so it can be appli…
b987949 
…ed using the declarative `plugins {}` block (flutter/flutter#127897)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
dbe0ccd Refactor "app plugin loader" Gradle Plugin so it can be appli…
478ca0c 
…ed using the declarative `plugins {}` block (flutter/flutter#127897)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
dbe0ccd Refactor "app plugin loader" Gradle Plugin so it can be appli…
8d9d971 
…ed using the declarative `plugins {}` block (flutter/flutter#127897)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
dbe0ccd Refactor "app plugin loader" Gradle Plugin so it can be appli…
fbe0319 
…ed using the declarative `plugins {}` block (flutter/flutter#127897)
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@bartekpacia @Mairramer
Refactor "app plugin loader" Gradle Plugin so it can be applied using…
ccb43b4 
… the declarative `plugins {}` block (flutter#127897)

This PR fixes flutter#125009.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
dbe0ccd Refactor "app plugin loader" Gradle Plugin so it can be appli…
3b7c386 
…ed using the declarative `plugins {}` block (flutter/flutter#127897)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbaker reidbaker reidbaker approved these changes

@gmackall gmackall gmackall approved these changes

@dnfield dnfield Awaiting requested review from dnfield

@johnmccutchan johnmccutchan Awaiting requested review from johnmccutchan

+1 more reviewer

@TWiStErRob TWiStErRob TWiStErRob left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Load "flutter loader plugin" using Gradle's plugins {} block, rather than imperative apply

8 participants

@bartekpacia @reidbaker @gnprice @TWiStErRob @gmackall @johnmccutchan @dnfield @goderbauer