Skip to content

Update android manifests to set exported:true on main activities in integration test for api 33 support #127892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
May 30, 2023
Merged

Update android manifests to set exported:true on main activities in integration test for api 33 support #127892

auto-submit merged 2 commits into from
May 30, 2023

Conversation

@reidbaker
Copy link
Contributor

@reidbaker reidbaker commented May 30, 2023

Update android manifests to set exported:true on main activities in integration test for api 33 support

#127689
#127884 is resolved by https://flutter-review.googlesource.com/c/recipes/+/45181 but this pr is required to reland.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. labels May 30, 2023
zanderso
zanderso approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I missing a bunch of context, but If this flag is backwards compatible, would it make sense to eagerly set it everywhere instead of only in the tests that have failed so far?

@github-actions github-actions bot removed a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. labels May 30, 2023
@reidbaker
Copy link
Contributor Author

reidbaker commented May 30, 2023

lgtm

I missing a bunch of context, but If this flag is backwards compatible, would it make sense to eagerly set it everywhere instead of only in the tests that have failed so far?

I believe that is what I did. All the other android manifest files either didnt have an activity or were already exported.

find integration_tests -type f -name 'AndroidManifest.xml' | grep -v build | xargs code

If you think I missed something let me know.

@dnfield
Copy link
Contributor

dnfield commented May 30, 2023

This got updated in the template at some point but no one went back through all the androidManifest files in the repo to add it.

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label May 30, 2023
@auto-submit auto-submit bot merged commit 587e9cf into flutter:master May 30, 2023
@reidbaker reidbaker deleted the i127682-update-manifests-for-api-33 branch May 30, 2023 23:55
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2023
@engine-flutter-autoroll
587e9cf Update android manifests to set exported:true on main activit…
6c3c851 
…ies in integration test for api 33 support (flutter/flutter#127892)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
587e9cf Update android manifests to set exported:true on main activit…
e0db799 
…ies in integration test for api 33 support (flutter/flutter#127892)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
587e9cf Update android manifests to set exported:true on main activit…
1bce5c5 
…ies in integration test for api 33 support (flutter/flutter#127892)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
587e9cf Update android manifests to set exported:true on main activit…
3e9ec7c 
…ies in integration test for api 33 support (flutter/flutter#127892)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
587e9cf Update android manifests to set exported:true on main activit…
b0e22da 
…ies in integration test for api 33 support (flutter/flutter#127892)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso zanderso approved these changes

@gmackall gmackall Awaiting requested review from gmackall

@camsim99 camsim99 Awaiting requested review from camsim99

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reidbaker @dnfield @zanderso