-
Notifications
You must be signed in to change notification settings - Fork 29.7k
[CP] fix: Search anchor box location when used on nested navigator #127696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP] fix: Search anchor box location when used on nested navigator #127696
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
auto label is removed for flutter/flutter, pr: 127696, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.
|
|
auto label is removed for flutter/flutter, pr: 127696, due to - The status or check suite Mac plugin_lint_mac has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
@CaseyHillers Any ideia if this CP will go on next hotfix? |
|
@itsjustkevin do you know if this will get shipped in this week's release? |
|
@CaseyHillers and @VictorOhashi due to the failing check, this is not likely to make this release. @VictorOhashi please take a look at the test failure |
Any idea on why failed? I thought it was related to #127808 |
|
@VictorOhashi this should make it in the next release. There's some infra issues that are being worked out with some recent changes to how the bots download xcode. Once those fixes land, I can update this PR to pull them in. |
|
auto label is removed for flutter/flutter, pr: 127696, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.
|
HansMuller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Cherry pick PR
#127582
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.