Skip to content

Conversation

@VictorOhashi
Copy link
Contributor

Cherry pick PR
#127582

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels May 26, 2023
@VictorOhashi VictorOhashi marked this pull request as ready for review May 26, 2023 17:56
@VictorOhashi VictorOhashi changed the title fix: Search anchor box location when used on nested navigator [CP] fix: Search anchor box location when used on nested navigator May 26, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label May 29, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 29, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented May 29, 2023

auto label is removed for flutter/flutter, pr: 127696, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented May 29, 2023

auto label is removed for flutter/flutter, pr: 127696, due to - The status or check suite Mac plugin_lint_mac has failed. Please fix the issues identified (or deflake) before re-applying this label.

@VictorOhashi
Copy link
Contributor Author

@CaseyHillers Any ideia if this CP will go on next hotfix?

@CaseyHillers
Copy link
Contributor

@itsjustkevin do you know if this will get shipped in this week's release?

@itsjustkevin
Copy link
Contributor

@CaseyHillers and @VictorOhashi due to the failing check, this is not likely to make this release.

@VictorOhashi please take a look at the test failure Mac plugin_lint_mac

@VictorOhashi
Copy link
Contributor Author

@CaseyHillers and @VictorOhashi due to the failing check, this is not likely to make this release.

@VictorOhashi please take a look at the test failure Mac plugin_lint_mac

Any idea on why failed? I thought it was related to #127808

@CaseyHillers
Copy link
Contributor

@VictorOhashi this should make it in the next release. There's some infra issues that are being worked out with some recent changes to how the bots download xcode. Once those fixes land, I can update this PR to pull them in.

@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 1, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 1, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 1, 2023

auto label is removed for flutter/flutter, pr: 127696, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itsjustkevin itsjustkevin added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 1, 2023
@auto-submit auto-submit bot merged commit cceba44 into flutter:flutter-3.10-candidate.1 Jun 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2023
@VictorOhashi VictorOhashi deleted the cp/search-anchor branch May 12, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants