Skip to content

i127682 android api 33 test support #127689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
May 31, 2023
Merged

i127682 android api 33 test support #127689

auto-submit merged 4 commits into from
May 31, 2023

Conversation

@reidbaker
Copy link
Contributor

@reidbaker reidbaker commented May 26, 2023 •
edited
Loading

  • try to set emulator to version 33 to see what happens

#127682

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@reidbaker
Copy link
Contributor Author

reidbaker commented May 26, 2023

This is blocked by finding the CIPD entry for android_virtual_device.

@reidbaker
Copy link
Contributor Author

reidbaker commented May 30, 2023

This is blocked by finding the CIPD entry for android_virtual_device.

Resolved by
https://flutter-review.googlesource.com/c/recipes/+/45049

@reidbaker reidbaker marked this pull request as ready for review May 30, 2023 20:50
@reidbaker
Copy link
Contributor Author

reidbaker commented May 30, 2023

https://firebase.corp.google.com/project/flutter-infra-staging/testlab/histories/bh.554c4369930daa2b/matrices/5087782873511167545/executions/bs.4d54083875c6b448

Failed to finalize session : INSTALL_PARSE_FAILED_MANIFEST_MALFORMED: Failed parse during installPackageLI: /data/app/vmdl740390724.tmp/base.apk (at Binary XML file line #27): com.example.release_smoke_test.MainActivity: Targeting S+ (version 31 and above) requires that an explicit value for android:exported be defined when intent filters are present

@dnfield
Copy link
Contributor

dnfield commented May 30, 2023

In the AndroidManifest.xml for hello_world you need to add that attribute. Grep the repo and you'll see other examples of it.

@dnfield
Copy link
Contributor

dnfield commented May 30, 2023

e.g. https://github.com/flutter/flutter/blob/main/dev/benchmarks/complex_layout/android/app/src/main/AndroidManifest.xml#L11

@reidbaker reidbaker mentioned this pull request May 30, 2023
Merged
8 tasks
auto-submit bot pushed a commit that referenced this pull request May 30, 2023
@reidbaker
Update android manifests to set exported:true on main activities in i…
587e9cf 
…ntegration test for api 33 support (#127892)

Update android manifests to set exported:true on main activities in integration test for api 33 support

#127689 
#127884 is resolved by https://flutter-review.googlesource.com/c/recipes/+/45181 but this pr is required to reland.
@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label May 31, 2023
@auto-submit auto-submit bot merged commit b479691 into flutter:master May 31, 2023
@reidbaker reidbaker deleted the i127682-android-api-33-test-support branch June 1, 2023 12:26
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2023
@engine-flutter-autoroll
b479691 i127682 android api 33 test support (flutter/flutter#127689)
fcb851e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
b479691 i127682 android api 33 test support (flutter/flutter#127689)
f084f20
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
b479691 i127682 android api 33 test support (flutter/flutter#127689)
3de1353
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
b479691 i127682 android api 33 test support (flutter/flutter#127689)
9424c0f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
b479691 i127682 android api 33 test support (flutter/flutter#127689)
9a007db
@gmackall gmackall mentioned this pull request Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ricardoamador ricardoamador Awaiting requested review from ricardoamador

@johnmccutchan johnmccutchan Awaiting requested review from johnmccutchan

@gmackall gmackall Awaiting requested review from gmackall

@camsim99 camsim99 Awaiting requested review from camsim99

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reidbaker @dnfield