Use --target-os for appropriate precompiled targets.
#127567
Merged
+30
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
github-actions
bot
removed
the
tool
sstrickl
force-pushed
the
target-os
branch
2 times, most recently
from
1036412 to
280d6e1
Compare
flutter-dashboard
bot
added
the
tool
github-actions
bot
removed
the
tool
Contributor
|
@christopherfujino ptal |
christopherfujino
approved these changes
Jun 1, 2023
Contributor
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
LGTM, this is cool!
goderbauer
added
the
tool
Member
|
Landing on @sstrickl 's behalf. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 8, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 8, 2023
flutter/flutter@8a5c22e...6e254a3 2023-06-08 [email protected] [labeler] Set sync labels to false to stop removing labels (flutter/flutter#128446) 2023-06-08 [email protected] Update Chrome version for testing (flutter/flutter#128447) 2023-06-08 [email protected] Revert "Redo make inspector weakly referencing the inspected objects." (flutter/flutter#128506) 2023-06-08 [email protected] Use `--target-os` for appropriate precompiled targets. (flutter/flutter#127567) 2023-06-08 [email protected] Redo make inspector weakly referencing the inspected objects. (flutter/flutter#128471) 2023-06-07 [email protected] Roll Flutter Engine from 1089ce6874cf to a5f7d5d75ff2 (11 revisions) (flutter/flutter#128473) 2023-06-07 [email protected] Disable context menu (flutter/flutter#128365) 2023-06-07 [email protected] Adds vmservices to retrieve android applink settings (flutter/flutter#125998) 2023-06-07 [email protected] Roll Flutter Engine from 4f4486b00be2 to 1089ce6874cf (20 revisions) (flutter/flutter#128460) 2023-06-07 [email protected] Fix typos 'wether' -> 'whether' (flutter/flutter#128392) 2023-06-07 [email protected] Roll engine, patch expression evaluation (flutter/flutter#128255) 2023-06-07 [email protected] Roll Packages from da72219 to a84b2c2 (1 revision) (flutter/flutter#128444) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds uses of the
--target-oscommand line argument when building kernel sources for precompiled applications for supported target operating systems. The Dart CFE then:Platform.operatingSystemas if it were defined as the constant string provided as an argument to the flag,Platform.pathSeparatoras the appropriate separator for that operating system,vm:platform-constpragma, andvm:platform-constpragma.The
vm:platform-constpragma can appear in either library or user code. If the attempt to constant evaluate the field initializer or method call fails, then an error is thrown at kernel compilation time.Addresses #14233.
The tests in
packages/flutter_tools/test/general.shard/build_system/targets/common_test.darthave been adjusted properly to account for the new passed command line arguments.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.