Skip to content

Adds TestDisplay API for testing Display features #127525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 5 commits into from
May 26, 2023
Merged

Adds TestDisplay API for testing Display features #127525

auto-submit merged 5 commits into from
May 26, 2023

Conversation

@pdblasi-google
Copy link
Contributor

@pdblasi-google pdblasi-google commented May 24, 2023 •
edited
Loading

  • Adds TestDisplay
  • Updates TestPlatformDispatcher to wrap all Displays and relate them to their appropriate TestFlutterView
  • Updates TestFlutterView to tie devicePixelRatio to its display as per the documentation on Display

Closes #127225

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels May 24, 2023
@github-actions github-actions bot removed the framework flutter/packages/flutter repository. See also f: labels. label May 24, 2023
pdblasi-google
pdblasi-google commented May 24, 2023
View reviewed changes
@pdblasi-google
Adds TestDisplay API for testing Display features
71a8cef 
* Adds `TestDisplay`
* Updates `TestPlatformDispatcher` to wrap all `Display`s and relate them to their appropriate `TestFlutterView`
* Updates `TestFlutterView` to tie `devicePixelRatio` to its display as per the documentation on `Display`
@pdblasi-google
Updates from self review.
e19cc7d
@pdblasi-google
Added missing license header.
29f9415
@pdblasi-google pdblasi-google requested a review from dnfield May 25, 2023 18:47
dnfield
dnfield reviewed May 25, 2023
View reviewed changes
dnfield
dnfield reviewed May 25, 2023
View reviewed changes
dnfield
dnfield reviewed May 25, 2023
View reviewed changes
dnfield
dnfield approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

@pdblasi-google pdblasi-google added the autosubmit Merge PR when tree becomes green via auto submit App label May 25, 2023
@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label May 25, 2023
@auto-submit auto-submit bot merged commit 07f7ffd into flutter:master May 26, 2023
@pdblasi-google pdblasi-google deleted the issues/127225 branch May 26, 2023 00:04
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 26, 2023
@engine-flutter-autoroll
07f7ffd Adds TestDisplay API for testing Display features (flutte…
22ba7c2 
…r/flutter#127525)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 26, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 26, 2023
@engine-flutter-autoroll
07f7ffd Adds TestDisplay API for testing Display features (flutte…
a184557 
…r/flutter#127525)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 26, 2023
@engine-flutter-autoroll
Roll Flutter from 216605b to ee162e4 (53 revisions) (#4090)
0906c5f 
Roll Flutter from 216605b to ee162e4 (53 revisions)

flutter/flutter@216605b...ee162e4

2023-05-26 [email protected] Roll Packages from 995bfc5 to 9f8dcc5 (4 revisions) (flutter/flutter#127671)
2023-05-26 [email protected] Roll Flutter Engine from 474fcbbe445e to 8573f3b63a1f (1 revision) (flutter/flutter#127647)
2023-05-26 [email protected] Roll Flutter Engine from f63fcf5a274e to 474fcbbe445e (1 revision) (flutter/flutter#127644)
2023-05-26 [email protected] Roll Flutter Engine from b6fcbe31ba1a to f63fcf5a274e (1 revision) (flutter/flutter#127642)
2023-05-26 [email protected] Roll Flutter Engine from bec5da5bff7c to b6fcbe31ba1a (1 revision) (flutter/flutter#127641)
2023-05-26 [email protected] Roll Flutter Engine from 593d4d6b1f9b to bec5da5bff7c (2 revisions) (flutter/flutter#127638)
2023-05-26 [email protected] Roll Flutter Engine from f4dc96aef71b to 593d4d6b1f9b (1 revision) (flutter/flutter#127635)
2023-05-26 [email protected] Roll Flutter Engine from ff04d2fdd12b to f4dc96aef71b (2 revisions) (flutter/flutter#127633)
2023-05-26 [email protected] Remove a bad assert from tooltip implementation (flutter/flutter#127629)
2023-05-26 [email protected] Remove rounding from TextPainter (flutter/flutter#127099)
2023-05-26 [email protected] Adds `TestDisplay` API for testing `Display` features (flutter/flutter#127525)
2023-05-25 [email protected] Roll Flutter Engine from 6a4e675ab0b4 to ff04d2fdd12b (3 revisions) (flutter/flutter#127630)
2023-05-25 [email protected] Roll Flutter Engine from 99f2653cbb79 to 6a4e675ab0b4 (2 revisions) (flutter/flutter#127625)
2023-05-25 [email protected] Append $flutter/osx sdk property to existing platforms/targets relying on xcode (flutter/flutter#127537)
2023-05-25 [email protected] Indent markdown value on CP issue template (flutter/flutter#127623)
2023-05-25 [email protected] Roll Flutter Engine from 6ff02c17268f to 99f2653cbb79 (6 revisions) (flutter/flutter#127619)
2023-05-25 [email protected] `ProcessResultMatcher` created and used in test (flutter/flutter#127414)
2023-05-25 [email protected] Fix yaml lint issue (flutter/flutter#127600)
2023-05-25 [email protected] Roll Flutter Engine from 515a4bfc4b6e to 6ff02c17268f (1 revision) (flutter/flutter#127609)
2023-05-25 [email protected] `SearchBar` should not be impacted by overall `InputDecorationTheme` (flutter/flutter#127465)
2023-05-25 [email protected] Roll Flutter Engine from 195009b91abd to 515a4bfc4b6e (4 revisions) (flutter/flutter#127601)
2023-05-25 [email protected] Roll Flutter Engine from fb463217d1f3 to 195009b91abd (1 revision) (flutter/flutter#127591)
2023-05-25 [email protected] avoid incorrect usage of TimelineTask (flutter/flutter#127527)
2023-05-25 [email protected] Add `ScrollNotificationObserver` sample (flutter/flutter#127023)
2023-05-25 [email protected] Roll Packages from fba97fa to 995bfc5 (3 revisions) (flutter/flutter#127590)
2023-05-25 [email protected] Roll Flutter Engine from a74d9d1f4776 to fb463217d1f3 (1 revision) (flutter/flutter#127577)
2023-05-25 [email protected] Roll Flutter Engine from a7f026b03e35 to a74d9d1f4776 (1 revision) (flutter/flutter#127565)
2023-05-25 [email protected] Roll Flutter Engine from fb38bb6b1bc1 to a7f026b03e35 (1 revision) (flutter/flutter#127563)
2023-05-25 [email protected] Roll Flutter Engine from 2be736c390ee to fb38bb6b1bc1 (1 revision) (flutter/flutter#127560)
2023-05-25 [email protected] Remove Tooltip mouse tracker listener & update hovering/MouseRegion logic & animation (flutter/flutter#119199)
2023-05-25 [email protected] Roll Flutter Engine from 37ebad2d5c27 to 2be736c390ee (2 revisions) (flutter/flutter#127554)
2023-05-25 [email protected] Roll Flutter Engine from 62a83490ee60 to 37ebad2d5c27 (1 revision) (flutter/flutter#127551)
2023-05-25 [email protected] Roll Flutter Engine from 1bed04a4375a to 62a83490ee60 (3 revisions) (flutter/flutter#127546)
2023-05-25 [email protected] Roll Flutter Engine from 6a361090a367 to 1bed04a4375a (2 revisions) (flutter/flutter#127544)
2023-05-25 [email protected] Roll Flutter Engine from 9ba461efd3fe to 6a361090a367 (3 revisions) (flutter/flutter#127542)
2023-05-24 [email protected] Revert "Update labeler action wildcards" (flutter/flutter#127541)
2023-05-24 [email protected] [web] ui.platformViewRegistry => ui_web.platformViewRegistry (flutter/flutter#127493)
2023-05-24 [email protected] Roll Flutter Engine from c641f6307f08 to 9ba461efd3fe (6 revisions) (flutter/flutter#127536)
2023-05-24 [email protected] Add missing parameters in `TextFormField` (flutter/flutter#127020)
2023-05-24 [email protected] Update labeler action wildcards (flutter/flutter#127524)
2023-05-24 [email protected] Improve `TextPainter.layout` caching (flutter/flutter#118128)
2023-05-24 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 2713f7303c96cb1e69627957ec16eea0fd7f94a4 to 0776a679364a9a16110aac8d0f40f5e11009e327 (flutter/flutter#127533)
2023-05-24 [email protected] Fix ScrollPosition overscroll precision error (flutter/flutter#127321)
2023-05-24 [email protected] `Slider.onChangeStart` & `Slider.onChangeEnd` are not called on keyboard shortcuts (flutter/flutter#126896)
2023-05-24 [email protected] Manually roll Flutter Engine from 0c41b02cd5a6 to c641f6307f08 (flutter/flutter#127514)
2023-05-24 [email protected] Update CP template to include timeline and changelog (flutter/flutter#127507)
...
@reidbaker reidbaker mentioned this pull request May 26, 2023
Merged
8 tasks
@HansMuller HansMuller mentioned this pull request May 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
07f7ffd Adds TestDisplay API for testing Display features (flutte…
ccdcccf 
…r/flutter#127525)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
07f7ffd Adds TestDisplay API for testing Display features (flutte…
b1caa21 
…r/flutter#127525)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
07f7ffd Adds TestDisplay API for testing Display features (flutte…
6ad15b0 
…r/flutter#127525)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
07f7ffd Adds TestDisplay API for testing Display features (flutte…
35707c4 
…r/flutter#127525)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flutter_test should support testing the new Display API

2 participants

@pdblasi-google @dnfield