Skip to content

Update collection-fors to prefer final (as per updated prefer_final_in_for_each) #127511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
May 26, 2023
Merged

Update collection-fors to prefer final (as per updated prefer_final_in_for_each) #127511

auto-submit merged 4 commits into from
May 26, 2023

Conversation

@pq
Copy link
Contributor

@pq pq commented May 24, 2023 •
edited
Loading

The newly updated lint will soon flag for-each in collections.

See discussion: dart-archive/linter#4383

/cc @goderbauer

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels May 24, 2023
@github-actions github-actions bot removed tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. f: cupertino flutter/packages/flutter/cupertino repository a: text input Entering text in a text field or keyboard related problems labels May 24, 2023
@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels May 24, 2023
@github-actions github-actions bot removed tool Affects the "flutter" command-line tool. See also t: labels. a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. labels May 24, 2023
@pq pq requested a review from gspencergoog May 24, 2023 20:20
@pq pq requested a review from goderbauer May 24, 2023 20:21
@Hixie
Copy link
Contributor

Hixie commented May 24, 2023

test-exempt: lint fix

@pq pq added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels May 24, 2023
@goderbauer
Copy link
Member

goderbauer commented May 25, 2023

The tide has turned a little bit in whether we want to slap final on everything. A lot of people find this too verbose for little benefit. However, I do think that the prefer_final_in_for_each lint should consistently apply to all kind of fors. So, I am in favor of this change. We can have a separate discussion of whether the lint as a whole is too verbose for Flutter's taste and whether we want to disable it as a whole. But the lint itself should be consistent, so LGTM.

goderbauer
goderbauer approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pq pq added the autosubmit Merge PR when tree becomes green via auto submit App label May 25, 2023
@auto-submit auto-submit bot merged commit 5bf6318 into flutter:master May 26, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2023
@engine-flutter-autoroll
5bf6318 Update collection-fors to prefer final (as per updated `prefe…
e03c3ed 
…r_final_in_for_each`) (flutter/flutter#127511)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2023
@engine-flutter-autoroll
5bf6318 Update collection-fors to prefer final (as per updated `prefe…
7bb82cb 
…r_final_in_for_each`) (flutter/flutter#127511)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2023
@engine-flutter-autoroll
5bf6318 Update collection-fors to prefer final (as per updated `prefe…
5f34ce5 
…r_final_in_for_each`) (flutter/flutter#127511)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2023
@engine-flutter-autoroll
5bf6318 Update collection-fors to prefer final (as per updated `prefe…
d4d6021 
…r_final_in_for_each`) (flutter/flutter#127511)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 28, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2023
@engine-flutter-autoroll
5bf6318 Update collection-fors to prefer final (as per updated `prefe…
ddc374c 
…r_final_in_for_each`) (flutter/flutter#127511)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 2, 2023
@engine-flutter-autoroll
Roll Flutter from ee162e4 to 3db9504 (31 revisions) (#4098)
db4954e 
flutter/flutter@ee162e4...3db9504

2023-05-28 [email protected] Roll Flutter Engine from 340936f7c03c to a4d4ad9dae1a (1 revision) (flutter/flutter#127772)
2023-05-28 [email protected] Roll Flutter Engine from 57e491a46e05 to 340936f7c03c (1 revision) (flutter/flutter#127767)
2023-05-28 [email protected] Roll Flutter Engine from a37b1a38d97a to 57e491a46e05 (1 revision) (flutter/flutter#127765)
2023-05-28 [email protected] Roll Flutter Engine from b1698020bd57 to a37b1a38d97a (1 revision) (flutter/flutter#127761)
2023-05-27 [email protected] Roll Flutter Engine from 9e97c7379c7f to b1698020bd57 (1 revision) (flutter/flutter#127758)
2023-05-27 [email protected] Roll Flutter Engine from 0f38a0f0a18a to 9e97c7379c7f (1 revision) (flutter/flutter#127755)
2023-05-27 [email protected] Roll Flutter Engine from 1187168472a7 to 0f38a0f0a18a (1 revision) (flutter/flutter#127752)
2023-05-27 [email protected] Roll Flutter Engine from 3426cb827efb to 1187168472a7 (1 revision) (flutter/flutter#127745)
2023-05-27 [email protected] Roll Flutter Engine from 795db50e7453 to 3426cb827efb (9 revisions) (flutter/flutter#127738)
2023-05-27 [email protected] Updated the `ToggleButtons` API doc to link to `SegmentedButton` (flutter/flutter#127021)
2023-05-26 [email protected] Remove more `test_api/src` imports (flutter/flutter#127716)
2023-05-26 [email protected] Move shared inline widget logic to `RenderInlineWidgetContainerDefaults` (flutter/flutter#127308)
2023-05-26 [email protected] Roll Flutter Engine from 3b5b5fc96b8f to 795db50e7453 (1 revision) (flutter/flutter#127720)
2023-05-26 [email protected] Update collection-fors to prefer final (as per updated `prefer_final_in_for_each`) (flutter/flutter#127511)
2023-05-26 [email protected] Roll Flutter Engine from eed12f36f595 to 3b5b5fc96b8f (1 revision) (flutter/flutter#127713)
2023-05-26 [email protected] Remove references to deprecated `ThemeData.primaryColorBrightness` (flutter/flutter#127238)
2023-05-26 [email protected] TwoDimensional scrolling foundation (flutter/flutter#125437)
2023-05-26 [email protected] Roll Flutter Engine from 858d9753453c to eed12f36f595 (2 revisions) (flutter/flutter#127702)
2023-05-26 [email protected] Remove button announcement for `MenuItemButton` and `SubmenuButton` (flutter/flutter#127620)
2023-05-26 [email protected] Reland "Update labeler action wildcards #127524" (flutter/flutter#127690)
2023-05-26 [email protected] Revert "Log all lines from ios-deploy (#127502)" (flutter/flutter#127684)
2023-05-26 [email protected] Roll Flutter Engine from ec7b0ae3599f to 858d9753453c (2 revisions) (flutter/flutter#127700)
2023-05-26 [email protected] Add M3 date range picker tests and fix header background theme color (flutter/flutter#127662)
2023-05-26 [email protected] Support minifcation for apps that depend on AGP 8 and integration_test (flutter/flutter#127628)
2023-05-26 [email protected] Bump Snippet version (flutter/flutter#127688)
2023-05-26 [email protected] [Linux] Use up_client_get_devices2 when possible (flutter/flutter#127699)
2023-05-26 [email protected] Roll Flutter Engine from 84f2fc16e55d to ec7b0ae3599f (3 revisions) (flutter/flutter#127698)
2023-05-26 [email protected] Fix `TextField` error in production environment because it wrongly uses ancestor render boxes (flutter/flutter#126324)
2023-05-26 [email protected] Interactive viewer doesn't appear to respect the trackpadScrollCausesScale parameter (flutter/flutter#127114)
2023-05-26 [email protected] Remove release timeline (flutter/flutter#127685)
2023-05-26 [email protected] Manual roll Flutter Engine from 8573f3b63a1f to 84f2fc16e55d (7 revisions) (flutter/flutter#127676)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
5bf6318 Update collection-fors to prefer final (as per updated `prefe…
982509b 
…r_final_in_for_each`) (flutter/flutter#127511)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
5bf6318 Update collection-fors to prefer final (as per updated `prefe…
ecf9135 
…r_final_in_for_each`) (flutter/flutter#127511)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
5bf6318 Update collection-fors to prefer final (as per updated `prefe…
6aa2e2d 
…r_final_in_for_each`) (flutter/flutter#127511)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
5bf6318 Update collection-fors to prefer final (as per updated `prefe…
44605c0 
…r_final_in_for_each`) (flutter/flutter#127511)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@gspencergoog gspencergoog Awaiting requested review from gspencergoog

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pq @Hixie @goderbauer