Skip to content

Change useMaterial3 default to true #127501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
HansMuller wants to merge 10 commits into from
Closed

Change useMaterial3 default to true #127501

HansMuller wants to merge 10 commits into from

Conversation

@HansMuller
Copy link
Contributor

@HansMuller HansMuller commented May 24, 2023 •
edited
Loading

Not for review. This is just a smoke test. Many test failures are expected.

Currently all of the tests in packages/flutter/test are expected to pass except for the tests in packages/flutter/test/material.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels May 24, 2023
@flutter-dashboard
Copy link

flutter-dashboard bot commented May 24, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot removed the framework flutter/packages/flutter repository. See also f: labels. label May 24, 2023
@HansMuller HansMuller force-pushed the use_material3_default branch from 9fec848 to e4f8fb3 Compare May 26, 2023 22:49
@github-actions github-actions bot added the a: text input Entering text in a text field or keyboard related problems label May 26, 2023
@HansMuller HansMuller force-pushed the use_material3_default branch from 4b0d640 to be4e41e Compare May 31, 2023 23:19
@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels May 31, 2023
@HansMuller HansMuller force-pushed the use_material3_default branch from be4e41e to 4a19115 Compare June 2, 2023 23:33
@github-actions github-actions bot removed the f: material design flutter/packages/flutter/material repository. label Jun 2, 2023
@HansMuller HansMuller force-pushed the use_material3_default branch from 4a19115 to 6b1f28e Compare June 5, 2023 20:52
@github-actions github-actions bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation labels Jun 5, 2023
@HansMuller HansMuller force-pushed the use_material3_default branch from 6b1f28e to e21ca8f Compare June 5, 2023 23:12
@github-actions github-actions bot added the f: material design flutter/packages/flutter/material repository. label Jun 5, 2023
@HansMuller HansMuller force-pushed the use_material3_default branch from e21ca8f to f7d75e6 Compare June 12, 2023 16:18
@HansMuller HansMuller mentioned this pull request May 18, 2023
Closed
25 tasks
@HansMuller HansMuller changed the title [DRAFT] - Change useMaterial3 default to true Change useMaterial3 default to true Jun 12, 2023
@HansMuller HansMuller force-pushed the use_material3_default branch 3 times, most recently from 11e1430 to af56960 Compare June 13, 2023 22:05
@flutter-dashboard
Copy link

flutter-dashboard bot commented Jun 13, 2023

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #127501 at sha af56960c411ba54949a527272e5beea32f4579ee

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Jun 13, 2023
@QuncCccccc
Copy link
Contributor

QuncCccccc commented Jun 14, 2023

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #127501 at sha af56960

I think I forgot to update golden tests🥲. Creating another PR to test that. Will also take a look at the failed tests in web_canvas_tests_2 and web_canvas_tests_3.

@HansMuller HansMuller force-pushed the use_material3_default branch 2 times, most recently from a4dbb77 to a216dc7 Compare June 14, 2023 23:26
@HansMuller HansMuller force-pushed the use_material3_default branch from a216dc7 to e550566 Compare June 15, 2023 20:23
@HansMuller HansMuller force-pushed the use_material3_default branch 3 times, most recently from a508c98 to 73ae724 Compare June 27, 2023 19:43
@HansMuller HansMuller force-pushed the use_material3_default branch from 73ae724 to 93a9f11 Compare June 27, 2023 22:36
@github-actions github-actions bot removed f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. c: contributor-productivity Team-specific productivity, code health, technical debt. a: text input Entering text in a text field or keyboard related problems a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) framework flutter/packages/flutter repository. See also f: labels. labels Jun 27, 2023
@HansMuller HansMuller mentioned this pull request Jun 27, 2023
Merged
This was referenced Jun 28, 2023
Closed
Merged
@HansMuller HansMuller closed this Jun 28, 2023
@HansMuller HansMuller deleted the use_material3_default branch June 28, 2023 16:47
fluttermirroringbot pushed a commit that referenced this pull request Jun 30, 2023
@bleroux
Update basic_test.dart for M3 compliance (#129714)
3a6d661 
## Description

This PR fixes two test failures in `basic_test.dart` which surfaced when switching to M3 (see #127501)

Those failures are related to M3 typography which sets line height to 1.43.

Forcing line height to 1.0 seems reasonable for these particular tests. With this change these two test are successful for both M2 and M3.

## Related Issue

fixes #129713

## Tests

Updates 2 tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos will affect goldens Changes to golden files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HansMuller @QuncCccccc