Skip to content

When resized network image has error, all future unrelated images using the same url will fail, even if the network becomes OK #127456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 41 commits into from
Aug 21, 2023
Merged

When resized network image has error, all future unrelated images using the same url will fail, even if the network becomes OK #127456

auto-submit merged 41 commits into from
Aug 21, 2023

Conversation

@fzyzcjy
Copy link
Contributor

@fzyzcjy fzyzcjy commented May 24, 2023 •
edited
Loading

Close #127265

The CI fails because of simple analyzer errors. Thus, I would like to hear your opinions first!

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label May 24, 2023
@github-actions github-actions bot removed the framework flutter/packages/flutter repository. See also f: labels. label May 24, 2023
@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label May 24, 2023
@fzyzcjy fzyzcjy mentioned this pull request May 24, 2023
Closed
2 tasks
@github-actions github-actions bot removed the framework flutter/packages/flutter repository. See also f: labels. label May 24, 2023
@fzyzcjy fzyzcjy marked this pull request as ready for review May 24, 2023 01:47
@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label May 24, 2023
@github-actions github-actions bot removed the framework flutter/packages/flutter repository. See also f: labels. label May 24, 2023
@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label May 25, 2023
@HansMuller HansMuller requested a review from dnfield May 26, 2023 17:08
dnfield
dnfield reviewed May 26, 2023
View reviewed changes
dnfield
dnfield suggested changes May 26, 2023
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment in code.

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented May 26, 2023

See comment in code.

I have replied ;)

fzyzcjy added 4 commits May 28, 2023 14:15
@fzyzcjy
Revert "rm log"
0b24e86 
This reverts commit dcea595.
@fzyzcjy
Revert "logs"
b3ce41b 
This reverts commit d6a3cd6.
@fzyzcjy
Revert "try to impl"
263f0c6 
This reverts commit 7387671.
@fzyzcjy
Merge remote-tracking branch 'origin/feat/buggy-network-image' into f…
8660071 
…eat/buggy-network-image

# Conflicts:
#	packages/flutter/lib/src/painting/_network_image_io.dart
#	packages/flutter/lib/src/painting/image_cache.dart
@github-actions github-actions bot removed the framework flutter/packages/flutter repository. See also f: labels. label May 28, 2023
@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Jun 7, 2023 •
edited
Loading

Done (will wait and fix CI, but it works well locally)

EDIT: CI is green now

dnfield
dnfield reviewed Jun 8, 2023
View reviewed changes
@dnfield dnfield requested a review from goderbauer June 8, 2023 04:44
@dnfield
Copy link
Contributor

dnfield commented Jun 8, 2023

This looks better to me, docs too with a nit.

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Jun 17, 2023 •
edited
Loading

It has been a week 👀 Anything I can do?

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Jun 24, 2023

Well, one more week 👀

@fzyzcjy fzyzcjy mentioned this pull request Jul 6, 2023
Merged
8 tasks
goderbauer
goderbauer approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Aug 18, 2023

Everything seems green now :)

image

@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 21, 2023
@auto-submit auto-submit bot merged commit aeddab4 into flutter:master Aug 21, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 22, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 22, 2023
@engine-flutter-autoroll
aeddab4 When resized network image has error, all future unrelated im…
ed40e89 
…ages using the same url will fail, even if the network becomes OK (flutter/flutter#127456)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 22, 2023
@engine-flutter-autoroll
Roll Flutter from 5e6d88d to 54c98d7 (24 revisions) (#4754)
c730a90 
flutter/flutter@5e6d88d...54c98d7

2023-08-22 [email protected] Roll Flutter Engine from 447981acbf36 to f5f099a4a5e3 (1 revision) (flutter/flutter#133035)
2023-08-22 [email protected] Roll Flutter Engine from 5e84d733ef67 to 447981acbf36 (2 revisions) (flutter/flutter#133031)
2023-08-22 [email protected] Roll Flutter Engine from e183e8a94093 to 5e84d733ef67 (1 revision) (flutter/flutter#133030)
2023-08-22 [email protected] Roll Flutter Engine from 454e0e35f8e4 to e183e8a94093 (2 revisions) (flutter/flutter#133026)
2023-08-22 [email protected] Roll Flutter Engine from 857840db5574 to 454e0e35f8e4 (1 revision) (flutter/flutter#133020)
2023-08-22 [email protected] Roll Flutter Engine from 1ab054967c1d to 857840db5574 (2 revisions) (flutter/flutter#133018)
2023-08-22 [email protected] Roll Flutter Engine from 5a292e42a593 to 1ab054967c1d (1 revision) (flutter/flutter#133014)
2023-08-22 [email protected] Fix visual overflow for SliverMainAxisGroup (flutter/flutter#132989)
2023-08-22 [email protected] Roll Flutter Engine from e5929d83e9b7 to 5a292e42a593 (3 revisions) (flutter/flutter#133010)
2023-08-22 [email protected] Always require `--local-engine-host` if `--local-engine` (flutter/flutter#133003)
2023-08-22 [email protected] Roll Flutter Engine from 55b84268f2a6 to e5929d83e9b7 (3 revisions) (flutter/flutter#133005)
2023-08-21 [email protected] Roll Flutter Engine from e5f690b829e5 to 55b84268f2a6 (1 revision) (flutter/flutter#133000)
2023-08-21 [email protected] Add deleteBackwardByDecomposingPreviousCharacter mapping for tests (flutter/flutter#132919)
2023-08-21 [email protected] Roll Flutter Engine from fc75109c3a1e to e5f690b829e5 (1 revision) (flutter/flutter#132996)
2023-08-21 [email protected] Roll Flutter Engine from 2388b9db2be7 to fc75109c3a1e (3 revisions) (flutter/flutter#132992)
2023-08-21 [email protected] Roll Flutter Engine from 210f5a8aa245 to 2388b9db2be7 (6 revisions) (flutter/flutter#132986)
2023-08-21 [email protected]  Update `ExpansionPanel` example for the updated `expansionCallback` callback (flutter/flutter#132837)
2023-08-21 [email protected] Change gradle lockfile generation script to use --config-only flag (flutter/flutter#132967)
2023-08-21 [email protected] Roll Flutter Engine from 0290d0bd79ee to 210f5a8aa245 (1 revision) (flutter/flutter#132973)
2023-08-21 [email protected] Docs on iOS's directional quote characters (flutter/flutter#132869)
2023-08-21 [email protected] Bump memory usage for flutter gallery (flutter/flutter#132968)
2023-08-21 [email protected] When resized network image has error, all future unrelated images using the same url will fail, even if the network becomes OK (flutter/flutter#127456)
2023-08-21 [email protected] Roll Flutter Engine from a9b00783bc7c to 0290d0bd79ee (1 revision) (flutter/flutter#132962)
2023-08-21 [email protected] Roll Packages from 4c16f3e to e26f3b9 (5 revisions) (flutter/flutter#132960)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
XilaiZhang added a commit that referenced this pull request Aug 24, 2023
@XilaiZhang
Revert "When resized network image has error, all future unrelated im…
86367ec 
…ages using the same url will fail, even if the network becomes OK (#127456)"

This reverts commit aeddab4.
@XilaiZhang XilaiZhang mentioned this pull request Aug 24, 2023
Closed
@HansMuller HansMuller mentioned this pull request Aug 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
aeddab4 When resized network image has error, all future unrelated im…
70f67a3 
…ages using the same url will fail, even if the network becomes OK (flutter/flutter#127456)
@CoderBuck CoderBuck mentioned this pull request May 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

+1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(Will PR) When resized network image has error, all future unrelated images using the same url will fail, even if the network becomes OK

3 participants

@fzyzcjy @dnfield @goderbauer