Skip to content

Conversation

@christopherfujino
Copy link
Contributor

Fixes #126705

Follow up fix after #126875 did NOT work.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 23, 2023
@christopherfujino
Copy link
Contributor Author

I think I need to also delete this one other place for the add to app workflow...

@christopherfujino
Copy link
Contributor Author

nvm, I can verify that flutter build macos-framework DOES hit this codepath and generates a framework dir without eneitlements files.

@christopherfujino
Copy link
Contributor Author

FYI @borjandev

Copy link
Contributor

@vashworth vashworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2023
@auto-submit auto-submit bot merged commit 11cb291 into flutter:master May 23, 2023
@christopherfujino christopherfujino deleted the delete-entitlements-files-2 branch May 23, 2023 19:32
christopherfujino added a commit to chris-forks/flutter that referenced this pull request May 23, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 24, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 24, 2023
flutter/flutter@f86c529...216605b

2023-05-24 [email protected] Roll Flutter Engine from aba9dc4640c2 to eebcf36cd38f (3 revisions) (flutter/flutter#127458)
2023-05-24 [email protected] Roll Flutter Engine from 76afb431a740 to aba9dc4640c2 (1 revision) (flutter/flutter#127453)
2023-05-24 [email protected] Roll Flutter Engine from fc6df9512aa2 to 76afb431a740 (3 revisions) (flutter/flutter#127445)
2023-05-23 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 6b107e7a7ee5e054e0bcce60de5181d21e2f00fb to 2713f7303c96cb1e69627957ec16eea0fd7f94a4 (flutter/flutter#127438)
2023-05-23 [email protected] Roll Flutter Engine from 3535e0d301dd to fc6df9512aa2 (1 revision) (flutter/flutter#127440)
2023-05-23 [email protected] Migrates android semanitcs integration to integration test (flutter/flutter#127128)
2023-05-23 [email protected] Roll Flutter Engine from 23b04314d5d2 to 3535e0d301dd (3 revisions) (flutter/flutter#127428)
2023-05-23 [email protected] Roll Flutter Engine from ccf50f344d5d to 23b04314d5d2 (2 revisions) (flutter/flutter#127421)
2023-05-23 [email protected] Give channel descriptions in `flutter channel`, use branch instead of upstream for channel name (flutter/flutter#126936)
2023-05-23 [email protected] Avoid catching errors in TextPainter tests (flutter/flutter#127307)
2023-05-23 [email protected] [flutter_tools] delete entitlements files after copying to macos build dir (flutter/flutter#127417)
2023-05-23 [email protected] Roll Flutter Engine from a6e37bde65fd to ccf50f344d5d (7 revisions) (flutter/flutter#127416)
2023-05-23 [email protected] modal bottom sheet barrier label (flutter/flutter#126431)
2023-05-23 [email protected] Fix the breaking of multi-code-unit characters in obscure mode (flutter/flutter#123366)
2023-05-23 [email protected] Roll Flutter Engine from 168b0bf3f70d to a6e37bde65fd (1 revision) (flutter/flutter#127397)
2023-05-23 [email protected] Revert "Log all output of ios-deploy" (flutter/flutter#127405)
2023-05-23 [email protected] Roll Packages from 83959fb to d449a17 (6 revisions) (flutter/flutter#127394)
2023-05-23 [email protected] Log all output of ios-deploy (flutter/flutter#127222)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MacOS builds getting rejected by Apple

3 participants