Skip to content

Revert "Log all output of ios-deploy" #127405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
May 23, 2023
Merged

Revert "Log all output of ios-deploy" #127405

auto-submit merged 1 commit into from
May 23, 2023

Conversation

@vashworth
Copy link
Contributor

@vashworth vashworth commented May 23, 2023

Reverts #127222

@vashworth vashworth added the revert Autorevert PR (with "Reason for revert:" comment) label May 23, 2023
@flutter-dashboard flutter-dashboard bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels May 23, 2023
@auto-submit auto-submit bot merged commit d452ce9 into master May 23, 2023
@auto-submit auto-submit bot deleted the revert-127222-dart_vm_timeout_debug_v2 branch May 23, 2023 16:37
@vashworth vashworth mentioned this pull request May 23, 2023
Closed
8 tasks
@christopherfujino
Copy link
Contributor

christopherfujino commented May 23, 2023

For posterity, the original PR broke Mac_ios microbenchmarks_ios: https://ci.chromium.org/p/flutter/builders/prod/Mac_ios%20microbenchmarks_ios/6127

Task result:
{
  "success": false,
  "reason": "Task failed: Additional JSON was received after results has already been processed. This suggests the `flutter run` process may have lived past the end of our test and collected additional output from the next test.\n\nThe JSON below contains all collected output, including both from the original test and what followed.\n\n {\"all_elements_iteration\":204.1935}\n {\"all_elements_iteration\":204.1935}\n"
}

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 24, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 24, 2023
@engine-flutter-autoroll
d452ce9 Revert "Log all output of ios-deploy" (flutter/flutter#127405)
235d0c2
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 24, 2023
@engine-flutter-autoroll
Roll Flutter from f86c529 to 216605b (18 revisions) (#4071)
995bfc5 
flutter/flutter@f86c529...216605b

2023-05-24 [email protected] Roll Flutter Engine from aba9dc4640c2 to eebcf36cd38f (3 revisions) (flutter/flutter#127458)
2023-05-24 [email protected] Roll Flutter Engine from 76afb431a740 to aba9dc4640c2 (1 revision) (flutter/flutter#127453)
2023-05-24 [email protected] Roll Flutter Engine from fc6df9512aa2 to 76afb431a740 (3 revisions) (flutter/flutter#127445)
2023-05-23 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 6b107e7a7ee5e054e0bcce60de5181d21e2f00fb to 2713f7303c96cb1e69627957ec16eea0fd7f94a4 (flutter/flutter#127438)
2023-05-23 [email protected] Roll Flutter Engine from 3535e0d301dd to fc6df9512aa2 (1 revision) (flutter/flutter#127440)
2023-05-23 [email protected] Migrates android semanitcs integration to integration test (flutter/flutter#127128)
2023-05-23 [email protected] Roll Flutter Engine from 23b04314d5d2 to 3535e0d301dd (3 revisions) (flutter/flutter#127428)
2023-05-23 [email protected] Roll Flutter Engine from ccf50f344d5d to 23b04314d5d2 (2 revisions) (flutter/flutter#127421)
2023-05-23 [email protected] Give channel descriptions in `flutter channel`, use branch instead of upstream for channel name (flutter/flutter#126936)
2023-05-23 [email protected] Avoid catching errors in TextPainter tests (flutter/flutter#127307)
2023-05-23 [email protected] [flutter_tools] delete entitlements files after copying to macos build dir (flutter/flutter#127417)
2023-05-23 [email protected] Roll Flutter Engine from a6e37bde65fd to ccf50f344d5d (7 revisions) (flutter/flutter#127416)
2023-05-23 [email protected] modal bottom sheet barrier label (flutter/flutter#126431)
2023-05-23 [email protected] Fix the breaking of multi-code-unit characters in obscure mode (flutter/flutter#123366)
2023-05-23 [email protected] Roll Flutter Engine from 168b0bf3f70d to a6e37bde65fd (1 revision) (flutter/flutter#127397)
2023-05-23 [email protected] Revert "Log all output of ios-deploy" (flutter/flutter#127405)
2023-05-23 [email protected] Roll Packages from 83959fb to d449a17 (6 revisions) (flutter/flutter#127394)
2023-05-23 [email protected] Log all output of ios-deploy (flutter/flutter#127222)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@vashworth vashworth mentioned this pull request May 24, 2023
Merged
8 tasks
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@vashworth
Revert "Log all output of ios-deploy" (flutter#127405)
6b0f0c4 
Reverts flutter#127222
auto-submit bot pushed a commit that referenced this pull request May 24, 2023
@vashworth
Log all lines from ios-deploy (#127502)
a19b343 
Reland #127222 that was reverted in #127405.

Fixed `Mac_ios microbenchmarks_ios` test failure by not echoing logs twice.
This was referenced May 25, 2023
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
d452ce9 Revert "Log all output of ios-deploy" (flutter/flutter#127405)
be931b8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
d452ce9 Revert "Log all output of ios-deploy" (flutter/flutter#127405)
215e734
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
d452ce9 Revert "Log all output of ios-deploy" (flutter/flutter#127405)
3dc797f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
d452ce9 Revert "Log all output of ios-deploy" (flutter/flutter#127405)
048d5f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

Assignees

No one assigned

Labels

platform-ios iOS applications specifically revert Autorevert PR (with "Reason for revert:" comment) tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vashworth @christopherfujino @fluttergithubbot