Skip to content

test owners: cyanglaz -> vashworth #127391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
May 24, 2023
Merged

test owners: cyanglaz -> vashworth #127391

auto-submit merged 1 commit into from
May 24, 2023

Conversation

@cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented May 23, 2023

Changes the test owners to @vashworth while I'm OOO.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cyanglaz cyanglaz requested a review from vashworth May 23, 2023 14:01
vashworth
vashworth approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@vashworth vashworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label May 24, 2023
@auto-submit auto-submit bot merged commit 9232834 into flutter:master May 24, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023
@engine-flutter-autoroll
9232834 test owners: cyanglaz -> vashworth (flutter/flutter#127391)
70400f8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023
@engine-flutter-autoroll
9232834 test owners: cyanglaz -> vashworth (flutter/flutter#127391)
bfe2dae
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023
@engine-flutter-autoroll
9232834 test owners: cyanglaz -> vashworth (flutter/flutter#127391)
543bcd2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023
@engine-flutter-autoroll
9232834 test owners: cyanglaz -> vashworth (flutter/flutter#127391)
1027898
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023
@engine-flutter-autoroll
9232834 test owners: cyanglaz -> vashworth (flutter/flutter#127391)
7100336
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023
@engine-flutter-autoroll
9232834 test owners: cyanglaz -> vashworth (flutter/flutter#127391)
2fdc1e4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023
@engine-flutter-autoroll
9232834 test owners: cyanglaz -> vashworth (flutter/flutter#127391)
e34bc84
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023
@engine-flutter-autoroll
9232834 test owners: cyanglaz -> vashworth (flutter/flutter#127391)
c619b44
@reidbaker reidbaker mentioned this pull request May 25, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 26, 2023
@engine-flutter-autoroll
9232834 test owners: cyanglaz -> vashworth (flutter/flutter#127391)
7fa195d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 26, 2023
@engine-flutter-autoroll
9232834 test owners: cyanglaz -> vashworth (flutter/flutter#127391)
9a6af6a
@reidbaker reidbaker mentioned this pull request May 26, 2023
Merged
8 tasks
@cyanglaz cyanglaz deleted the temp_codewoener_change branch June 7, 2023 20:33
cyanglaz pushed a commit that referenced this pull request Jun 7, 2023
Revert "test owners: cyanglaz -> vashworth (#127391)"
e72bf3c 
This reverts commit 9232834.
@cyanglaz cyanglaz mentioned this pull request Jun 7, 2023
Merged
auto-submit bot pushed a commit that referenced this pull request Jun 9, 2023
Revert "test owners: cyanglaz -> vashworth" (#128462)
e25eabd 
Reverts #127391

I'm back from OOO so change the test owners back.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
9232834 test owners: cyanglaz -> vashworth (flutter/flutter#127391)
e0158d9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
9232834 test owners: cyanglaz -> vashworth (flutter/flutter#127391)
185143a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
9232834 test owners: cyanglaz -> vashworth (flutter/flutter#127391)
61a72ae
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
9232834 test owners: cyanglaz -> vashworth (flutter/flutter#127391)
2d8ad41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vashworth vashworth vashworth approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cyanglaz @vashworth