Fix bug in Autocomplete example #127219
Merged
Fix bug in Autocomplete example #127219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
d: api docs
8 tasks
QuncCccccc
reviewed
May 19, 2023
| mainAxisAlignment: MainAxisAlignment.center, | ||
| children: <Widget>[ | ||
| Text('Type below to autocomplete the following possible results: ${_FakeAPI._kOptions}.'), | ||
| SizedBox(height: 32.0), |
Contributor
There was a problem hiding this comment.
Seems the linux_analyze complains a missing const here:)
Contributor
Author
There was a problem hiding this comment.
Whoops, thanks for pointing it out.
justinmc
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 22, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 22, 2023
flutter/flutter@ab57304...3437189 2023-05-22 [email protected] Roll Flutter Engine from f0f3fe729a91 to e04c14786d5a (10 revisions) (flutter/flutter#127325) 2023-05-22 [email protected] Fix bug in Autocomplete example (flutter/flutter#127219) 2023-05-22 [email protected] Roll Packages from 1e214d7 to 83959fb (9 revisions) (flutter/flutter#127322) 2023-05-22 [email protected] Roll Flutter Engine from aac09195688d to f0f3fe729a91 (16 revisions) (flutter/flutter#127292) 2023-05-22 [email protected] Add myself to AUTHORS (flutter/flutter#127298) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
This example was incorrectly throwing away results from a query when multiple queries were pending at once. Thanks to @sun-jiao in flutter#127019 (comment) for pointing this out. I also added a quick `Text` widget explaining what to do to use the examples. Since there are only three small possible `options`, it's easy to type into the field and not get any results and wonder what's wrong.
This was referenced May 25, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example was incorrectly throwing away results from a query when multiple queries were pending at once. Thanks to @sun-jiao in #127019 (comment) for pointing this out.
I also added a quick
Textwidget explaining what to do to use the examples. Since there are only three small possibleoptions, it's easy to type into the field and not get any results and wonder what's wrong.