Skip to content

Conversation

@zanderso
Copy link
Member

goldctl hasn't been updated in about a year, and an update may be needed to reland #127110.

@zanderso
Copy link
Member Author

@keyonghan Does this have to be updated anywhere outside of the ci.yaml?

@Piinks
Copy link
Contributor

Piinks commented May 19, 2023

Oh wow, it was updated recently I thought in the luci recipes? I was unaware of it here. Looking for the cl we recently updated it in...

@mdebbar
Copy link
Contributor

mdebbar commented May 19, 2023

Oh wow, it was updated recently I thought in the luci recipes? I was unaware of it here. Looking for the cl we recently updated it in...

https://flutter-review.git.corp.google.com/c/recipes/+/38126

@zanderso
Copy link
Member Author

See the comment from @godofredoc in that CL: https://flutter-review.git.corp.google.com/c/recipes/+/38126/comment/53a94ea2_d3e1ba9d/

The preferred way of updating dependency versions is through .ci.yaml which will test the change in presubmit https://github.com/flutter/engine/blob/main/.ci.yaml#L440

@Piinks
Copy link
Contributor

Piinks commented May 19, 2023

Good to know! Thanks @zanderso!

Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label May 19, 2023
@keyonghan
Copy link
Contributor

@keyonghan Does this have to be updated anywhere outside of the ci.yaml?

This should be enough.

Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kjlubick kjlubick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@auto-submit auto-submit bot merged commit 31a16f3 into flutter:master May 19, 2023
auto-submit bot pushed a commit to flutter/engine that referenced this pull request May 19, 2023
@zanderso zanderso deleted the roll-goldctl branch May 19, 2023 19:25
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 22, 2023
flutter/flutter@077d644...ab57304

2023-05-20 [email protected] Roll Flutter Engine from 482c99af9c69 to aac09195688d (1 revision) (flutter/flutter#127241)
2023-05-20 [email protected] Reland "[tool] Move Java functions to their own file" (flutter/flutter#126577)
2023-05-20 [email protected] Roll Flutter Engine from f0c02aee69db to 482c99af9c69 (1 revision) (flutter/flutter#127240)
2023-05-19 [email protected] Do not animate `TabBarView` if controller is invalid (flutter/flutter#123442)
2023-05-19 [email protected] Run Mac intel only targets on both intel and arm (flutter/flutter#127230)
2023-05-19 [email protected] [Windows] Ensure window is shown (flutter/flutter#127046)
2023-05-19 [email protected] Roll Flutter Engine from 3267fa29491a to f0c02aee69db (4 revisions) (flutter/flutter#127233)
2023-05-19 [email protected] Roll Flutter Engine from 2b14f8a1f21c to 3267fa29491a (4 revisions) (flutter/flutter#127224)
2023-05-19 [email protected] fixes to anticipate next Dart linter release (flutter/flutter#127211)
2023-05-19 [email protected] Remove deprecated OverscrollIndicatorNotification.disallowGlow (flutter/flutter#127050)
2023-05-19 [email protected] Roll Flutter Engine from f471b37a2146 to 2b14f8a1f21c (1 revision) (flutter/flutter#127221)
2023-05-19 [email protected] [flutter_tools] only try to take a screenshot from flutter drive if the --screenshot flag is passed (flutter/flutter#127150)
2023-05-19 [email protected] Roll goldctl to f808dcff91b221ae313e540c09d79696cd08b8de (flutter/flutter#127218)
2023-05-19 [email protected] Roll Packages from b31a128 to 1e214d7 (3 revisions) (flutter/flutter#127217)
2023-05-19 [email protected] Roll Flutter Engine from a0ea4d2d9ea5 to f471b37a2146 (1 revision) (flutter/flutter#127212)
2023-05-19 [email protected] Revert "Migrate benchmarks to package:web" (flutter/flutter#127207)
2023-05-19 [email protected] [tool] delete xcresult bundle file before each xcode retry. (flutter/flutter#127144)
2023-05-19 [email protected] [iOS] Dispose of log readers and port forwarders if launch fails (flutter/flutter#127140)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
)

goldctl hasn't been updated in about a year, and an update may be needed to reland flutter#127110.
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
flutter/flutter@077d644...ab57304

2023-05-20 [email protected] Roll Flutter Engine from 482c99af9c69 to aac09195688d (1 revision) (flutter/flutter#127241)
2023-05-20 [email protected] Reland "[tool] Move Java functions to their own file" (flutter/flutter#126577)
2023-05-20 [email protected] Roll Flutter Engine from f0c02aee69db to 482c99af9c69 (1 revision) (flutter/flutter#127240)
2023-05-19 [email protected] Do not animate `TabBarView` if controller is invalid (flutter/flutter#123442)
2023-05-19 [email protected] Run Mac intel only targets on both intel and arm (flutter/flutter#127230)
2023-05-19 [email protected] [Windows] Ensure window is shown (flutter/flutter#127046)
2023-05-19 [email protected] Roll Flutter Engine from 3267fa29491a to f0c02aee69db (4 revisions) (flutter/flutter#127233)
2023-05-19 [email protected] Roll Flutter Engine from 2b14f8a1f21c to 3267fa29491a (4 revisions) (flutter/flutter#127224)
2023-05-19 [email protected] fixes to anticipate next Dart linter release (flutter/flutter#127211)
2023-05-19 [email protected] Remove deprecated OverscrollIndicatorNotification.disallowGlow (flutter/flutter#127050)
2023-05-19 [email protected] Roll Flutter Engine from f471b37a2146 to 2b14f8a1f21c (1 revision) (flutter/flutter#127221)
2023-05-19 [email protected] [flutter_tools] only try to take a screenshot from flutter drive if the --screenshot flag is passed (flutter/flutter#127150)
2023-05-19 [email protected] Roll goldctl to f808dcff91b221ae313e540c09d79696cd08b8de (flutter/flutter#127218)
2023-05-19 [email protected] Roll Packages from b31a128 to 1e214d7 (3 revisions) (flutter/flutter#127217)
2023-05-19 [email protected] Roll Flutter Engine from a0ea4d2d9ea5 to f471b37a2146 (1 revision) (flutter/flutter#127212)
2023-05-19 [email protected] Revert "Migrate benchmarks to package:web" (flutter/flutter#127207)
2023-05-19 [email protected] [tool] delete xcresult bundle file before each xcode retry. (flutter/flutter#127144)
2023-05-19 [email protected] [iOS] Dispose of log readers and port forwarders if launch fails (flutter/flutter#127140)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants