Remove deprecated primaryVariant and secondaryVariant from ColorScheme
#127124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
QuncCccccc
force-pushed
the
remove_deprecated_apis
branch
from
c3252a6 to
4f3d2c6
Compare
Piinks
added
c: tech-debt
Piinks
approved these changes
May 18, 2023
Contributor
Author
|
I also created a CL cl/533189807 for this PR change. They should be merged together. |
QuncCccccc
force-pushed
the
remove_deprecated_apis
branch
from
4f3d2c6 to
1672732
Compare
QuncCccccc
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 19, 2023
…m `ColorScheme` (flutter/flutter#127124)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 19, 2023
…m `ColorScheme` (flutter/flutter#127124)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 19, 2023
…m `ColorScheme` (flutter/flutter#127124)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 19, 2023
flutter/flutter@5ae6438...077d644 2023-05-19 [email protected] Roll Flutter Engine from 2e6b1e6c3458 to a0ea4d2d9ea5 (1 revision) (flutter/flutter#127203) 2023-05-19 [email protected] Roll Flutter Engine from e9178e115f14 to 2e6b1e6c3458 (1 revision) (flutter/flutter#127196) 2023-05-19 [email protected] fix(flutter_tools): `findBundleFile` w/multiple flavor dimensions (flutter/flutter#127133) 2023-05-19 [email protected] Roll Flutter Engine from 2e8875870f52 to e9178e115f14 (1 revision) (flutter/flutter#127188) 2023-05-19 [email protected] Roll Flutter Engine from c7a209cc40c1 to 2e8875870f52 (1 revision) (flutter/flutter#127185) 2023-05-19 [email protected] Roll Flutter Engine from 5a57ff52f0f7 to c7a209cc40c1 (2 revisions) (flutter/flutter#127175) 2023-05-19 [email protected] Roll Flutter Engine from bfbd2e1dafb0 to 5a57ff52f0f7 (1 revision) (flutter/flutter#127172) 2023-05-19 [email protected] Roll Flutter Engine from e64084596182 to bfbd2e1dafb0 (2 revisions) (flutter/flutter#127167) 2023-05-19 [email protected] Roll Flutter Engine from 6bc60c8a9877 to e64084596182 (2 revisions) (flutter/flutter#127163) 2023-05-19 [email protected] Roll Flutter Engine from bca11a423f9c to 6bc60c8a9877 (1 revision) (flutter/flutter#127162) 2023-05-19 [email protected] Roll Flutter Engine from 9039c2dfb74c to bca11a423f9c (2 revisions) (flutter/flutter#127156) 2023-05-19 [email protected] Roll Flutter Engine from 3c23ddae1d2a to 9039c2dfb74c (2 revisions) (flutter/flutter#127154) 2023-05-19 [email protected] Properly cleans up routes (flutter/flutter#126453) 2023-05-19 [email protected] Remove deprecated `primaryVariant` and `secondaryVariant` from `ColorScheme` (flutter/flutter#127124) 2023-05-19 [email protected] Roll Flutter Engine from 17227c16ca58 to 3c23ddae1d2a (2 revisions) (flutter/flutter#127147) 2023-05-18 [email protected] Update `useMaterial3` api doc (flutter/flutter#127142) 2023-05-18 [email protected] Roll Flutter Engine from c7c679d6d411 to 17227c16ca58 (1 revision) (flutter/flutter#127143) 2023-05-18 [email protected] Roll Flutter Engine from 2c77c8011d45 to c7c679d6d411 (1 revision) (flutter/flutter#127139) 2023-05-18 [email protected] Roll Flutter Engine from 5fb3179a19c3 to 2c77c8011d45 (2 revisions) (flutter/flutter#127131) 2023-05-18 [email protected] Migrate benchmarks to package:web (flutter/flutter#126848) 2023-05-18 [email protected] Roll Flutter Engine from 237c60185ace to 5fb3179a19c3 (3 revisions) (flutter/flutter#127126) 2023-05-18 [email protected] Fixing richMessage gesture recognizer in tooltip widget (flutter/flutter#126207) 2023-05-18 [email protected] Roll Flutter Engine from 843ce0bba356 to 237c60185ace (2 revisions) (flutter/flutter#127122) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…Scheme` (flutter#127124) This PR is to remove deprecated `primaryVariant` and `secondaryVariant` from framework. These two apis are made obsolete in flutter#93427 Part of flutter#127042
This was referenced May 25, 2023
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
flutter/flutter@5ae6438...077d644 2023-05-19 [email protected] Roll Flutter Engine from 2e6b1e6c3458 to a0ea4d2d9ea5 (1 revision) (flutter/flutter#127203) 2023-05-19 [email protected] Roll Flutter Engine from e9178e115f14 to 2e6b1e6c3458 (1 revision) (flutter/flutter#127196) 2023-05-19 [email protected] fix(flutter_tools): `findBundleFile` w/multiple flavor dimensions (flutter/flutter#127133) 2023-05-19 [email protected] Roll Flutter Engine from 2e8875870f52 to e9178e115f14 (1 revision) (flutter/flutter#127188) 2023-05-19 [email protected] Roll Flutter Engine from c7a209cc40c1 to 2e8875870f52 (1 revision) (flutter/flutter#127185) 2023-05-19 [email protected] Roll Flutter Engine from 5a57ff52f0f7 to c7a209cc40c1 (2 revisions) (flutter/flutter#127175) 2023-05-19 [email protected] Roll Flutter Engine from bfbd2e1dafb0 to 5a57ff52f0f7 (1 revision) (flutter/flutter#127172) 2023-05-19 [email protected] Roll Flutter Engine from e64084596182 to bfbd2e1dafb0 (2 revisions) (flutter/flutter#127167) 2023-05-19 [email protected] Roll Flutter Engine from 6bc60c8a9877 to e64084596182 (2 revisions) (flutter/flutter#127163) 2023-05-19 [email protected] Roll Flutter Engine from bca11a423f9c to 6bc60c8a9877 (1 revision) (flutter/flutter#127162) 2023-05-19 [email protected] Roll Flutter Engine from 9039c2dfb74c to bca11a423f9c (2 revisions) (flutter/flutter#127156) 2023-05-19 [email protected] Roll Flutter Engine from 3c23ddae1d2a to 9039c2dfb74c (2 revisions) (flutter/flutter#127154) 2023-05-19 [email protected] Properly cleans up routes (flutter/flutter#126453) 2023-05-19 [email protected] Remove deprecated `primaryVariant` and `secondaryVariant` from `ColorScheme` (flutter/flutter#127124) 2023-05-19 [email protected] Roll Flutter Engine from 17227c16ca58 to 3c23ddae1d2a (2 revisions) (flutter/flutter#127147) 2023-05-18 [email protected] Update `useMaterial3` api doc (flutter/flutter#127142) 2023-05-18 [email protected] Roll Flutter Engine from c7c679d6d411 to 17227c16ca58 (1 revision) (flutter/flutter#127143) 2023-05-18 [email protected] Roll Flutter Engine from 2c77c8011d45 to c7c679d6d411 (1 revision) (flutter/flutter#127139) 2023-05-18 [email protected] Roll Flutter Engine from 5fb3179a19c3 to 2c77c8011d45 (2 revisions) (flutter/flutter#127131) 2023-05-18 [email protected] Migrate benchmarks to package:web (flutter/flutter#126848) 2023-05-18 [email protected] Roll Flutter Engine from 237c60185ace to 5fb3179a19c3 (3 revisions) (flutter/flutter#127126) 2023-05-18 [email protected] Fixing richMessage gesture recognizer in tooltip widget (flutter/flutter#126207) 2023-05-18 [email protected] Roll Flutter Engine from 843ce0bba356 to 237c60185ace (2 revisions) (flutter/flutter#127122) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
…m `ColorScheme` (flutter/flutter#127124)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
…m `ColorScheme` (flutter/flutter#127124)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
…m `ColorScheme` (flutter/flutter#127124)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
…m `ColorScheme` (flutter/flutter#127124)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to remove deprecated
primaryVariantandsecondaryVariantfrom framework. These two apis are made obsolete in #93427Part of #127042
Pre-launch Checklist
///).