Skip to content

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented May 17, 2023

No description provided.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 17, 2023
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@timsneath timsneath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to vet the language a little before we merge... I like the idea though. This somehow feels a bit too strong -- do we really want to encourage users to migrate from stable to beta?

@Hixie
Copy link
Contributor Author

Hixie commented May 18, 2023

I thought this text was relatively neutral (just informing them that it exists and that they might want to use it), but I don't feel strongly about exactly what we say. What did you have in mind?

@timsneath
Copy link
Contributor

I can see this being too successful and converting 80% of stable users to the beta channel, because it might be perceived as a recommendation. (Or, tongue in cheek: "Real experienced developers use the beta channel"!)

I wonder about instead using a message on the master/main channel that says something like, "This channel is designed for those contributing code to the Flutter project. Alternatively, you may want to consider the beta channel, which is both regularly updated and sufficiently tested for production usage."?

@Hixie
Copy link
Contributor Author

Hixie commented May 18, 2023

I mean, if it's "too successful" we can always just remove the message! Since we have no particular targets I'm not especially concerned.

In #126936 I'm adding channel descriptions for flutter channel which should push people away from master/main.

I'm not sure exactly when you're suggesting showing the message you suggest. Can you elaborate?

@timsneath
Copy link
Contributor

I'm suggesting a commit very like the one that you're proposing here, but targeting master channel users when they run flutter upgrade, instead of stable users.

Our recent data showed that master channel usage has grown from ~1% to ~4%, whereas beta channel usage has remained flat at ~1%. If half of those master channel users converted to beta, we'd already be in a better place.

@Hixie
Copy link
Contributor Author

Hixie commented May 18, 2023

Seems reasonable, let me whip up a new PR.

@Hixie
Copy link
Contributor Author

Hixie commented May 18, 2023

Submitted a version of this for upgrading on "master" as #127146

@timsneath
Copy link
Contributor

I'd suggest we don't merge this one for now, and see how the other PR works out first. If we keep this, I'd probably simplify the text to something like, "For information on other Flutter release channels, visit foo.bar"

@Hixie
Copy link
Contributor Author

Hixie commented May 22, 2023

Roger.

@Hixie Hixie closed this May 22, 2023
timsneath pushed a commit that referenced this pull request May 22, 2023
…7146)

Similar to #126972 but for master
upgrades.

Co-authored-by: Tim Sneath <[email protected]>
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants