Remove target Staging_build_linux framework_tests_misc #126959
Conversation
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Thanks for the contribution! This looks ok to me. I will leave final approval for @yusuf-goog or @godofredoc who have more experience with our ci system. One policy I am not sure of is if we delete the ci then delete the code or do both in the same PR. |
goderbauer
added
c: contributor-productivity
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
github-actions
bot
removed
the
c: contributor-productivity
We should only delete the target from CI, whereas the code (test) is still being executed by other target, like |
reidbaker
added
the
autosubmit
|
FYI I clicked "Update branch" as it seems like this PR got stuck due to being several weeks old |
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/flutter, pr: 126959, due to - The status or check suite Linux web_canvaskit_tests_5 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
keyonghan
added
the
autosubmit
flutter/flutter@c00d241...2ba9f7b 2023-08-04 [email protected] Roll Flutter Engine from d15a02a8191c to badca1f7f8c9 (1 revision) (flutter/flutter#131928) 2023-08-04 [email protected] Upgrade packages. (flutter/flutter#131927) 2023-08-04 [email protected] Roll Flutter Engine from 0725a6f519d0 to d15a02a8191c (2 revisions) (flutter/flutter#131924) 2023-08-04 [email protected] Roll Flutter Engine from c912e3417e68 to 0725a6f519d0 (2 revisions) (flutter/flutter#131917) 2023-08-04 [email protected] Roll Flutter Engine from 03137a3b9b81 to c912e3417e68 (2 revisions) (flutter/flutter#131913) 2023-08-04 [email protected] Roll Flutter Engine from de0ec1c971ab to 03137a3b9b81 (1 revision) (flutter/flutter#131912) 2023-08-04 [email protected] Roll Flutter Engine from e3f75650ac5f to de0ec1c971ab (2 revisions) (flutter/flutter#131910) 2023-08-04 [email protected] make `--dart-define` override redundant values in `--dart-define-from-file` (flutter/flutter#131088) 2023-08-04 [email protected] Roll Flutter Engine from ca8d852eddfc to e3f75650ac5f (1 revision) (flutter/flutter#131907) 2023-08-04 [email protected] Roll Flutter Engine from 098ec489585e to ca8d852eddfc (2 revisions) (flutter/flutter#131905) 2023-08-04 [email protected] Roll Flutter Engine from 4c62dd81d136 to 098ec489585e (2 revisions) (flutter/flutter#131903) 2023-08-04 [email protected] Roll Flutter Engine from 0c1de9b8afba to 4c62dd81d136 (4 revisions) (flutter/flutter#131902) 2023-08-03 [email protected] Roll Flutter Engine from b08e1410a06a to 0c1de9b8afba (9 revisions) (flutter/flutter#131897) 2023-08-03 [email protected] Fix TimePicker token issue link (flutter/flutter#131863) 2023-08-03 [email protected] [Impeller] Add animated_blur_backdrop_filter_perf execution on samsung vulkan and opengles (flutter/flutter#131864) 2023-08-03 [email protected] Revert "Manual roll Flutter Engine from 4cc0b3dab001 to b08e1410a06a (9 revisions)" (flutter/flutter#131896) 2023-08-03 [email protected] Manual roll Flutter Engine from 4cc0b3dab001 to b08e1410a06a (9 revisions) (flutter/flutter#131880) 2023-08-03 [email protected] Added new gallery benchmark test that forces opengles. (flutter/flutter#131796) 2023-08-03 [email protected] Roll Packages from 4e4961a to d00c1f9 (10 revisions) (flutter/flutter#131866) 2023-08-03 [email protected] manual pub package roll (flutter/flutter#131804) 2023-08-03 [email protected] remove Mac_ios ios_app_with_extensions_test (flutter/flutter#131806) 2023-08-03 [email protected] Roll Flutter Engine from 46f3e099ad04 to 4cc0b3dab001 (3 revisions) (flutter/flutter#131854) 2023-08-03 [email protected] Adds a11y assessment sample app (flutter/flutter#131716) 2023-08-03 [email protected] Remove target Staging_build_linux framework_tests_misc (flutter/flutter#126959) 2023-08-03 [email protected] Manual roll Flutter Engine from 4c1157b9da54 to 46f3e099ad04 (3 revisions) (flutter/flutter#131848) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
6 participants
I deleted the target mentioned in the issue listed below. This is my first time contributing to open source please explain if I did anything wrong in the process or wrong with the changes.
Best
List which issues are fixed by this PR. You must list at least one issue.
Resolves #126278
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.