Migrate benchmarks to package:web #126848

joshualitt · 2023-05-15T16:31:21Z

No description provided.

dev/benchmarks/macrobenchmarks/lib/src/web/recorder.dart

eyebrowsoffire

LGTM

kevmoo · 2023-05-18T17:01:07Z

dev/benchmarks/macrobenchmarks/lib/src/web/recorder.dart

Is there an issue open for this?

I'm not sure TBH. A brief search turned up other cases of false positives for this lint(i.e. cases where the import was used, but this lint triggers anyways). Our setup is also a bit complicated, and something else may be triggering this issue. We can revisit if this shows up outside of Flutter.

This reverts commit 4fea3ef.

dev/benchmarks/macrobenchmarks/lib/web_benchmarks.dart

sigmundch · 2023-05-19T16:58:50Z

dev/benchmarks/macrobenchmarks/lib/web_benchmarks.dart


    if (sendData != null) {
-      xhr.send(sendData);
+      xhr.send((sendData as Object?).jsify());


consider changing the type of sendData to String, and just call .toJS here - seems like we already encode the data as json on all callsites

sigmundch · 2023-05-19T17:07:18Z

dev/benchmarks/macrobenchmarks/lib/src/web/bench_platform_view_infinite_scroll.dart

-      ..backgroundColor = 'rgba(0, 255, 0, .5)'
-      ..textAlign = 'center'
-      ..border = '1px solid black';
+      ..setProperty('width'.toJS, '100%'.toJS)


btw - I run into these on my migration too, I think we are going to hit these very often and we can do better in package:web for this.

Looking more closely, dart:html has a list of properties for CSS that we use to generate the full set of accessors (see https://github.com/dart-lang/sdk/blob/main/tools/dom/scripts/CSSPropertyNames.in)

Filed an issue: dart-lang/web#47

We would also probably want to find a way to signal to the browser that the target of the conversion is a constant and can be memoized.

Reverts #126848 Triggered some kind of measuring discrepancy / performance regression.

yjbanov · 2023-05-19T17:24:28Z

dev/benchmarks/macrobenchmarks/lib/src/web/bench_platform_view_infinite_scroll.dart

-    htmlElement.id = '${benchmarkViewType}_$viewId';
-    htmlElement.innerText = 'Google';
+    final web.HTMLElement htmlElement = web.document.createElement('div'.toJS)
+        as web.HTMLDivElement;


Is the cast necessary if the variable type is HTMLElement?

yjbanov · 2023-05-19T17:26:27Z

dev/benchmarks/macrobenchmarks/lib/src/web/bench_platform_view_infinite_scroll.dart

-      ..backgroundColor = 'rgba(0, 255, 0, .5)'
-      ..textAlign = 'center'
-      ..border = '1px solid black';
+      ..setProperty('width'.toJS, '100%'.toJS)


We would also probably want to find a way to signal to the browser that the target of the conversion is a constant and can be memoized.

flutter/flutter@5ae6438...077d644 2023-05-19 [email protected] Roll Flutter Engine from 2e6b1e6c3458 to a0ea4d2d9ea5 (1 revision) (flutter/flutter#127203) 2023-05-19 [email protected] Roll Flutter Engine from e9178e115f14 to 2e6b1e6c3458 (1 revision) (flutter/flutter#127196) 2023-05-19 [email protected] fix(flutter_tools): `findBundleFile` w/multiple flavor dimensions (flutter/flutter#127133) 2023-05-19 [email protected] Roll Flutter Engine from 2e8875870f52 to e9178e115f14 (1 revision) (flutter/flutter#127188) 2023-05-19 [email protected] Roll Flutter Engine from c7a209cc40c1 to 2e8875870f52 (1 revision) (flutter/flutter#127185) 2023-05-19 [email protected] Roll Flutter Engine from 5a57ff52f0f7 to c7a209cc40c1 (2 revisions) (flutter/flutter#127175) 2023-05-19 [email protected] Roll Flutter Engine from bfbd2e1dafb0 to 5a57ff52f0f7 (1 revision) (flutter/flutter#127172) 2023-05-19 [email protected] Roll Flutter Engine from e64084596182 to bfbd2e1dafb0 (2 revisions) (flutter/flutter#127167) 2023-05-19 [email protected] Roll Flutter Engine from 6bc60c8a9877 to e64084596182 (2 revisions) (flutter/flutter#127163) 2023-05-19 [email protected] Roll Flutter Engine from bca11a423f9c to 6bc60c8a9877 (1 revision) (flutter/flutter#127162) 2023-05-19 [email protected] Roll Flutter Engine from 9039c2dfb74c to bca11a423f9c (2 revisions) (flutter/flutter#127156) 2023-05-19 [email protected] Roll Flutter Engine from 3c23ddae1d2a to 9039c2dfb74c (2 revisions) (flutter/flutter#127154) 2023-05-19 [email protected] Properly cleans up routes (flutter/flutter#126453) 2023-05-19 [email protected] Remove deprecated `primaryVariant` and `secondaryVariant` from `ColorScheme` (flutter/flutter#127124) 2023-05-19 [email protected] Roll Flutter Engine from 17227c16ca58 to 3c23ddae1d2a (2 revisions) (flutter/flutter#127147) 2023-05-18 [email protected] Update `useMaterial3` api doc (flutter/flutter#127142) 2023-05-18 [email protected] Roll Flutter Engine from c7c679d6d411 to 17227c16ca58 (1 revision) (flutter/flutter#127143) 2023-05-18 [email protected] Roll Flutter Engine from 2c77c8011d45 to c7c679d6d411 (1 revision) (flutter/flutter#127139) 2023-05-18 [email protected] Roll Flutter Engine from 5fb3179a19c3 to 2c77c8011d45 (2 revisions) (flutter/flutter#127131) 2023-05-18 [email protected] Migrate benchmarks to package:web (flutter/flutter#126848) 2023-05-18 [email protected] Roll Flutter Engine from 237c60185ace to 5fb3179a19c3 (3 revisions) (flutter/flutter#127126) 2023-05-18 [email protected] Fixing richMessage gesture recognizer in tooltip widget (flutter/flutter#126207) 2023-05-18 [email protected] Roll Flutter Engine from 843ce0bba356 to 237c60185ace (2 revisions) (flutter/flutter#127122) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Reverts flutter#126848 Triggered some kind of measuring discrepancy / performance regression.

This attempts to reland #126848 This was reverted because it made some unexpected changes to our perf measurements. After landing #127900, we have much less noise in our benchmarks, so I'd like to reland this and see if there is still a significant measurement difference.

flutter/flutter@5ae6438...077d644 2023-05-19 [email protected] Roll Flutter Engine from 2e6b1e6c3458 to a0ea4d2d9ea5 (1 revision) (flutter/flutter#127203) 2023-05-19 [email protected] Roll Flutter Engine from e9178e115f14 to 2e6b1e6c3458 (1 revision) (flutter/flutter#127196) 2023-05-19 [email protected] fix(flutter_tools): `findBundleFile` w/multiple flavor dimensions (flutter/flutter#127133) 2023-05-19 [email protected] Roll Flutter Engine from 2e8875870f52 to e9178e115f14 (1 revision) (flutter/flutter#127188) 2023-05-19 [email protected] Roll Flutter Engine from c7a209cc40c1 to 2e8875870f52 (1 revision) (flutter/flutter#127185) 2023-05-19 [email protected] Roll Flutter Engine from 5a57ff52f0f7 to c7a209cc40c1 (2 revisions) (flutter/flutter#127175) 2023-05-19 [email protected] Roll Flutter Engine from bfbd2e1dafb0 to 5a57ff52f0f7 (1 revision) (flutter/flutter#127172) 2023-05-19 [email protected] Roll Flutter Engine from e64084596182 to bfbd2e1dafb0 (2 revisions) (flutter/flutter#127167) 2023-05-19 [email protected] Roll Flutter Engine from 6bc60c8a9877 to e64084596182 (2 revisions) (flutter/flutter#127163) 2023-05-19 [email protected] Roll Flutter Engine from bca11a423f9c to 6bc60c8a9877 (1 revision) (flutter/flutter#127162) 2023-05-19 [email protected] Roll Flutter Engine from 9039c2dfb74c to bca11a423f9c (2 revisions) (flutter/flutter#127156) 2023-05-19 [email protected] Roll Flutter Engine from 3c23ddae1d2a to 9039c2dfb74c (2 revisions) (flutter/flutter#127154) 2023-05-19 [email protected] Properly cleans up routes (flutter/flutter#126453) 2023-05-19 [email protected] Remove deprecated `primaryVariant` and `secondaryVariant` from `ColorScheme` (flutter/flutter#127124) 2023-05-19 [email protected] Roll Flutter Engine from 17227c16ca58 to 3c23ddae1d2a (2 revisions) (flutter/flutter#127147) 2023-05-18 [email protected] Update `useMaterial3` api doc (flutter/flutter#127142) 2023-05-18 [email protected] Roll Flutter Engine from c7c679d6d411 to 17227c16ca58 (1 revision) (flutter/flutter#127143) 2023-05-18 [email protected] Roll Flutter Engine from 2c77c8011d45 to c7c679d6d411 (1 revision) (flutter/flutter#127139) 2023-05-18 [email protected] Roll Flutter Engine from 5fb3179a19c3 to 2c77c8011d45 (2 revisions) (flutter/flutter#127131) 2023-05-18 [email protected] Migrate benchmarks to package:web (flutter/flutter#126848) 2023-05-18 [email protected] Roll Flutter Engine from 237c60185ace to 5fb3179a19c3 (3 revisions) (flutter/flutter#127126) 2023-05-18 [email protected] Fixing richMessage gesture recognizer in tooltip widget (flutter/flutter#126207) 2023-05-18 [email protected] Roll Flutter Engine from 843ce0bba356 to 237c60185ace (2 revisions) (flutter/flutter#127122) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels May 15, 2023

joshualitt force-pushed the benchmarks branch 5 times, most recently from 8ae233d to 11506cc Compare May 15, 2023 20:49

joshualitt force-pushed the benchmarks branch from eb6c701 to 52467c8 Compare May 15, 2023 21:23

joshualitt requested a review from eyebrowsoffire May 15, 2023 21:58

joshualitt force-pushed the benchmarks branch from 52467c8 to 6a95f91 Compare May 15, 2023 22:38

eyebrowsoffire reviewed May 16, 2023

View reviewed changes

dev/benchmarks/macrobenchmarks/lib/src/web/recorder.dart Outdated Show resolved Hide resolved

joshualitt marked this pull request as ready for review May 16, 2023 16:31

joshualitt requested a review from eyebrowsoffire May 16, 2023 21:40

eyebrowsoffire approved these changes May 18, 2023

View reviewed changes

kevmoo reviewed May 18, 2023

View reviewed changes

joshualitt force-pushed the benchmarks branch 2 times, most recently from 88cf13e to f297e9b Compare May 18, 2023 19:24

Migrate benchmarks to package:web

2d90297

joshualitt force-pushed the benchmarks branch from f297e9b to 2d90297 Compare May 18, 2023 19:52

joshualitt merged commit 4fea3ef into flutter:master May 18, 2023

engine-flutter-autoroll mentioned this pull request May 19, 2023

Roll Flutter from 5ae64381578c to 0d67c7e10cf9 (20 revisions) flutter/packages#4041

Closed

zanderso mentioned this pull request May 19, 2023

Web benchmark regressions on switch to package:web #127200

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2023

4fea3ef Migrate benchmarks to package:web (flutter/flutter#126848)

94b0cc9

engine-flutter-autoroll mentioned this pull request May 19, 2023

Roll Flutter from 5ae64381578c to 54ac355dc11f (22 revisions) flutter/packages#4042

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2023

4fea3ef Migrate benchmarks to package:web (flutter/flutter#126848)

0b9d10a

joshualitt mentioned this pull request May 19, 2023

Revert "Migrate benchmarks to package:web" #127207

Merged

joshualitt added a commit that referenced this pull request May 19, 2023

Revert "Migrate benchmarks to package:web (#126848)"

55d45b6

This reverts commit 4fea3ef.

engine-flutter-autoroll mentioned this pull request May 19, 2023

Roll Flutter from 5ae64381578c to 077d644bbc5f (23 revisions) flutter/packages#4043

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2023

4fea3ef Migrate benchmarks to package:web (flutter/flutter#126848)

f668412

sigmundch reviewed May 19, 2023

View reviewed changes

joshualitt added a commit that referenced this pull request May 19, 2023

Revert "Migrate benchmarks to package:web" (#127207)

3001d6a

Reverts #126848 Triggered some kind of measuring discrepancy / performance regression.

yjbanov reviewed May 19, 2023

View reviewed changes

joshualitt mentioned this pull request May 22, 2023

Reland "Migrate benchmarks to package:web" #127327

Closed

CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023

Migrate benchmarks to package:web (flutter#126848)

18be059

CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023

Revert "Migrate benchmarks to package:web" (flutter#127207)

85f2385

Reverts flutter#126848 Triggered some kind of measuring discrepancy / performance regression.

This was referenced May 25, 2023

Support minifcation for apps that depend on AGP 8 and integration_test #127628

Merged

i127682 android api 33 test support #127689

Merged

eyebrowsoffire added a commit to eyebrowsoffire/flutter that referenced this pull request Jun 5, 2023

Reland "Migrate benchmarks to package:web" flutter#126848

d1db49b

eyebrowsoffire mentioned this pull request Jun 5, 2023

Reland "Migrate benchmarks to package:web" #128266

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023

4fea3ef Migrate benchmarks to package:web (flutter/flutter#126848)

bf099d9

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

4fea3ef Migrate benchmarks to package:web (flutter/flutter#126848)

c3e8af8

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

4fea3ef Migrate benchmarks to package:web (flutter/flutter#126848)

775fc3c

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

4fea3ef Migrate benchmarks to package:web (flutter/flutter#126848)

da3f494

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Migrate benchmarks to package:web #126848

Migrate benchmarks to package:web #126848

Uh oh!

joshualitt commented May 15, 2023

Uh oh!

Uh oh!

eyebrowsoffire left a comment

Uh oh!

kevmoo May 18, 2023

Uh oh!

joshualitt May 18, 2023

Uh oh!

Uh oh!

sigmundch May 19, 2023

Uh oh!

sigmundch May 19, 2023

Uh oh!

yjbanov May 19, 2023

Uh oh!

yjbanov May 19, 2023

Uh oh!

yjbanov May 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Migrate benchmarks to package:web #126848

Migrate benchmarks to package:web #126848

Uh oh!

Conversation

joshualitt commented May 15, 2023

Uh oh!

Uh oh!

eyebrowsoffire left a comment

Choose a reason for hiding this comment

Uh oh!

kevmoo May 18, 2023

Choose a reason for hiding this comment

Uh oh!

joshualitt May 18, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sigmundch May 19, 2023

Choose a reason for hiding this comment

Uh oh!

sigmundch May 19, 2023

Choose a reason for hiding this comment

Uh oh!

yjbanov May 19, 2023

Choose a reason for hiding this comment

Uh oh!

yjbanov May 19, 2023

Choose a reason for hiding this comment

Uh oh!

yjbanov May 19, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants