Skip to content

[CP] rename AssetManifest.bin to AssetManifest.smcbin #126837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
itsjustkevin merged 1 commit into from
May 16, 2023
Merged

[CP] rename AssetManifest.bin to AssetManifest.smcbin #126837

itsjustkevin merged 1 commit into from
May 16, 2023

Conversation

@andrewkolos
Copy link
Contributor

@andrewkolos andrewkolos commented May 15, 2023 •
edited
Loading

Cherry-picks the changes of #126077 into the current stable branch, which fixes #126839.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels May 15, 2023
@andrewkolos andrewkolos mentioned this pull request May 15, 2023
Closed
@andrewkolos andrewkolos requested a review from jonahwilliams May 15, 2023 15:51
jonahwilliams
jonahwilliams approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itsjustkevin itsjustkevin merged commit 4f2ec05 into flutter:flutter-3.10-candidate.1 May 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 17, 2023
@engine-flutter-autoroll
4f2ec0548 [CP] rename AssetManifest.bin to AssetManifest.smcbin (flut…
99d6d7e 
…ter/flutter#126837)
@andrewkolos andrewkolos mentioned this pull request May 22, 2023
Closed
2 tasks
@reidbaker reidbaker mentioned this pull request May 31, 2023
Merged
8 tasks
@darshankawar darshankawar mentioned this pull request Jun 7, 2023
Closed
@andrewkolos andrewkolos mentioned this pull request Jun 7, 2023
Closed
@andrewkolos andrewkolos deleted the cp-rename-assset-manifest-2 branch June 15, 2023 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewkolos @jonahwilliams @itsjustkevin