Update SemanticsUpdateBuilderSpy for the conversion of SemanticsUpdateBuilder into a base class #126570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: accessibility
dnfield
reviewed
May 11, 2023
Contributor
There was a problem hiding this comment.
This ends up causing some pain if we have to make changes upstream that add a method.
Can we override noSuchMethod or extend Fake on this?
Member
Author
There was a problem hiding this comment.
Added extends Fake
jason-simmons
force-pushed
the
bug_123756_test
branch
2 times, most recently
from
2780079 to
a1d819c
Compare
dnfield
approved these changes
May 11, 2023
dnfield
added
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter, pr: 126570, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
…eBuilder into a base class See flutter#123756
jason-simmons
force-pushed
the
bug_123756_test
branch
from
a1d819c to
5a704a3
Compare
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 16, 2023
…icsUpdateBuilder into a base class (flutter/flutter#126570)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 16, 2023
…icsUpdateBuilder into a base class (flutter/flutter#126570)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 16, 2023
…icsUpdateBuilder into a base class (flutter/flutter#126570)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 16, 2023
…icsUpdateBuilder into a base class (flutter/flutter#126570)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 16, 2023
…icsUpdateBuilder into a base class (flutter/flutter#126570)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 16, 2023
…icsUpdateBuilder into a base class (flutter/flutter#126570)
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…eBuilder into a base class (flutter#126570) See flutter#123756
This was referenced May 25, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
…icsUpdateBuilder into a base class (flutter/flutter#126570)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
…icsUpdateBuilder into a base class (flutter/flutter#126570)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
…icsUpdateBuilder into a base class (flutter/flutter#126570)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
…icsUpdateBuilder into a base class (flutter/flutter#126570)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #123756