Add checkmark style to CupertinoRadio #126480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: cupertino
Contributor
There was a problem hiding this comment.
Suggested change
| /// Controls wether the checkmark style is used in an iOS style radio. | |
| /// Controls whether the checkmark style is used in an iOS style radio. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Only usuable under the [RadioListTile.adaptive] constructor. If set to | |
| /// Only usable under the [RadioListTile.adaptive] constructor. If set to |
Contributor
There was a problem hiding this comment.
Eww. I mean, I see why this has to be here if you want to use it from the adaptive constructor, but it feels ugly to have a parameter to the adaptive constructor that is only in effect for one kind of rendering. I suppose it's no different than materialTapTargetSize in that regard, though.
Would it be better to include "cupertino" in the name to make it clear that it doesn't affect Material radio buttons? e.g. useCupertinoCheckmarkStyle?
Contributor
Author
There was a problem hiding this comment.
Yeah, I agree, I was trying different things to make it less gross, but this is where I landed.
Using Cupertino in the name instead of adaptive seems better to avoid possible confusion.
MitchellGoodwin
force-pushed
the
create-cupertino-radio
branch
from
3a4260b to
1ac7557
Compare
guidezpl
requested changes
May 15, 2023
Member
There was a problem hiding this comment.
nit: same ordering as in radio_list_tile.dart please
Member
There was a problem hiding this comment.
Suggested change
| /// Controls whether the checkmark style is used in an iOS style radio. | |
| /// Controls whether the checkmark style is used in an iOS-style radio. |
Member
There was a problem hiding this comment.
please point to [CupertinoRadio.useCheckmarkStyle]
Comment on lines
440
to
445
Member
There was a problem hiding this comment.
Please write near-identical documentation with radio.dart
MitchellGoodwin
force-pushed
the
create-cupertino-radio
branch
from
1ac7557 to
6e2ba5e
Compare
guidezpl
approved these changes
May 15, 2023
Member
guidezpl
left a comment
guidezpl
left a comment
There was a problem hiding this comment.
_ ___ _____ __ __
| | / __|_ _| \/ |
| |_| (_ | | | | |\/| |
|____\___| |_| |_| |_|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 18, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 18, 2023
Roll Flutter from d0d1feb to 5ae6438 (42 revisions) flutter/flutter@d0d1feb...5ae6438 2023-05-18 [email protected] Revert "Handle null return from WillPopCallback" (flutter/flutter#127112) 2023-05-18 [email protected] Roll Flutter Engine from a22dd6438335 to 843ce0bba356 (6 revisions) (flutter/flutter#127116) 2023-05-18 [email protected] mark windows build tests non-bringup (flutter/flutter#127059) 2023-05-18 [email protected] Roll Flutter Engine from d97037077963 to a22dd6438335 (1 revision) (flutter/flutter#127071) 2023-05-18 [email protected] Roll Packages from 5c69914 to b31a128 (9 revisions) (flutter/flutter#127109) 2023-05-18 [email protected] Revert "Remove obsolete drawShadow bounds workaround" (flutter/flutter#127110) 2023-05-18 [email protected] Clip search view content during animation (flutter/flutter#126975) 2023-05-18 [email protected] Remove obsolete drawShadow bounds workaround (flutter/flutter#127052) 2023-05-17 [email protected] [Windows] Improve version migration message (flutter/flutter#127048) 2023-05-17 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 9471598e3b7ff22b2fa181bd79addf94cb3e0847 to 6b107e7a7ee5e054e0bcce60de5181d21e2f00fb (flutter/flutter#127056) 2023-05-17 [email protected] Remove deprecated fixTextFieldOutlineLabel (flutter/flutter#125893) 2023-05-17 [email protected] Roll Flutter Engine from 331c5769e291 to d97037077963 (3 revisions) (flutter/flutter#127053) 2023-05-17 [email protected] shard windows build tests 3 -> 4 (flutter/flutter#127057) 2023-05-17 [email protected] Roll Flutter Engine from 0ae3719d7043 to 331c5769e291 (1 revision) (flutter/flutter#127049) 2023-05-17 [email protected] Ignore unused_element_parameter (flutter/flutter#126926) 2023-05-17 [email protected] Roll Flutter Engine from 47fd496c6f8d to 0ae3719d7043 (2 revisions) (flutter/flutter#127043) 2023-05-17 [email protected] Roll Flutter Engine from 400a26ad8343 to 47fd496c6f8d (3 revisions) (flutter/flutter#127041) 2023-05-17 [email protected] [flutter_tools] unpin and roll camera_android (flutter/flutter#126945) 2023-05-17 [email protected] Handle null return from WillPopCallback (flutter/flutter#127039) 2023-05-17 [email protected] Roll Flutter Engine from 6048360c1837 to 400a26ad8343 (1 revision) (flutter/flutter#127036) 2023-05-17 [email protected] Remove unused (and untested) parameters from private _MasterDetailFlow (flutter/flutter#126935) 2023-05-17 [email protected] Autocomplete async examples (flutter/flutter#126283) 2023-05-17 [email protected] Expose callback that allows focus traversal customization (flutter/flutter#120235) 2023-05-17 [email protected] Roll Packages from b971830 to 5c69914 (5 revisions) (flutter/flutter#127034) 2023-05-17 [email protected] Roll Flutter Engine from ea3f27383acc to 6048360c1837 (2 revisions) (flutter/flutter#127032) 2023-05-17 [email protected] Add missing `Switch.onFocusChange` test (flutter/flutter#126685) 2023-05-17 [email protected] Remove 'url_launcher' from pubspec.yaml. (flutter/flutter#126939) 2023-05-17 [email protected] Roll Flutter Engine from 4b7c37532ea4 to ea3f27383acc (1 revision) (flutter/flutter#126994) 2023-05-17 [email protected] Roll Flutter Engine from 170b45bae571 to 4b7c37532ea4 (1 revision) (flutter/flutter#126985) 2023-05-17 [email protected] Roll Flutter Engine from 28b9dc993c30 to 170b45bae571 (1 revision) (flutter/flutter#126981) 2023-05-17 [email protected] Roll Flutter Engine from 87a03e107df7 to 28b9dc993c30 (1 revision) (flutter/flutter#126974) 2023-05-17 [email protected] Roll Flutter Engine from 1c775e34e2d5 to 87a03e107df7 (3 revisions) (flutter/flutter#126968) 2023-05-16 [email protected] Fix style issues (flutter/flutter#122586) 2023-05-16 [email protected] Manual roll Flutter Engine from fe2476743b59 to 1c775e34e2d5 (10 revisions) (flutter/flutter#126961) 2023-05-16 [email protected] Make SlottedMultiChildRenderObjectWidgetMixin a concrete class (flutter/flutter#126108) 2023-05-16 [email protected] Add ScrollMetrics.extentTotal for completeness (flutter/flutter#126607) 2023-05-16 [email protected] Fix drone_dimensions. (flutter/flutter#126953) 2023-05-16 [email protected] Add checkmark style to CupertinoRadio (flutter/flutter#126480) 2023-05-16 [email protected] Move `Mac_build_test flutter_gallery__transition_perf_e2e_ios` to prod (flutter/flutter#126941) 2023-05-16 [email protected] Fix DataTableThemeData.copyWith handling of dataRowHeight (flutter/flutter#126943) 2023-05-16 [email protected] Fix copyWith method of ActionIconThemeData (flutter/flutter#126763) 2023-05-16 [email protected] Revert "Roll Flutter Engine from fe2476743b59 to 5cf141f7c03c (2 revisions)" (flutter/flutter#126954) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages ...
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
Fixes: flutter#102813 Adds a checkmark style to the Cupertino Radio. Also allows the Radio.adaptive and RadioListTile.adaptive widgets to control whether they use the checkmark style for their Cupertino widgets or not. This is how it looks in action: https://github.com/flutter/flutter/assets/58190796/b409b270-42dd-404a-9350-d2c3e1d7fa4e
This was referenced May 25, 2023
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
Roll Flutter from d0d1feb to 5ae6438 (42 revisions) flutter/flutter@d0d1feb...5ae6438 2023-05-18 [email protected] Revert "Handle null return from WillPopCallback" (flutter/flutter#127112) 2023-05-18 [email protected] Roll Flutter Engine from a22dd6438335 to 843ce0bba356 (6 revisions) (flutter/flutter#127116) 2023-05-18 [email protected] mark windows build tests non-bringup (flutter/flutter#127059) 2023-05-18 [email protected] Roll Flutter Engine from d97037077963 to a22dd6438335 (1 revision) (flutter/flutter#127071) 2023-05-18 [email protected] Roll Packages from 5c69914 to b31a128 (9 revisions) (flutter/flutter#127109) 2023-05-18 [email protected] Revert "Remove obsolete drawShadow bounds workaround" (flutter/flutter#127110) 2023-05-18 [email protected] Clip search view content during animation (flutter/flutter#126975) 2023-05-18 [email protected] Remove obsolete drawShadow bounds workaround (flutter/flutter#127052) 2023-05-17 [email protected] [Windows] Improve version migration message (flutter/flutter#127048) 2023-05-17 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 9471598e3b7ff22b2fa181bd79addf94cb3e0847 to 6b107e7a7ee5e054e0bcce60de5181d21e2f00fb (flutter/flutter#127056) 2023-05-17 [email protected] Remove deprecated fixTextFieldOutlineLabel (flutter/flutter#125893) 2023-05-17 [email protected] Roll Flutter Engine from 331c5769e291 to d97037077963 (3 revisions) (flutter/flutter#127053) 2023-05-17 [email protected] shard windows build tests 3 -> 4 (flutter/flutter#127057) 2023-05-17 [email protected] Roll Flutter Engine from 0ae3719d7043 to 331c5769e291 (1 revision) (flutter/flutter#127049) 2023-05-17 [email protected] Ignore unused_element_parameter (flutter/flutter#126926) 2023-05-17 [email protected] Roll Flutter Engine from 47fd496c6f8d to 0ae3719d7043 (2 revisions) (flutter/flutter#127043) 2023-05-17 [email protected] Roll Flutter Engine from 400a26ad8343 to 47fd496c6f8d (3 revisions) (flutter/flutter#127041) 2023-05-17 [email protected] [flutter_tools] unpin and roll camera_android (flutter/flutter#126945) 2023-05-17 [email protected] Handle null return from WillPopCallback (flutter/flutter#127039) 2023-05-17 [email protected] Roll Flutter Engine from 6048360c1837 to 400a26ad8343 (1 revision) (flutter/flutter#127036) 2023-05-17 [email protected] Remove unused (and untested) parameters from private _MasterDetailFlow (flutter/flutter#126935) 2023-05-17 [email protected] Autocomplete async examples (flutter/flutter#126283) 2023-05-17 [email protected] Expose callback that allows focus traversal customization (flutter/flutter#120235) 2023-05-17 [email protected] Roll Packages from b971830 to 5c69914 (5 revisions) (flutter/flutter#127034) 2023-05-17 [email protected] Roll Flutter Engine from ea3f27383acc to 6048360c1837 (2 revisions) (flutter/flutter#127032) 2023-05-17 [email protected] Add missing `Switch.onFocusChange` test (flutter/flutter#126685) 2023-05-17 [email protected] Remove 'url_launcher' from pubspec.yaml. (flutter/flutter#126939) 2023-05-17 [email protected] Roll Flutter Engine from 4b7c37532ea4 to ea3f27383acc (1 revision) (flutter/flutter#126994) 2023-05-17 [email protected] Roll Flutter Engine from 170b45bae571 to 4b7c37532ea4 (1 revision) (flutter/flutter#126985) 2023-05-17 [email protected] Roll Flutter Engine from 28b9dc993c30 to 170b45bae571 (1 revision) (flutter/flutter#126981) 2023-05-17 [email protected] Roll Flutter Engine from 87a03e107df7 to 28b9dc993c30 (1 revision) (flutter/flutter#126974) 2023-05-17 [email protected] Roll Flutter Engine from 1c775e34e2d5 to 87a03e107df7 (3 revisions) (flutter/flutter#126968) 2023-05-16 [email protected] Fix style issues (flutter/flutter#122586) 2023-05-16 [email protected] Manual roll Flutter Engine from fe2476743b59 to 1c775e34e2d5 (10 revisions) (flutter/flutter#126961) 2023-05-16 [email protected] Make SlottedMultiChildRenderObjectWidgetMixin a concrete class (flutter/flutter#126108) 2023-05-16 [email protected] Add ScrollMetrics.extentTotal for completeness (flutter/flutter#126607) 2023-05-16 [email protected] Fix drone_dimensions. (flutter/flutter#126953) 2023-05-16 [email protected] Add checkmark style to CupertinoRadio (flutter/flutter#126480) 2023-05-16 [email protected] Move `Mac_build_test flutter_gallery__transition_perf_e2e_ios` to prod (flutter/flutter#126941) 2023-05-16 [email protected] Fix DataTableThemeData.copyWith handling of dataRowHeight (flutter/flutter#126943) 2023-05-16 [email protected] Fix copyWith method of ActionIconThemeData (flutter/flutter#126763) 2023-05-16 [email protected] Revert "Roll Flutter Engine from fe2476743b59 to 5cf141f7c03c (2 revisions)" (flutter/flutter#126954) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages ...
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #102813
Adds a checkmark style to the Cupertino Radio. Also allows the Radio.adaptive and RadioListTile.adaptive widgets to control whether they use the checkmark style for their Cupertino widgets or not.
This is how it looks in action:
Screen.Recording.2023-05-10.at.4.42.30.PM.mov
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.