Skip to content

Conversation

@stuartmorgan-g
Copy link
Contributor

Manual package roll to fix tree.

Fixes #126393

Manual package roll to fix tree.

Fixes #126393
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g
Copy link
Contributor Author

Landing on red to fix the tree, since the only test this can affect passed.

@stuartmorgan-g stuartmorgan-g merged commit df789c9 into master May 10, 2023
@stuartmorgan-g stuartmorgan-g deleted the packages-roll-2023-95-10 branch May 10, 2023 13:42
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
camsim99 pushed a commit to flutter/packages that referenced this pull request May 12, 2023
flutter/flutter@8c5a1ea...a76dbe4

2023-05-10 [email protected] Manual roll Flutter Engine
from 8ca16cba8c38 to 78f41a8f2f06 (2 revisions) (flutter/flutter#126392)
2023-05-10 [email protected] Roll flutter/packages to 0167d83
(flutter/flutter#126427)
2023-05-10 [email protected] Migrate gallery
ios tests to build+test (flutter/flutter#111164)
2023-05-09 [email protected] Roll Flutter Engine from
824cd09b8c62 to 8ca16cba8c38 (5 revisions) (flutter/flutter#126360)
2023-05-09 [email protected] Revert "Provide default constraints
for M3 dialogs" (flutter/flutter#126355)
2023-05-09 [email protected] Roll Packages from
4800d65 to 1f91710 (8 revisions) (flutter/flutter#126352)
2023-05-09 [email protected] [github] Add labeler action
(flutter/flutter#126012)
2023-05-09 [email protected] Fix platformLocation path and search
dropping (flutter/flutter#126232)
2023-05-09 [email protected] Roll Flutter Engine from
8d3a8162b3ab to 824cd09b8c62 (10 revisions) (flutter/flutter#126309)
2023-05-09 [email protected] Update FocusNode documentation
(flutter/flutter#126331)
2023-05-09 [email protected] Remove dead code
(flutter/flutter#126266)
2023-05-09 [email protected] fix AppBar's
docs for backgroundColor (flutter/flutter#126194)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC
[email protected],[email protected],[email protected] on
the revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
Manual package roll to fix tree.

Fixes flutter#126393
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
flutter/flutter@8c5a1ea...a76dbe4

2023-05-10 [email protected] Manual roll Flutter Engine
from 8ca16cba8c38 to 78f41a8f2f06 (2 revisions) (flutter/flutter#126392)
2023-05-10 [email protected] Roll flutter/packages to 0167d83
(flutter/flutter#126427)
2023-05-10 [email protected] Migrate gallery
ios tests to build+test (flutter/flutter#111164)
2023-05-09 [email protected] Roll Flutter Engine from
824cd09b8c62 to 8ca16cba8c38 (5 revisions) (flutter/flutter#126360)
2023-05-09 [email protected] Revert "Provide default constraints
for M3 dialogs" (flutter/flutter#126355)
2023-05-09 [email protected] Roll Packages from
4800d65 to 1f91710 (8 revisions) (flutter/flutter#126352)
2023-05-09 [email protected] [github] Add labeler action
(flutter/flutter#126012)
2023-05-09 [email protected] Fix platformLocation path and search
dropping (flutter/flutter#126232)
2023-05-09 [email protected] Roll Flutter Engine from
8d3a8162b3ab to 824cd09b8c62 (10 revisions) (flutter/flutter#126309)
2023-05-09 [email protected] Update FocusNode documentation
(flutter/flutter#126331)
2023-05-09 [email protected] Remove dead code
(flutter/flutter#126266)
2023-05-09 [email protected] fix AppBar's
docs for backgroundColor (flutter/flutter#126194)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC
[email protected],[email protected],[email protected] on
the revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tree closed on new pigeon analyzer lint

2 participants