Skip to content

Update FocusNode documentation #126331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
May 9, 2023
Merged

Update FocusNode documentation #126331

auto-submit merged 1 commit into from
May 9, 2023

Conversation

@bleroux
Copy link
Contributor

@bleroux bleroux commented May 9, 2023

Description

This PR adds some details in FocusNode documentation to explain more precisely when listeners are notified.

Related Issue

Fixes #126149

Tests

Documentation only.

@flutter-dashboard flutter-dashboard bot added f: focus Focus traversal, gaining or losing focus framework flutter/packages/flutter repository. See also f: labels. labels May 9, 2023
@bleroux bleroux mentioned this pull request May 9, 2023
Closed
2 tasks
@bleroux bleroux requested a review from gspencergoog May 9, 2023 12:45
gspencergoog
gspencergoog approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Thanks!

@bleroux bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label May 9, 2023
@auto-submit auto-submit bot merged commit a800edf into flutter:master May 9, 2023
@bleroux bleroux deleted the make_focus_node_documentation_more_precise branch May 9, 2023 16:40
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
a800edf Update FocusNode documentation (flutter/flutter#126331)
66b8db0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 10, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
a800edf Update FocusNode documentation (flutter/flutter#126331)
764dbc2
camsim99 pushed a commit to flutter/packages that referenced this pull request May 12, 2023
@engine-flutter-autoroll
Roll Flutter from 8c5a1ea to a76dbe4 (12 revisions) (#3958)
cabd7ea 
flutter/flutter@8c5a1ea...a76dbe4

2023-05-10 [email protected] Manual roll Flutter Engine
from 8ca16cba8c38 to 78f41a8f2f06 (2 revisions) (flutter/flutter#126392)
2023-05-10 [email protected] Roll flutter/packages to 0167d83
(flutter/flutter#126427)
2023-05-10 [email protected] Migrate gallery
ios tests to build+test (flutter/flutter#111164)
2023-05-09 [email protected] Roll Flutter Engine from
824cd09b8c62 to 8ca16cba8c38 (5 revisions) (flutter/flutter#126360)
2023-05-09 [email protected] Revert "Provide default constraints
for M3 dialogs" (flutter/flutter#126355)
2023-05-09 [email protected] Roll Packages from
4800d65 to 1f91710 (8 revisions) (flutter/flutter#126352)
2023-05-09 [email protected] [github] Add labeler action
(flutter/flutter#126012)
2023-05-09 [email protected] Fix platformLocation path and search
dropping (flutter/flutter#126232)
2023-05-09 [email protected] Roll Flutter Engine from
8d3a8162b3ab to 824cd09b8c62 (10 revisions) (flutter/flutter#126309)
2023-05-09 [email protected] Update FocusNode documentation
(flutter/flutter#126331)
2023-05-09 [email protected] Remove dead code
(flutter/flutter#126266)
2023-05-09 [email protected] fix AppBar's
docs for backgroundColor (flutter/flutter#126194)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC
[email protected],[email protected],[email protected] on
the revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@engine-flutter-autoroll @nploi
Roll Flutter from 8c5a1ea to a76dbe4 (12 revisions) (flutter#3958)
a1ec68f 
flutter/flutter@8c5a1ea...a76dbe4

2023-05-10 [email protected] Manual roll Flutter Engine
from 8ca16cba8c38 to 78f41a8f2f06 (2 revisions) (flutter/flutter#126392)
2023-05-10 [email protected] Roll flutter/packages to 0167d83
(flutter/flutter#126427)
2023-05-10 [email protected] Migrate gallery
ios tests to build+test (flutter/flutter#111164)
2023-05-09 [email protected] Roll Flutter Engine from
824cd09b8c62 to 8ca16cba8c38 (5 revisions) (flutter/flutter#126360)
2023-05-09 [email protected] Revert "Provide default constraints
for M3 dialogs" (flutter/flutter#126355)
2023-05-09 [email protected] Roll Packages from
4800d65 to 1f91710 (8 revisions) (flutter/flutter#126352)
2023-05-09 [email protected] [github] Add labeler action
(flutter/flutter#126012)
2023-05-09 [email protected] Fix platformLocation path and search
dropping (flutter/flutter#126232)
2023-05-09 [email protected] Roll Flutter Engine from
8d3a8162b3ab to 824cd09b8c62 (10 revisions) (flutter/flutter#126309)
2023-05-09 [email protected] Update FocusNode documentation
(flutter/flutter#126331)
2023-05-09 [email protected] Remove dead code
(flutter/flutter#126266)
2023-05-09 [email protected] fix AppBar's
docs for backgroundColor (flutter/flutter#126194)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC
[email protected],[email protected],[email protected] on
the revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
a800edf Update FocusNode documentation (flutter/flutter#126331)
6b86a62
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
a800edf Update FocusNode documentation (flutter/flutter#126331)
8ad7e16
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
a800edf Update FocusNode documentation (flutter/flutter#126331)
12fddb9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
a800edf Update FocusNode documentation (flutter/flutter#126331)
8e70775
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: focus Focus traversal, gaining or losing focus framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Toggling enabled of Textfield notifies FocusNode listeners

2 participants

@bleroux @gspencergoog