Skip to content

Revert "i125138 abstract method smoke agp update (#125139)" #126274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
May 15, 2023
Merged

Revert "i125138 abstract method smoke agp update (#125139)" #126274

auto-submit merged 3 commits into from
May 15, 2023

Conversation

@reidbaker
Copy link
Contributor

@reidbaker reidbaker commented May 8, 2023

This reverts commit 6459135.

#125331
https://ci.chromium.org/p/flutter/builders/staging/Linux%20firebase_abstract_method_smoke_test?cursor=id%3E8783275059678311409&limit=200

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • [ x I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label May 8, 2023
@reidbaker reidbaker requested review from camsim99 and gmackall May 8, 2023 18:57
@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label May 8, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 8, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented May 8, 2023

auto label is removed for flutter/flutter, pr: 126274, due to - The status or check suite Windows module_custom_host_app_name_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@reidbaker reidbaker mentioned this pull request May 8, 2023
Closed
@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label May 15, 2023
@auto-submit auto-submit bot merged commit c5b31e7 into flutter:master May 15, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2023
@engine-flutter-autoroll
c5b31e7 Revert "i125138 abstract method smoke agp update (#125139)" (f…
e4fe8b1 
…lutter/flutter#126274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2023
@engine-flutter-autoroll
c5b31e7 Revert "i125138 abstract method smoke agp update (#125139)" (f…
2e0cd00 
…lutter/flutter#126274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2023
@engine-flutter-autoroll
c5b31e7 Revert "i125138 abstract method smoke agp update (#125139)" (f…
8c2b523 
…lutter/flutter#126274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
c5b31e7 Revert "i125138 abstract method smoke agp update (#125139)" (f…
1423fbc 
…lutter/flutter#126274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
c5b31e7 Revert "i125138 abstract method smoke agp update (#125139)" (f…
f6a9d90 
…lutter/flutter#126274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
c5b31e7 Revert "i125138 abstract method smoke agp update (#125139)" (f…
dd1edb9 
…lutter/flutter#126274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
c5b31e7 Revert "i125138 abstract method smoke agp update (#125139)" (f…
6dcc358 
…lutter/flutter#126274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
c5b31e7 Revert "i125138 abstract method smoke agp update (#125139)" (f…
57a925b 
…lutter/flutter#126274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
c5b31e7 Revert "i125138 abstract method smoke agp update (#125139)" (f…
5ad4812 
…lutter/flutter#126274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
c5b31e7 Revert "i125138 abstract method smoke agp update (#125139)" (f…
62870db 
…lutter/flutter#126274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
c5b31e7 Revert "i125138 abstract method smoke agp update (#125139)" (f…
3b950c2 
…lutter/flutter#126274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
c5b31e7 Revert "i125138 abstract method smoke agp update (#125139)" (f…
3b8de24 
…lutter/flutter#126274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
c5b31e7 Revert "i125138 abstract method smoke agp update (#125139)" (f…
c6302bc 
…lutter/flutter#126274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
c5b31e7 Revert "i125138 abstract method smoke agp update (#125139)" (f…
df45ea1 
…lutter/flutter#126274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
c5b31e7 Revert "i125138 abstract method smoke agp update (#125139)" (f…
eff6c41 
…lutter/flutter#126274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
c5b31e7 Revert "i125138 abstract method smoke agp update (#125139)" (f…
5570c8f 
…lutter/flutter#126274)
@reidbaker reidbaker deleted the i125331-revert branch May 22, 2023 14:56
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@reidbaker
Revert "i125138 abstract method smoke agp update (flutter#125139)" (f…
08f7a0f 
…lutter#126274)

This reverts commit 6459135.

flutter#125331 
https://ci.chromium.org/p/flutter/builders/staging/Linux%20firebase_abstract_method_smoke_test?cursor=id%3E8783275059678311409&limit=200

- [ x I signed the [CLA].
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
c5b31e7 Revert "i125138 abstract method smoke agp update (#125139)" (f…
72123dc 
…lutter/flutter#126274)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
c5b31e7 Revert "i125138 abstract method smoke agp update (#125139)" (f…
f0a9763 
…lutter/flutter#126274)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
c5b31e7 Revert "i125138 abstract method smoke agp update (#125139)" (f…
bdf6c07 
…lutter/flutter#126274)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
c5b31e7 Revert "i125138 abstract method smoke agp update (#125139)" (f…
d4781bc 
…lutter/flutter#126274)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmackall gmackall gmackall approved these changes

@camsim99 camsim99 camsim99 approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reidbaker @gmackall @camsim99