Make clean command top level #12616
Merged
Make clean command top level #12616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
YES |
Member
|
This wont clean up platform specific build system intermediates. For example, |
tvolkert
approved these changes
Oct 19, 2017
Contributor
tvolkert
left a comment
tvolkert
left a comment
There was a problem hiding this comment.
LGTM
@chinmaygarde, that's true, but it's also true of the current flutter build clean. I filed #12631 to track.
| addSubcommand(new BuildCleanCommand()); | ||
| addSubcommand(new BuildIOSCommand()); | ||
| addSubcommand(new BuildFlxCommand(verboseHelp: verboseHelp)); | ||
| addSubcommand(new CleanCommand()); // here for backwards compatibility. |
Contributor
There was a problem hiding this comment.
I don't think we need to keep backwards compatibility here - if someone was using flutter build clean and wonders where it went, I imagine they'll find it in flutter clean 😄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10783
/cc @sethladd