Skip to content

Fix leaks [prod-leak-fix] #126144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 7 commits into from
May 8, 2023
Merged

Fix leaks [prod-leak-fix] #126144

auto-submit merged 7 commits into from
May 8, 2023

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented May 5, 2023 •
edited
Loading

Fixes #126096.
Fixes #126097.
Fixes #126102.
Fixes #126098.
Fixes #126147.
Work towards #126100.

Does not fix the OverlyEntry/ModalRoute leak (#126100).

@flutter-dashboard flutter-dashboard bot added a: animation Animation APIs a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels May 5, 2023
@flutter-dashboard flutter-dashboard bot added f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. labels May 5, 2023
@goderbauer goderbauer requested review from dnfield and polina-c May 5, 2023 12:28
@goderbauer goderbauer mentioned this pull request May 5, 2023
Closed
2 tasks
polina-c
polina-c reviewed May 5, 2023
View reviewed changes
packages/flutter_test/lib/src/_matchers_io.dart Outdated
}
}
Future<ui.Image?> imageFuture;
bool disposeImage = false; // set to true if the matcher created and owns the image and must therefore dispose it.
Copy link
Contributor

@polina-c polina-c May 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be more readable to assign false under if:

final bool disposeImage;

if (...) {
  ... 
  disposeImage = false;
} else if {
  ... 
  disposeImage = true;
} else {
  throw ...
}

Copy link
Member Author

@goderbauer goderbauer May 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. I'll make it so.

polina-c
polina-c approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@polina-c polina-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label May 8, 2023
@auto-submit auto-submit bot merged commit 9b230d2 into flutter:master May 8, 2023
@goderbauer goderbauer deleted the fixLeaks branch May 8, 2023 09:34
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 8, 2023
@engine-flutter-autoroll
9b230d2 Fix leaks (flutter/flutter#126144)
c9ef8ad
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 8, 2023
@engine-flutter-autoroll
Roll Flutter from 43ac23b to 4ed1c92 (16 revisions) (#3942)
8cc2bc7 
flutter/flutter@43ac23b...4ed1c92

2023-05-08 [email protected] Roll Flutter Engine from c42dd23e29f6 to a8e9ac63fd95 (1 revision) (flutter/flutter#126265)
2023-05-08 [email protected] Clearer text about what happens with `--disable-telemetry` + enable-telemetry command (flutter/flutter#125995)
2023-05-08 [email protected] Roll Flutter Engine from 23f730efbff7 to c42dd23e29f6 (13 revisions) (flutter/flutter#126262)
2023-05-08 [email protected] Fix leaks (flutter/flutter#126144)
2023-05-08 [email protected] Update packages (flutter/flutter#126140)
2023-05-06 [email protected] [ExpansionPanelList] add materialGapSize property in ExpansionPanelList Widget (flutter/flutter#123971)
2023-05-06 [email protected] Roll Flutter Engine from eedcee66a710 to 23f730efbff7 (1 revision) (flutter/flutter#126199)
2023-05-06 [email protected] Roll Flutter Engine from 393b5649e7b4 to eedcee66a710 (1 revision) (flutter/flutter#126198)
2023-05-06 [email protected] Roll Flutter Engine from 876968833e46 to 393b5649e7b4 (1 revision) (flutter/flutter#126195)
2023-05-06 [email protected] [ios] fix hold and drag spacebar does not move cursor when obscureTexâ�¦ (flutter/flutter#122383)
2023-05-06 [email protected] Roll Flutter Engine from d9116d94a111 to 876968833e46 (1 revision) (flutter/flutter#126192)
2023-05-06 [email protected] Roll Flutter Engine from 332f53219c4c to d9116d94a111 (1 revision) (flutter/flutter#126190)
2023-05-06 [email protected] Roll Flutter Engine from b7c79b41b9d4 to 332f53219c4c (3 revisions) (flutter/flutter#126188)
2023-05-06 [email protected] â�¨ Add `rect` argument to `_ArcPaintPredicate` for tests (flutter/flutter#125953)
2023-05-06 [email protected] Roll Flutter Engine from 758cbadfac1f to b7c79b41b9d4 (4 revisions) (flutter/flutter#126187)
2023-05-06 [email protected] Add Windows and Linux support to the 'layers' example (flutter/flutter#126105)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@HansMuller HansMuller mentioned this pull request May 12, 2023
Closed
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@engine-flutter-autoroll @nploi
Roll Flutter from 43ac23b to 4ed1c92 (16 revisions) (flutter#3942)
811ca9c 
flutter/flutter@43ac23b...4ed1c92

2023-05-08 [email protected] Roll Flutter Engine from c42dd23e29f6 to a8e9ac63fd95 (1 revision) (flutter/flutter#126265)
2023-05-08 [email protected] Clearer text about what happens with `--disable-telemetry` + enable-telemetry command (flutter/flutter#125995)
2023-05-08 [email protected] Roll Flutter Engine from 23f730efbff7 to c42dd23e29f6 (13 revisions) (flutter/flutter#126262)
2023-05-08 [email protected] Fix leaks (flutter/flutter#126144)
2023-05-08 [email protected] Update packages (flutter/flutter#126140)
2023-05-06 [email protected] [ExpansionPanelList] add materialGapSize property in ExpansionPanelList Widget (flutter/flutter#123971)
2023-05-06 [email protected] Roll Flutter Engine from eedcee66a710 to 23f730efbff7 (1 revision) (flutter/flutter#126199)
2023-05-06 [email protected] Roll Flutter Engine from 393b5649e7b4 to eedcee66a710 (1 revision) (flutter/flutter#126198)
2023-05-06 [email protected] Roll Flutter Engine from 876968833e46 to 393b5649e7b4 (1 revision) (flutter/flutter#126195)
2023-05-06 [email protected] [ios] fix hold and drag spacebar does not move cursor when obscureTexâ�¦ (flutter/flutter#122383)
2023-05-06 [email protected] Roll Flutter Engine from d9116d94a111 to 876968833e46 (1 revision) (flutter/flutter#126192)
2023-05-06 [email protected] Roll Flutter Engine from 332f53219c4c to d9116d94a111 (1 revision) (flutter/flutter#126190)
2023-05-06 [email protected] Roll Flutter Engine from b7c79b41b9d4 to 332f53219c4c (3 revisions) (flutter/flutter#126188)
2023-05-06 [email protected] â�¨ Add `rect` argument to `_ArcPaintPredicate` for tests (flutter/flutter#125953)
2023-05-06 [email protected] Roll Flutter Engine from 758cbadfac1f to b7c79b41b9d4 (4 revisions) (flutter/flutter#126187)
2023-05-06 [email protected] Add Windows and Linux support to the 'layers' example (flutter/flutter#126105)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
9b230d2 Fix leaks (flutter/flutter#126144)
90c664e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
9b230d2 Fix leaks (flutter/flutter#126144)
7cce25f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
9b230d2 Fix leaks (flutter/flutter#126144)
1523e3d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
9b230d2 Fix leaks (flutter/flutter#126144)
28785a0
@polina-c polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Sep 21, 2023
@polina-c polina-c changed the title Fix leaks Fix leaks [prod-leak-fix] Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polina-c polina-c polina-c approved these changes

@dnfield dnfield Awaiting requested review from dnfield

Assignees

No one assigned

Labels

a: animation Animation APIs a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

2 participants

@goderbauer @polina-c