Skip to content

[tool] Move Java functions to their own file #126086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 25 commits into from
May 11, 2023
Merged

[tool] Move Java functions to their own file #126086

auto-submit merged 25 commits into from
May 11, 2023

Conversation

@andrewkolos
Copy link
Contributor

@andrewkolos andrewkolos commented May 4, 2023 •
edited
Loading

This is the first step in unifying Java-finding logic across the tool. If curious, see #126029 for an example of what all the changes will probably entail.

Moves java-related functionality like AndroidSdk.findJavaHome to a new class, Java.

See tracking issue #126126 for more.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 4, 2023
@andrewkolos andrewkolos mentioned this pull request May 5, 2023
Closed
3 tasks
@andrewkolos andrewkolos force-pushed the move-java-functions-simple branch from 2e3dcb3 to 6654a91 Compare May 5, 2023 04:16
@andrewkolos andrewkolos force-pushed the move-java-functions-simple branch from 7eeffa5 to fc34192 Compare May 5, 2023 06:05
@flutter-dashboard flutter-dashboard bot added the a: text input Entering text in a text field or keyboard related problems label May 5, 2023
@andrewkolos andrewkolos marked this pull request as ready for review May 5, 2023 17:53
christopherfujino
christopherfujino reviewed May 8, 2023
View reviewed changes
christopherfujino
christopherfujino reviewed May 8, 2023
View reviewed changes
christopherfujino
christopherfujino reviewed May 8, 2023
View reviewed changes
christopherfujino
christopherfujino reviewed May 8, 2023
View reviewed changes
christopherfujino
christopherfujino reviewed May 8, 2023
View reviewed changes
christopherfujino
christopherfujino reviewed May 8, 2023
View reviewed changes
christopherfujino
christopherfujino reviewed May 8, 2023
View reviewed changes
christopherfujino
christopherfujino reviewed May 8, 2023
View reviewed changes
christopherfujino
christopherfujino reviewed May 8, 2023
View reviewed changes
christopherfujino
christopherfujino reviewed May 8, 2023
View reviewed changes
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
0a63cd7 [tool] Move Java functions to their own file (flutter/flutter…
7a5469d 
…#126086)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
0a63cd7 [tool] Move Java functions to their own file (flutter/flutter…
88b37b8 
…#126086)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
0a63cd7 [tool] Move Java functions to their own file (flutter/flutter…
194dd59 
…#126086)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
0a63cd7 [tool] Move Java functions to their own file (flutter/flutter…
998724b 
…#126086)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
0a63cd7 [tool] Move Java functions to their own file (flutter/flutter…
b40f659 
…#126086)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
0a63cd7 [tool] Move Java functions to their own file (flutter/flutter…
e57263e 
…#126086)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
0a63cd7 [tool] Move Java functions to their own file (flutter/flutter…
5826b39 
…#126086)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
0a63cd7 [tool] Move Java functions to their own file (flutter/flutter…
d5311f6 
…#126086)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
0a63cd7 [tool] Move Java functions to their own file (flutter/flutter…
75f96ef 
…#126086)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
0a63cd7 [tool] Move Java functions to their own file (flutter/flutter…
03051d9 
…#126086)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
0a63cd7 [tool] Move Java functions to their own file (flutter/flutter…
638d0b8 
…#126086)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
0a63cd7 [tool] Move Java functions to their own file (flutter/flutter…
75e254b 
…#126086)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
0a63cd7 [tool] Move Java functions to their own file (flutter/flutter…
6efdc3d 
…#126086)
auto-submit bot pushed a commit that referenced this pull request May 20, 2023
@andrewkolos
Reland "[tool] Move Java functions to their own file" (#126577)
80a4f9b 
Relands #126086, which was reverted by #126569.
@andrewkolos andrewkolos mentioned this pull request May 22, 2023
Merged
8 tasks
auto-submit bot pushed a commit that referenced this pull request May 22, 2023
@andrewkolos
add test for setting JAVA_HOME and PATH when invoking `sdkmanager --l…
46a742f 
…icenses` (#127344)

#126086 inadvertently fixed #124776

This follow-up PR gets the fix under test.
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@andrewkolos
[tool] Move Java functions to their own file (flutter#126086)
a5fd7ca 
This is the first step in unifying Java-finding logic across the tool. If curious, see flutter#126029 for an example of what all the changes will probably entail.

Moves java-related functionality like `AndroidSdk.findJavaHome` to a new class, `Java`.

See tracking issue flutter#126126 for more.
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@andrewkolos
Revert "[tool] Move Java functions to their own file" (flutter#126569)
a159f97 
Reverts flutter#126086.

This PR changed the interfaces of some classes, namely `AndroidSdk`, and deleted a global.

These classes had custom overrides in g3 that were not updated with a g3fix, so this PR has broken tests. See https://b.corp.google.com/issues/281945232 (non-public link)
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@andrewkolos
Reland "[tool] Move Java functions to their own file" (flutter#126577)
f1f524d 
Relands flutter#126086, which was reverted by flutter#126569.
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@andrewkolos
add test for setting JAVA_HOME and PATH when invoking `sdkmanager --l…
63ecae2 
…icenses` (flutter#127344)

flutter#126086 inadvertently fixed flutter#124776

This follow-up PR gets the fix under test.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
0a63cd7 [tool] Move Java functions to their own file (flutter/flutter…
7763712 
…#126086)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
0a63cd7 [tool] Move Java functions to their own file (flutter/flutter…
655ce1c 
…#126086)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
0a63cd7 [tool] Move Java functions to their own file (flutter/flutter…
25a5bfa 
…#126086)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
0a63cd7 [tool] Move Java functions to their own file (flutter/flutter…
b6ca188 
…#126086)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewkolos @christopherfujino