Skip to content

[github] Add labeler action #126012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
May 9, 2023
Merged

[github] Add labeler action #126012

auto-submit merged 4 commits into from
May 9, 2023

Conversation

@CaseyHillers
Copy link
Contributor

@CaseyHillers CaseyHillers commented May 3, 2023 •
edited
Loading

Part of #126002

Migrate the Cocoon logic for labelling directly into the repo under test

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

keyonghan
keyonghan reviewed May 3, 2023
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we validate the actions work as expected

.github/labeler.yml
Comment on lines +3 to +4
- accessibility
- semantics
Copy link
Contributor

@keyonghan keyonghan May 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all pathContainsLabels, these should be **...**.

Copy link
Contributor Author

@CaseyHillers CaseyHillers May 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading https://github.com/actions/labeler, this is expected. All of these are regexes, so as long as they contain this pattern it'll be matched (same **semanatics** maps to semantics)

godofredoc
godofredoc reviewed May 3, 2023
View reviewed changes
godofredoc
godofredoc reviewed May 3, 2023
View reviewed changes
godofredoc
godofredoc reviewed May 3, 2023
View reviewed changes
godofredoc
godofredoc reviewed May 3, 2023
View reviewed changes
.github/workflows/labeler.yml
triage:
permissions:
contents: read
pull-requests: write
Copy link
Contributor

@godofredoc godofredoc May 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any more granular permission that can be used here?

Copy link
Contributor Author

@CaseyHillers CaseyHillers May 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, it seems the pull request permission is a catch all. Autosubmit seems to have this same issue where it requires write access to edit the labels on PRs.

I filed a support ticket with GitHub at https://support.github.com/ticket/enterprise/1732/2139514 to see if they can allow smaller ACLs on pull request.

godofredoc
godofredoc reviewed May 3, 2023
View reviewed changes
@CaseyHillers
Copy link
Contributor Author

CaseyHillers commented May 3, 2023

How do we validate the actions work as expected

In the interim, Cocoon and the action can both run. If we notice discrepancies, we can update the workflow here. After ~100 PRs, we should be able to remove the logic from Cocoon.

@keyonghan
Copy link
Contributor

keyonghan commented May 3, 2023

How do we validate the actions work as expected

In the interim, Cocoon and the action can both run. If we notice discrepancies, we can update the workflow here. After ~100 PRs, we should be able to remove the logic from Cocoon.

How do we detect discrepancies between these two logics?

@CaseyHillers
Copy link
Contributor Author

CaseyHillers commented May 3, 2023

How do we detect discrepancies between these two logics?

I plan to manually triage open PRs for the week to make sure the GitHub action is setting all the labels, and not flutter-dashboard. I expect the GitHub action will get priority as it's running directly on GitHub, and has no other work to do (like the webhook subscription does)

@keyonghan
Copy link
Contributor

keyonghan commented May 3, 2023

How do we detect discrepancies between these two logics?

I plan to manually triage open PRs for the week to make sure the GitHub action is setting all the labels, and not flutter-dashboard. I expect the GitHub action will get priority as it's running directly on GitHub, and has no other work to do (like the webhook subscription does)

I am wondering if any logs available for the defined action, but a manual look should tell. LGTM as this is not a blocker even something happens with cocoon around.

keyonghan
keyonghan approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaseyHillers CaseyHillers linked an issue May 3, 2023 that may be closed by this pull request
Migrate cocoon label code to github workflows #126002
Closed
5 tasks
@CaseyHillers
Copy link
Contributor Author

CaseyHillers commented May 4, 2023

@XilaiZhang any idea why this PR isn't getting Google Testing results on it?

@XilaiZhang
Copy link
Contributor

XilaiZhang commented May 4, 2023

@XilaiZhang any idea why this PR isn't getting Google Testing results on it?

umm looks like this still has notify github set to false, did we go/upate-frob the legacy job?

@CaseyHillers
Copy link
Contributor Author

CaseyHillers commented May 4, 2023

Last roll out of those jobs was May 1, did we miss deploying a recent fix?

@XilaiZhang
Copy link
Contributor

XilaiZhang commented May 4, 2023

Last roll out of those jobs was May 1, did we miss deploying a recent fix?

Right yeah then it wouldn't include cl/529188369 from yesterday which corrects the notify github behavior.

@XilaiZhang
Copy link
Contributor

XilaiZhang commented May 4, 2023

redeployed legacy frob server just now to include yesterday's fix. this was also seen in b/274947171 and impacting other prs.

(funny how i was joking in triage yesterday this notifyGithub bug would cause a P0 or P1 soon, and it did prove itself today)

@goderbauer goderbauer added c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team labels May 8, 2023
@CaseyHillers
Copy link
Contributor Author

CaseyHillers commented May 9, 2023

@godofredoc can you take a look?

@XilaiZhang
Copy link
Contributor

XilaiZhang commented May 9, 2023

This is good to merge (clicking on details page shows 0 errors).

we can either 1. manually set github status to pass, or 2. push a new commit to propagate the testing result.

godofredoc
godofredoc approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@godofredoc godofredoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will there be a follow up to remove this functionality from cocoon and adding documentation on how to add new labels?

@CaseyHillers
Copy link
Contributor Author

CaseyHillers commented May 9, 2023

This project will be tracked in #126002. Good point about adding docs. I can't find any existing docs on the wiki, so I'll add some with the new path and send a PSA to contributors who have previously edited the Cocoon files. Once all the Cocoon supported repos have been migrated, I'll send the PR for removing the Cocoon logic.

@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label May 9, 2023
@CaseyHillers CaseyHillers mentioned this pull request May 9, 2023
Closed
5 tasks
@auto-submit auto-submit bot merged commit bf88f60 into flutter:master May 9, 2023
@CaseyHillers CaseyHillers deleted the label-workflow branch May 9, 2023 18:27
@CaseyHillers CaseyHillers mentioned this pull request May 9, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
bf88f60 [github] Add labeler action (flutter/flutter#126012)
3f42648
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 10, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
bf88f60 [github] Add labeler action (flutter/flutter#126012)
88766aa
camsim99 pushed a commit to flutter/packages that referenced this pull request May 12, 2023
@engine-flutter-autoroll
Roll Flutter from 8c5a1ea to a76dbe4 (12 revisions) (#3958)
cabd7ea 
flutter/flutter@8c5a1ea...a76dbe4

2023-05-10 [email protected] Manual roll Flutter Engine
from 8ca16cba8c38 to 78f41a8f2f06 (2 revisions) (flutter/flutter#126392)
2023-05-10 [email protected] Roll flutter/packages to 0167d83
(flutter/flutter#126427)
2023-05-10 [email protected] Migrate gallery
ios tests to build+test (flutter/flutter#111164)
2023-05-09 [email protected] Roll Flutter Engine from
824cd09b8c62 to 8ca16cba8c38 (5 revisions) (flutter/flutter#126360)
2023-05-09 [email protected] Revert "Provide default constraints
for M3 dialogs" (flutter/flutter#126355)
2023-05-09 [email protected] Roll Packages from
4800d65 to 1f91710 (8 revisions) (flutter/flutter#126352)
2023-05-09 [email protected] [github] Add labeler action
(flutter/flutter#126012)
2023-05-09 [email protected] Fix platformLocation path and search
dropping (flutter/flutter#126232)
2023-05-09 [email protected] Roll Flutter Engine from
8d3a8162b3ab to 824cd09b8c62 (10 revisions) (flutter/flutter#126309)
2023-05-09 [email protected] Update FocusNode documentation
(flutter/flutter#126331)
2023-05-09 [email protected] Remove dead code
(flutter/flutter#126266)
2023-05-09 [email protected] fix AppBar's
docs for backgroundColor (flutter/flutter#126194)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC
[email protected],[email protected],[email protected] on
the revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@engine-flutter-autoroll @nploi
Roll Flutter from 8c5a1ea to a76dbe4 (12 revisions) (flutter#3958)
a1ec68f 
flutter/flutter@8c5a1ea...a76dbe4

2023-05-10 [email protected] Manual roll Flutter Engine
from 8ca16cba8c38 to 78f41a8f2f06 (2 revisions) (flutter/flutter#126392)
2023-05-10 [email protected] Roll flutter/packages to 0167d83
(flutter/flutter#126427)
2023-05-10 [email protected] Migrate gallery
ios tests to build+test (flutter/flutter#111164)
2023-05-09 [email protected] Roll Flutter Engine from
824cd09b8c62 to 8ca16cba8c38 (5 revisions) (flutter/flutter#126360)
2023-05-09 [email protected] Revert "Provide default constraints
for M3 dialogs" (flutter/flutter#126355)
2023-05-09 [email protected] Roll Packages from
4800d65 to 1f91710 (8 revisions) (flutter/flutter#126352)
2023-05-09 [email protected] [github] Add labeler action
(flutter/flutter#126012)
2023-05-09 [email protected] Fix platformLocation path and search
dropping (flutter/flutter#126232)
2023-05-09 [email protected] Roll Flutter Engine from
8d3a8162b3ab to 824cd09b8c62 (10 revisions) (flutter/flutter#126309)
2023-05-09 [email protected] Update FocusNode documentation
(flutter/flutter#126331)
2023-05-09 [email protected] Remove dead code
(flutter/flutter#126266)
2023-05-09 [email protected] fix AppBar's
docs for backgroundColor (flutter/flutter#126194)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC
[email protected],[email protected],[email protected] on
the revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
bf88f60 [github] Add labeler action (flutter/flutter#126012)
fa69306
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
bf88f60 [github] Add labeler action (flutter/flutter#126012)
384bb08
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
bf88f60 [github] Add labeler action (flutter/flutter#126012)
26c5bf3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
bf88f60 [github] Add labeler action (flutter/flutter#126012)
e19c4ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsjustkevin itsjustkevin itsjustkevin approved these changes

+2 more reviewers

@godofredoc godofredoc godofredoc approved these changes

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate cocoon label code to github workflows

6 participants

@CaseyHillers @keyonghan @XilaiZhang @itsjustkevin @godofredoc @goderbauer