Skip to content

✨ Add strokeAlign to CircularProgressIndicator and RefreshProgressIndicator #125945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
HansMuller merged 9 commits into from
May 10, 2023
Merged

✨ Add strokeAlign to CircularProgressIndicator and RefreshProgressIndicator #125945

HansMuller merged 9 commits into from
May 10, 2023

Conversation

@AlexV525
Copy link
Member

@AlexV525 AlexV525 commented May 3, 2023 •
edited
Loading

Fixes #3282

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels May 3, 2023
@flutter-dashboard

This comment was marked as outdated.

Sign in to view
@AlexV525 AlexV525 marked this pull request as draft May 3, 2023 06:07
@AlexV525 AlexV525 mentioned this pull request May 3, 2023
Merged
8 tasks
AlexV525
AlexV525 commented May 3, 2023
View reviewed changes
@AlexV525 AlexV525 mentioned this pull request May 6, 2023
Closed
auto-submit bot pushed a commit that referenced this pull request May 6, 2023
@AlexV525
✨ Add rect argument to _ArcPaintPredicate for tests (#125953)
62a4643 
As preparation for #125945.

The PR improves tests itself which allows the `arc` method to be available to check whether corresponding rects are drawn during tests.
@AlexV525 AlexV525 marked this pull request as ready for review May 6, 2023 03:14
@AlexV525 AlexV525 requested a review from HansMuller May 6, 2023 03:57
@AlexV525
Copy link
Member Author

AlexV525 commented May 9, 2023

@HansMuller Is it on your list or something? Tests are good after the branch has been updated.

HansMuller
HansMuller reviewed May 10, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @gspencergoog - does it look OK to you?

gspencergoog
gspencergoog approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Works for me! Thanks for the PR!

@HansMuller HansMuller merged commit d01d8ae into flutter:master May 10, 2023
@AlexV525 AlexV525 deleted the add-stroke-align-to-circular-progress-indicator branch May 10, 2023 23:20
@HansMuller HansMuller mentioned this pull request May 12, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2023
@engine-flutter-autoroll
d01d8ae ✨ Add strokeAlign to CircularProgressIndicator and `Refre…
b13613c 
…shProgressIndicator` (flutter/flutter#125945)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2023
@engine-flutter-autoroll
d01d8ae ✨ Add strokeAlign to CircularProgressIndicator and `Refre…
09bc040 
…shProgressIndicator` (flutter/flutter#125945)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2023
@engine-flutter-autoroll
d01d8ae ✨ Add strokeAlign to CircularProgressIndicator and `Refre…
da4131d 
…shProgressIndicator` (flutter/flutter#125945)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2023
@engine-flutter-autoroll
d01d8ae ✨ Add strokeAlign to CircularProgressIndicator and `Refre…
0bca31d 
…shProgressIndicator` (flutter/flutter#125945)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2023
@engine-flutter-autoroll
d01d8ae ✨ Add strokeAlign to CircularProgressIndicator and `Refre…
0d1f87a 
…shProgressIndicator` (flutter/flutter#125945)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2023
@engine-flutter-autoroll
d01d8ae ✨ Add strokeAlign to CircularProgressIndicator and `Refre…
2141521 
…shProgressIndicator` (flutter/flutter#125945)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2023
@engine-flutter-autoroll
d01d8ae ✨ Add strokeAlign to CircularProgressIndicator and `Refre…
7dd1e3c 
…shProgressIndicator` (flutter/flutter#125945)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
d01d8ae ✨ Add strokeAlign to CircularProgressIndicator and `Refre…
fdce32b 
…shProgressIndicator` (flutter/flutter#125945)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
d01d8ae ✨ Add strokeAlign to CircularProgressIndicator and `Refre…
10e5456 
…shProgressIndicator` (flutter/flutter#125945)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
d01d8ae ✨ Add strokeAlign to CircularProgressIndicator and `Refre…
658a47f 
…shProgressIndicator` (flutter/flutter#125945)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
d01d8ae ✨ Add strokeAlign to CircularProgressIndicator and `Refre…
a7fe04e 
…shProgressIndicator` (flutter/flutter#125945)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
d01d8ae ✨ Add strokeAlign to CircularProgressIndicator and `Refre…
7dab9a0 
…shProgressIndicator` (flutter/flutter#125945)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
d01d8ae ✨ Add strokeAlign to CircularProgressIndicator and `Refre…
5311b29 
…shProgressIndicator` (flutter/flutter#125945)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
d01d8ae ✨ Add strokeAlign to CircularProgressIndicator and `Refre…
1001353 
…shProgressIndicator` (flutter/flutter#125945)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
d01d8ae ✨ Add strokeAlign to CircularProgressIndicator and `Refre…
4522421 
…shProgressIndicator` (flutter/flutter#125945)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
d01d8ae ✨ Add strokeAlign to CircularProgressIndicator and `Refre…
ae46b74 
…shProgressIndicator` (flutter/flutter#125945)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
d01d8ae ✨ Add strokeAlign to CircularProgressIndicator and `Refre…
3e52fea 
…shProgressIndicator` (flutter/flutter#125945)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
d01d8ae ✨ Add strokeAlign to CircularProgressIndicator and `Refre…
d83a870 
…shProgressIndicator` (flutter/flutter#125945)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
d01d8ae ✨ Add strokeAlign to CircularProgressIndicator and `Refre…
026a391 
…shProgressIndicator` (flutter/flutter#125945)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
d01d8ae ✨ Add strokeAlign to CircularProgressIndicator and `Refre…
1acc1ac 
…shProgressIndicator` (flutter/flutter#125945)
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@AlexV525
✨ Add strokeAlign to CircularProgressIndicator and `RefreshProgre…
53467d8 
…ssIndicator` (flutter#125945)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
d01d8ae ✨ Add strokeAlign to CircularProgressIndicator and `Refre…
aaceaec 
…shProgressIndicator` (flutter/flutter#125945)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
d01d8ae ✨ Add strokeAlign to CircularProgressIndicator and `Refre…
6181048 
…shProgressIndicator` (flutter/flutter#125945)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
d01d8ae ✨ Add strokeAlign to CircularProgressIndicator and `Refre…
07d4f3e 
…shProgressIndicator` (flutter/flutter#125945)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
d01d8ae ✨ Add strokeAlign to CircularProgressIndicator and `Refre…
5f9e7a4 
…shProgressIndicator` (flutter/flutter#125945)
@danagbemava-nc danagbemava-nc mentioned this pull request Nov 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

+1 more reviewer

@HansMuller HansMuller HansMuller left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CircularProgressIndicator draws outside of its bounds

3 participants

@AlexV525 @HansMuller @gspencergoog