[tool] Improve help info with build web --wasm flags #125907
Conversation
flutter-dashboard
bot
added
the
tool
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| help: 'Run wasm-opt on the output wasm module.', | ||
| help: | ||
| 'Optimize output wasm using the Binaryen (https://github.com/WebAssembly/binaryen) tool.\n' | ||
| 'Increases the build time, but will yield a smaller, faster output.', |
There was a problem hiding this comment.
I think this should be opt out. The main goal is to show that wasm is faster, so the default should zipline straight to that goal.
There was a problem hiding this comment.
Uh. Okay. Funny. I was going to add a --debuginfo line for wasmopt.
Maybe we opt-in to wasmopt by default but also add --debuginfo so we can debug issues.
There was a problem hiding this comment.
Maybe we should just make this dependent on debug vs profile vs release. That would be
- debug = no wasm-opt
- profile = wasm-opt but add -g so that we get debug info
- release = wasm-opt and no -g
That seems most consistent with normal expectations, and it means that wasm-opt is opt-out instead of opt-in.
There was a problem hiding this comment.
That's a GREAT idea. Will do in a follow-up!
|
auto label is removed for flutter/flutter, pr: 125907, due to - The status or check suite Windows build_tests_2_3 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/flutter, pr: 125907, due to - The status or check suite Windows plugin_test has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
test-exempt: changes documentation lines in help; help lines already have some level of verification and none of the fixes here seem amenable to automation. |
|
Sorry, didn't mean to close it, was just in the triage meeting where that was the button I click all the time. 😆 |
|
auto label is removed for flutter/flutter, pr: 125907, due to - The status or check suite customer_testing-linux has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/flutter, pr: 125907, due to - The status or check suite customer_testing-linux has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
4 participants
Also fixed some comments