Add sample code for SliverAppBar #125785

Istiak-Ahmed78 · 2023-05-01T07:26:13Z

This PR adds an another example for SliverAppBar, showing the use of stretch and onStretchTrigger

Screenrecorder-2023-05-01-12-54-00-483.mp4

Fixes #125651

Adds sample code for SliverAppBar [stretch, onStretchTrigger]

This PR adds an another simple and easily understandable example code for SliverAppBar.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

google-cla · 2023-05-01T07:26:17Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Piinks

Hi @Istiak-Ahmed78! Welcome, thanks for contributing. :)

Can you sign the CLA so we can review this PR? Also, it looks like there are some analysis failures here.

Istiak-Ahmed78 · 2023-05-02T01:38:54Z

Hi @Piinks !
This is my first contribution. The issue I'm facing is I can't sign CLA.

It's logging in automatically with my another email address ([email protected]) instead my github email address ([email protected]) from where I submitted this PR, and I can't change the logged in email address to get the License Agreement.

Is there any support or doc that can help me?

stMerlHin · 2023-05-02T01:56:58Z

Hi @Piinks ! This is my first contribution. The issue I'm facing is I can't sign CLA.

It's logging in automatically with my another email address ([email protected]) instead my github email address ([email protected]) from where I submitted this PR, and I can't change the logged in email address to get the License Agreement.

Is there any support or doc that can help me?

Hello @Istiak-Ahmed78, I was also facing the same problem. I just tried to access the cla site with another browser that I hadn't linked any Google account to before, so I was prompted to sign in.

Istiak-Ahmed78 · 2023-05-02T11:20:16Z

Hi @Istiak-Ahmed78! Welcome, thanks for contributing. :)

Can you sign the CLA so we can review this PR? Also, it looks like there are some analysis failures here.

Hello @Piinks , can you please check again? I signed CLA.

Piinks

Looks like the CLA is all set, thank you!

Can you fix the analysis failure? It looks like there is some whitespace:

/b/s/w/ir/x/w/Á flutter sdk/packages/flutter/lib/src/material/app_bar.dart:1406: trailing U+0020 space character
/b/s/w/ir/x/w/Á flutter sdk/packages/flutter/lib/src/material/app_bar.dart:1410: trailing U+0020 space character

Piinks · 2023-05-02T16:23:46Z

examples/api/lib/material/app_bar/sliver_app_bar.4.dart

When stretching to the extent of stretchTriggerOffset, this would be nice to clarify or add to the sample.

Istiak-Ahmed78 · 2023-05-02T18:02:57Z

@Piinks, thanks for you suggestions.
I have cleared the extra whitespaces and also added stretchTriggerOffset to the sample.
Can you please check again?

Istiak-Ahmed78 · 2023-05-03T12:26:46Z

@Piinks , I would be so happy if you review it again please.

packages/flutter/lib/src/material/app_bar.dart

Piinks

Thanks again for the contribution!

auto-submit · 2023-05-04T19:54:06Z

auto label is removed for flutter/flutter, pr: 125785, due to This PR has not met approval requirements for merging. You have project association NONE and need 1 more review(s) in order to merge this PR.

Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

auto-submit · 2023-05-04T19:54:07Z

auto label is removed for flutter/flutter, pr: 125785, due to Validations Fail.

Piinks · 2023-05-04T19:57:15Z

Oh right, let me find a second reviewer for this. :)

justinmc

LGTM with nits 👍

Thanks for making the docs better!

justinmc · 2023-05-04T20:02:26Z

packages/flutter/lib/src/material/app_bar.dart

+///  ** See code in examples/api/lib/material/app_bar/sliver_app_bar.4.dart **
+/// {@end-tool}
+///
+///


Only one empty line is needed here.

justinmc · 2023-05-04T20:03:49Z

examples/api/lib/material/app_bar/sliver_app_bar.4.dart

+
+import 'package:flutter/material.dart';
+
+/// Flutter code sample for [SliverAppBar].


Suggested change

/// Flutter code sample for [SliverAppBar].

/// Flutter code sample for [SliverAppBar] using [stretch] and [onStretchTrigger].

Istiak-Ahmed78 · 2023-05-05T02:32:12Z

LGTM with nits 👍

Thanks for making the docs better!

Hello @justinmc , @Piinks , I think this PR needs autosubmit label to be merged. I don't have access to add that. Can you please add this? thanks!

Manual roll Flutter from 0b65723 to 43ac23b (30 revisions) Manual roll requested by [email protected] flutter/flutter@0b65723...43ac23b 2023-05-05 [email protected] targets/web.dart - fix typo (flutter/flutter#126114) 2023-05-05 [email protected] Roll Flutter Engine from 6b467df16e11 to 758cbadfac1f (2 revisions) (flutter/flutter#126175) 2023-05-05 [email protected] add tests for dominant bottom sheet in scaffold (flutter/flutter#124472) 2023-05-05 [email protected] Added CupertinoDatepicker monthYear mode (flutter#93508) (flutter/flutter#125603) 2023-05-05 [email protected] Add `Switch.trackOutlineWidth` property (flutter/flutter#125848) 2023-05-05 [email protected] Rename iosdeeplinksettings to iosuniversallinksettings (flutter/flutter#126173) 2023-05-05 [email protected] Roll Flutter Engine from f3efe11f4449 to 6b467df16e11 (3 revisions) (flutter/flutter#126174) 2023-05-05 [email protected] improvement : removed required kotlin dependency (flutter/flutter#125002) 2023-05-05 [email protected] Fix incorrect assert hint in flutter.groovy (flutter/flutter#125283) 2023-05-05 [email protected] Update .cirrus.yml (flutter/flutter#126166) 2023-05-05 [email protected] tool: replace top-level functions with enum properties (flutter/flutter#126167) 2023-05-05 [email protected] Use direct dart API from `dart:ui_web` rather than JS shim. (flutter/flutter#123443) 2023-05-05 [email protected] Add sample code for SliverAppBar (flutter/flutter#125785) 2023-05-05 [email protected] Roll Flutter Engine from cef0e9d1a94f to f3efe11f4449 (3 revisions) (flutter/flutter#126163) 2023-05-05 [email protected] Add a ReorderableListView example with cards + cleanup existing tests (flutter/flutter#126155) 2023-05-05 [email protected] Roll Packages from 6bd59cd to a0f8fd8 (4 revisions) (flutter/flutter#126161) 2023-05-05 [email protected] Bring back the failing build_test's (flutter/flutter#126014) 2023-05-05 [email protected] [web] Use plain platform views in benchmarks (flutter/flutter#126080) 2023-05-05 [email protected] Fix Material 3 tab indicator weight and position (flutter/flutter#125883) 2023-05-05 [email protected] Roll Flutter Engine from b0f53e7751ad to cef0e9d1a94f (1 revision) (flutter/flutter#126150) 2023-05-05 [email protected] Roll Flutter Engine from 6f26066144fb to b0f53e7751ad (2 revisions) (flutter/flutter#126148) 2023-05-05 [email protected] Roll Flutter Engine from 764991e046c6 to 6f26066144fb (1 revision) (flutter/flutter#126141) 2023-05-05 [email protected] Roll Flutter Engine from e7cd29153aa9 to 764991e046c6 (1 revision) (flutter/flutter#126137) 2023-05-05 [email protected] Roll Flutter Engine from a885ed472eea to e7cd29153aa9 (1 revision) (flutter/flutter#126135) 2023-05-05 [email protected] Roll Flutter Engine from c97a0deccbc1 to a885ed472eea (1 revision) (flutter/flutter#126129) 2023-05-05 [email protected] [NavigationDrawer] adds padding property in NavigationDrawer Widget (flutter/flutter#123961) 2023-05-05 [email protected] Roll Flutter Engine from 269ce2deebeb to c97a0deccbc1 (1 revision) (flutter/flutter#126124) 2023-05-05 [email protected] Roll Flutter Engine from 4d5070672859 to 269ce2deebeb (16 revisions) (flutter/flutter#126115) 2023-05-05 [email protected] Minor fixes found while working on blankcanvas (flutter/flutter#125751) 2023-05-05 [email protected] tool-web: use ProcessUtil.run to invoke child processes (flutter/flutter#126109) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md ...

) Manual roll Flutter from 0b65723 to 43ac23b (30 revisions) Manual roll requested by [email protected] flutter/flutter@0b65723...43ac23b 2023-05-05 [email protected] targets/web.dart - fix typo (flutter/flutter#126114) 2023-05-05 [email protected] Roll Flutter Engine from 6b467df16e11 to 758cbadfac1f (2 revisions) (flutter/flutter#126175) 2023-05-05 [email protected] add tests for dominant bottom sheet in scaffold (flutter/flutter#124472) 2023-05-05 [email protected] Added CupertinoDatepicker monthYear mode (flutter#93508) (flutter/flutter#125603) 2023-05-05 [email protected] Add `Switch.trackOutlineWidth` property (flutter/flutter#125848) 2023-05-05 [email protected] Rename iosdeeplinksettings to iosuniversallinksettings (flutter/flutter#126173) 2023-05-05 [email protected] Roll Flutter Engine from f3efe11f4449 to 6b467df16e11 (3 revisions) (flutter/flutter#126174) 2023-05-05 [email protected] improvement : removed required kotlin dependency (flutter/flutter#125002) 2023-05-05 [email protected] Fix incorrect assert hint in flutter.groovy (flutter/flutter#125283) 2023-05-05 [email protected] Update .cirrus.yml (flutter/flutter#126166) 2023-05-05 [email protected] tool: replace top-level functions with enum properties (flutter/flutter#126167) 2023-05-05 [email protected] Use direct dart API from `dart:ui_web` rather than JS shim. (flutter/flutter#123443) 2023-05-05 [email protected] Add sample code for SliverAppBar (flutter/flutter#125785) 2023-05-05 [email protected] Roll Flutter Engine from cef0e9d1a94f to f3efe11f4449 (3 revisions) (flutter/flutter#126163) 2023-05-05 [email protected] Add a ReorderableListView example with cards + cleanup existing tests (flutter/flutter#126155) 2023-05-05 [email protected] Roll Packages from 6bd59cd to a0f8fd8 (4 revisions) (flutter/flutter#126161) 2023-05-05 [email protected] Bring back the failing build_test's (flutter/flutter#126014) 2023-05-05 [email protected] [web] Use plain platform views in benchmarks (flutter/flutter#126080) 2023-05-05 [email protected] Fix Material 3 tab indicator weight and position (flutter/flutter#125883) 2023-05-05 [email protected] Roll Flutter Engine from b0f53e7751ad to cef0e9d1a94f (1 revision) (flutter/flutter#126150) 2023-05-05 [email protected] Roll Flutter Engine from 6f26066144fb to b0f53e7751ad (2 revisions) (flutter/flutter#126148) 2023-05-05 [email protected] Roll Flutter Engine from 764991e046c6 to 6f26066144fb (1 revision) (flutter/flutter#126141) 2023-05-05 [email protected] Roll Flutter Engine from e7cd29153aa9 to 764991e046c6 (1 revision) (flutter/flutter#126137) 2023-05-05 [email protected] Roll Flutter Engine from a885ed472eea to e7cd29153aa9 (1 revision) (flutter/flutter#126135) 2023-05-05 [email protected] Roll Flutter Engine from c97a0deccbc1 to a885ed472eea (1 revision) (flutter/flutter#126129) 2023-05-05 [email protected] [NavigationDrawer] adds padding property in NavigationDrawer Widget (flutter/flutter#123961) 2023-05-05 [email protected] Roll Flutter Engine from 269ce2deebeb to c97a0deccbc1 (1 revision) (flutter/flutter#126124) 2023-05-05 [email protected] Roll Flutter Engine from 4d5070672859 to 269ce2deebeb (16 revisions) (flutter/flutter#126115) 2023-05-05 [email protected] Minor fixes found while working on blankcanvas (flutter/flutter#125751) 2023-05-05 [email protected] tool-web: use ProcessUtil.run to invoke child processes (flutter/flutter#126109) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md ...

Istiak-Ahmed78 changed the title ~~Doc update~~ Add sample code for SliverAppBar May 1, 2023

Piinks reviewed May 1, 2023

View reviewed changes

Istiak-Ahmed78 requested a review from Piinks May 2, 2023 09:26

Piinks reviewed May 2, 2023

View reviewed changes

Istiak-Ahmed78 requested a review from Piinks May 2, 2023 18:06

Piinks reviewed May 4, 2023

View reviewed changes

packages/flutter/lib/src/material/app_bar.dart Outdated Show resolved Hide resolved

Istiak-Ahmed78 and others added 4 commits May 4, 2023 14:51

Add sample code for SliverAppBar

c3e9d92

++

8ddbf8b

add stretchTriggerOffset to the sample code

34ab9dd

Update packages/flutter/lib/src/material/app_bar.dart

9671925

Piinks force-pushed the doc-update branch from 1d25164 to 9671925 Compare May 4, 2023 19:51

Piinks approved these changes May 4, 2023

View reviewed changes

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label May 4, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 4, 2023

justinmc approved these changes May 4, 2023

View reviewed changes

Merge branch 'master' into doc-update

d4e0b9c

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label May 5, 2023

auto-submit bot merged commit 042eaf6 into flutter:master May 5, 2023

engine-flutter-autoroll mentioned this pull request May 5, 2023

Roll Flutter from 0b657236cae4 to 042eaf6b90b3 (18 revisions) flutter/packages#3918

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2023

042eaf6 Add sample code for SliverAppBar (flutter/flutter#125785)

cbda402

engine-flutter-autoroll mentioned this pull request May 5, 2023

Roll Flutter from 0b657236cae4 to 201f7311f7c0 (19 revisions) flutter/packages#3919

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2023

042eaf6 Add sample code for SliverAppBar (flutter/flutter#125785)

e147cc6

engine-flutter-autoroll mentioned this pull request May 5, 2023

Manual roll Flutter from 0b657236cae4 to 201f7311f7c0 (19 revisions) flutter/packages#3920

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2023

042eaf6 Add sample code for SliverAppBar (flutter/flutter#125785)

390443e

engine-flutter-autoroll mentioned this pull request May 6, 2023

Manual roll Flutter from 0b657236cae4 to 43ac23b4c7b4 (30 revisions) flutter/packages#3922

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2023

042eaf6 Add sample code for SliverAppBar (flutter/flutter#125785)

4f95693

HansMuller mentioned this pull request May 12, 2023

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023

042eaf6 Add sample code for SliverAppBar (flutter/flutter#125785)

216a78b

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

042eaf6 Add sample code for SliverAppBar (flutter/flutter#125785)

8396a87

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

042eaf6 Add sample code for SliverAppBar (flutter/flutter#125785)

880f442

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

042eaf6 Add sample code for SliverAppBar (flutter/flutter#125785)

d11d6da


		import 'package:flutter/material.dart';

		/// Flutter code sample for [SliverAppBar].

Add sample code for SliverAppBar #125785

Add sample code for SliverAppBar #125785

Uh oh!

Conversation

Istiak-Ahmed78 commented May 1, 2023

Adds sample code for SliverAppBar [stretch, onStretchTrigger]

Pre-launch Checklist

Uh oh!

google-cla bot commented May 1, 2023

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Istiak-Ahmed78 commented May 2, 2023

Uh oh!

stMerlHin commented May 2, 2023

Uh oh!

Istiak-Ahmed78 commented May 2, 2023

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Piinks May 2, 2023

Choose a reason for hiding this comment

Uh oh!

Istiak-Ahmed78 commented May 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Istiak-Ahmed78 commented May 3, 2023

Uh oh!

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented May 4, 2023

Uh oh!

auto-submit bot commented May 4, 2023

Uh oh!

Piinks commented May 4, 2023

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc May 4, 2023

Choose a reason for hiding this comment

Uh oh!

justinmc May 4, 2023

Choose a reason for hiding this comment

Uh oh!

Istiak-Ahmed78 commented May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Istiak-Ahmed78 commented May 2, 2023 •

edited

Loading

Istiak-Ahmed78 commented May 5, 2023 •

edited

Loading