Skip to content

Minor fixes found while working on blankcanvas #125751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
May 5, 2023
Merged

Minor fixes found while working on blankcanvas #125751

auto-submit merged 3 commits into from
May 5, 2023

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Apr 29, 2023

This PR contains a series of minor changes to address issues that I happened to run into:

  • Pretty-print errors triggered when handling events that are pending because of having locked event handling. Previously these were just dumped to the console.
  • Add more documentation for debugPaintPadding.
  • Add documentation to Tween saying how to implement it.
  • Slight formatting changes in the scrollbar code to align some expressions.
  • Since we convert ScrollMetricsNotifications to ScrollNotifications in various places, provide an explicit API to do this. This will make the behaviour consistent throughout, and makes the code easier to understand. Added a test for this.
  • Clarifications to some of the BindingBase and SchedulerBinding documentation.
  • Clarified some documentation in flutter_test's Finder class.

@Hixie
Minor fixes found while working on blankcanvas
10589b7 
This PR contains a series of minor changes to address issues that I
happened to run into:

 - Pretty-print errors triggered when handling events that are pending because of having locked event handling. Previously these were just dumped to the console.
 - Add more documentation for `debugPaintPadding`.
 - Add documentation to `Tween` saying how to implement it.
 - Slight formatting changes in the scrollbar code to align some expressions.
 - Since we convert ScrollMetricsNotifications to ScrollNotifications in various places, provide an explicit API to do this. This will make the behaviour consistent throughout, and makes the code easier to understand. Added a test for this.
 - Clarifications to some of the BindingBase and SchedulerBinding documentation.
 - Clarified some documentation in `flutter_test`'s `Finder` class.
@flutter-dashboard flutter-dashboard bot added a: animation Animation APIs a: tests "flutter test", flutter_test, or one of our tests f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Apr 29, 2023
goderbauer
goderbauer approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie Hixie added the autosubmit Merge PR when tree becomes green via auto submit App label May 3, 2023
@auto-submit auto-submit bot merged commit a11da30 into flutter:master May 5, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2023
@engine-flutter-autoroll
a11da30 Minor fixes found while working on blankcanvas (flutter/flutt…
a916735 
…er#125751)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2023
@engine-flutter-autoroll
a11da30 Minor fixes found while working on blankcanvas (flutter/flutt…
35d147c 
…er#125751)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2023
@engine-flutter-autoroll
a11da30 Minor fixes found while working on blankcanvas (flutter/flutt…
1c4cf40 
…er#125751)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2023
@engine-flutter-autoroll
a11da30 Minor fixes found while working on blankcanvas (flutter/flutt…
6f4d8a7 
…er#125751)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2023
@engine-flutter-autoroll
a11da30 Minor fixes found while working on blankcanvas (flutter/flutt…
c2252cc 
…er#125751)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2023
@engine-flutter-autoroll
a11da30 Minor fixes found while working on blankcanvas (flutter/flutt…
d75be58 
…er#125751)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2023
@engine-flutter-autoroll
a11da30 Minor fixes found while working on blankcanvas (flutter/flutt…
9f42f96 
…er#125751)
@HansMuller HansMuller mentioned this pull request May 5, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2023
@engine-flutter-autoroll
a11da30 Minor fixes found while working on blankcanvas (flutter/flutt…
94650fd 
…er#125751)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2023
@engine-flutter-autoroll
a11da30 Minor fixes found while working on blankcanvas (flutter/flutt…
535e870 
…er#125751)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 6, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2023
@engine-flutter-autoroll
a11da30 Minor fixes found while working on blankcanvas (flutter/flutt…
c07a5c2 
…er#125751)
tarrinneal pushed a commit to flutter/packages that referenced this pull request May 6, 2023
@engine-flutter-autoroll
Manual roll Flutter from 0b65723 to 43ac23b (30 revisions) (#3922)
07e0930 
Manual roll Flutter from 0b65723 to 43ac23b (30 revisions)

Manual roll requested by [email protected]

flutter/flutter@0b65723...43ac23b

2023-05-05 [email protected] targets/web.dart - fix typo
(flutter/flutter#126114)
2023-05-05 [email protected] Roll Flutter Engine from
6b467df16e11 to 758cbadfac1f (2 revisions) (flutter/flutter#126175)
2023-05-05 [email protected] add tests for
dominant bottom sheet in scaffold (flutter/flutter#124472)
2023-05-05 [email protected] Added
CupertinoDatepicker monthYear mode (flutter#93508)
(flutter/flutter#125603)
2023-05-05 [email protected] Add
`Switch.trackOutlineWidth` property (flutter/flutter#125848)
2023-05-05 [email protected] Rename
iosdeeplinksettings to iosuniversallinksettings (flutter/flutter#126173)
2023-05-05 [email protected] Roll Flutter Engine from
f3efe11f4449 to 6b467df16e11 (3 revisions) (flutter/flutter#126174)
2023-05-05 [email protected] improvement :
removed required kotlin dependency (flutter/flutter#125002)
2023-05-05 [email protected] Fix incorrect assert hint in flutter.groovy
(flutter/flutter#125283)
2023-05-05 [email protected] Update
.cirrus.yml (flutter/flutter#126166)
2023-05-05 [email protected] tool: replace top-level
functions with enum properties (flutter/flutter#126167)
2023-05-05 [email protected] Use direct dart API from
`dart:ui_web` rather than JS shim. (flutter/flutter#123443)
2023-05-05 [email protected] Add sample
code for SliverAppBar (flutter/flutter#125785)
2023-05-05 [email protected] Roll Flutter Engine from
cef0e9d1a94f to f3efe11f4449 (3 revisions) (flutter/flutter#126163)
2023-05-05 [email protected] Add a ReorderableListView example with
cards + cleanup existing tests (flutter/flutter#126155)
2023-05-05 [email protected] Roll Packages from
6bd59cd to a0f8fd8 (4 revisions) (flutter/flutter#126161)
2023-05-05 [email protected] Bring back
the failing build_test's (flutter/flutter#126014)
2023-05-05 [email protected] [web] Use plain platform views in
benchmarks (flutter/flutter#126080)
2023-05-05 [email protected] Fix Material 3 tab indicator weight and
position (flutter/flutter#125883)
2023-05-05 [email protected] Roll Flutter Engine from
b0f53e7751ad to cef0e9d1a94f (1 revision) (flutter/flutter#126150)
2023-05-05 [email protected] Roll Flutter Engine from
6f26066144fb to b0f53e7751ad (2 revisions) (flutter/flutter#126148)
2023-05-05 [email protected] Roll Flutter Engine from
764991e046c6 to 6f26066144fb (1 revision) (flutter/flutter#126141)
2023-05-05 [email protected] Roll Flutter Engine from
e7cd29153aa9 to 764991e046c6 (1 revision) (flutter/flutter#126137)
2023-05-05 [email protected] Roll Flutter Engine from
a885ed472eea to e7cd29153aa9 (1 revision) (flutter/flutter#126135)
2023-05-05 [email protected] Roll Flutter Engine from
c97a0deccbc1 to a885ed472eea (1 revision) (flutter/flutter#126129)
2023-05-05 [email protected] [NavigationDrawer] adds padding
property in NavigationDrawer Widget (flutter/flutter#123961)
2023-05-05 [email protected] Roll Flutter Engine from
269ce2deebeb to c97a0deccbc1 (1 revision) (flutter/flutter#126124)
2023-05-05 [email protected] Roll Flutter Engine from
4d5070672859 to 269ce2deebeb (16 revisions) (flutter/flutter#126115)
2023-05-05 [email protected] Minor fixes found while working on blankcanvas
(flutter/flutter#125751)
2023-05-05 [email protected] tool-web: use ProcessUtil.run
to invoke child processes (flutter/flutter#126109)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC
[email protected],[email protected],[email protected] on the
revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
...
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@engine-flutter-autoroll @nploi
Manual roll Flutter from 0b65723 to 43ac23b (30 revisions) (flutter#3922
3d40882 
)

Manual roll Flutter from 0b65723 to 43ac23b (30 revisions)

Manual roll requested by [email protected]

flutter/flutter@0b65723...43ac23b

2023-05-05 [email protected] targets/web.dart - fix typo
(flutter/flutter#126114)
2023-05-05 [email protected] Roll Flutter Engine from
6b467df16e11 to 758cbadfac1f (2 revisions) (flutter/flutter#126175)
2023-05-05 [email protected] add tests for
dominant bottom sheet in scaffold (flutter/flutter#124472)
2023-05-05 [email protected] Added
CupertinoDatepicker monthYear mode (flutter#93508)
(flutter/flutter#125603)
2023-05-05 [email protected] Add
`Switch.trackOutlineWidth` property (flutter/flutter#125848)
2023-05-05 [email protected] Rename
iosdeeplinksettings to iosuniversallinksettings (flutter/flutter#126173)
2023-05-05 [email protected] Roll Flutter Engine from
f3efe11f4449 to 6b467df16e11 (3 revisions) (flutter/flutter#126174)
2023-05-05 [email protected] improvement :
removed required kotlin dependency (flutter/flutter#125002)
2023-05-05 [email protected] Fix incorrect assert hint in flutter.groovy
(flutter/flutter#125283)
2023-05-05 [email protected] Update
.cirrus.yml (flutter/flutter#126166)
2023-05-05 [email protected] tool: replace top-level
functions with enum properties (flutter/flutter#126167)
2023-05-05 [email protected] Use direct dart API from
`dart:ui_web` rather than JS shim. (flutter/flutter#123443)
2023-05-05 [email protected] Add sample
code for SliverAppBar (flutter/flutter#125785)
2023-05-05 [email protected] Roll Flutter Engine from
cef0e9d1a94f to f3efe11f4449 (3 revisions) (flutter/flutter#126163)
2023-05-05 [email protected] Add a ReorderableListView example with
cards + cleanup existing tests (flutter/flutter#126155)
2023-05-05 [email protected] Roll Packages from
6bd59cd to a0f8fd8 (4 revisions) (flutter/flutter#126161)
2023-05-05 [email protected] Bring back
the failing build_test's (flutter/flutter#126014)
2023-05-05 [email protected] [web] Use plain platform views in
benchmarks (flutter/flutter#126080)
2023-05-05 [email protected] Fix Material 3 tab indicator weight and
position (flutter/flutter#125883)
2023-05-05 [email protected] Roll Flutter Engine from
b0f53e7751ad to cef0e9d1a94f (1 revision) (flutter/flutter#126150)
2023-05-05 [email protected] Roll Flutter Engine from
6f26066144fb to b0f53e7751ad (2 revisions) (flutter/flutter#126148)
2023-05-05 [email protected] Roll Flutter Engine from
764991e046c6 to 6f26066144fb (1 revision) (flutter/flutter#126141)
2023-05-05 [email protected] Roll Flutter Engine from
e7cd29153aa9 to 764991e046c6 (1 revision) (flutter/flutter#126137)
2023-05-05 [email protected] Roll Flutter Engine from
a885ed472eea to e7cd29153aa9 (1 revision) (flutter/flutter#126135)
2023-05-05 [email protected] Roll Flutter Engine from
c97a0deccbc1 to a885ed472eea (1 revision) (flutter/flutter#126129)
2023-05-05 [email protected] [NavigationDrawer] adds padding
property in NavigationDrawer Widget (flutter/flutter#123961)
2023-05-05 [email protected] Roll Flutter Engine from
269ce2deebeb to c97a0deccbc1 (1 revision) (flutter/flutter#126124)
2023-05-05 [email protected] Roll Flutter Engine from
4d5070672859 to 269ce2deebeb (16 revisions) (flutter/flutter#126115)
2023-05-05 [email protected] Minor fixes found while working on blankcanvas
(flutter/flutter#125751)
2023-05-05 [email protected] tool-web: use ProcessUtil.run
to invoke child processes (flutter/flutter#126109)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC
[email protected],[email protected],[email protected] on the
revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
a11da30 Minor fixes found while working on blankcanvas (flutter/flutt…
9afc284 
…er#125751)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
a11da30 Minor fixes found while working on blankcanvas (flutter/flutt…
9769d24 
…er#125751)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
a11da30 Minor fixes found while working on blankcanvas (flutter/flutt…
1eb2f97 
…er#125751)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
a11da30 Minor fixes found while working on blankcanvas (flutter/flutt…
c848956 
…er#125751)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: animation Animation APIs a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Hixie @goderbauer