Skip to content

[framework] delete physical model layer. #125719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
May 2, 2023
Merged

[framework] delete physical model layer. #125719

auto-submit merged 2 commits into from
May 2, 2023

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Apr 28, 2023 •
edited
Loading

Engine PR: flutter/engine#41593

This must land first

We should remove these, as they've been deprecated for a while. On the engine side of things, the physical model layer is the only one which requires the device pixel ratio, so deleting it will allow us to simplify the layer tree code in flutter/engine#41559

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Apr 28, 2023
@jonahwilliams jonahwilliams changed the title [Framework] delete physical model layer [framework] delete physical model layer. Apr 28, 2023
dkwingsmt
dkwingsmt approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label May 1, 2023
goderbauer
goderbauer approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auto-submit auto-submit bot merged commit 12b3023 into flutter:master May 2, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2023
@engine-flutter-autoroll
12b3023 [framework] delete physical model layer. (flutter/flutter#125719
961a848 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2023
@engine-flutter-autoroll
12b3023 [framework] delete physical model layer. (flutter/flutter#125719
2232e09 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2023
@engine-flutter-autoroll
12b3023 [framework] delete physical model layer. (flutter/flutter#125719
2f37dc7 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2023
@engine-flutter-autoroll
12b3023 [framework] delete physical model layer. (flutter/flutter#125719
4e3cadc 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
12b3023 [framework] delete physical model layer. (flutter/flutter#125719
5aa3804 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
12b3023 [framework] delete physical model layer. (flutter/flutter#125719
b4a3457 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
12b3023 [framework] delete physical model layer. (flutter/flutter#125719
e04aed8 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
12b3023 [framework] delete physical model layer. (flutter/flutter#125719
04e7bb5 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
12b3023 [framework] delete physical model layer. (flutter/flutter#125719
45ad1a7 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
12b3023 [framework] delete physical model layer. (flutter/flutter#125719
6eacd55 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
12b3023 [framework] delete physical model layer. (flutter/flutter#125719
9597993 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
12b3023 [framework] delete physical model layer. (flutter/flutter#125719
fc256ba 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
12b3023 [framework] delete physical model layer. (flutter/flutter#125719
4a022ba 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
12b3023 [framework] delete physical model layer. (flutter/flutter#125719
64d28cf 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@dkwingsmt dkwingsmt dkwingsmt approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonahwilliams @goderbauer @dkwingsmt