Skip to content

Update xcode to 14e222b #125716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
May 2, 2023
Merged

Update xcode to 14e222b #125716

auto-submit merged 3 commits into from
May 2, 2023

Conversation

@cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Apr 28, 2023 •
edited
Loading

Framework part of #125814

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cyanglaz cyanglaz requested review from jmagman and vashworth April 28, 2023 21:51
@cyanglaz
Copy link
Contributor Author

cyanglaz commented Apr 28, 2023 •
edited
Loading

Mac plugin_lint_mac failed:

[2023-04-28 14:59:00.797801] [STDOUT] stdout:  -> integration_test (0.0.1)
[2023-04-28 14:59:00.797814] [STDOUT] stdout:     - NOTE  | xcodebuild:  note: Using codesigning identity override: -
[2023-04-28 14:59:00.797827] [STDOUT] stdout:     - NOTE  | [iOS] xcodebuild:  note: Building targets in dependency order
[2023-04-28 14:59:00.797840] [STDOUT] stdout:     - WARN  | xcodebuild:  /Volumes/Work/s/w/ir/x/t/CocoaPods-Lint-20230428-66011-7pgvqe-integration_test/App/main.m:4:9: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
[2023-04-28 14:59:00.797854] [STDOUT] stdout:     - NOTE  | [iOS] xcodebuild:  Pods.xcodeproj: warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 9.0, but the range of supported deployment target versions is 11.0 to 16.4.99. (in target 'Flutter' from project 'Pods')
[2023-04-28 14:59:00.797868] [STDOUT] stdout: 
[2023-04-28 14:59:00.797880] [STDOUT] stdout: [!] integration_test did not pass validation, due to 1 warning (but you can use `--allow-warnings` to ignore it).
[2023-04-28 14:59:00.797893] [STDOUT] stdout: You can use the `--no-clean` option to inspect any issue.

CocoaPods-Lint-20230428-66011-7pgvqe-integration_test/App/main.m:4:9: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
int main() {}
[2023-04-28 14:58:59.880449] [STDOUT] stdout: ^
[2023-04-28 14:58:59.880466] [STDOUT] stdout: void

@cyanglaz
Copy link
Contributor Author

cyanglaz commented Apr 28, 2023 •
edited
Loading

Trying to run bin/cache/dart-sdk/bin/dart --disable-dart-dev --enable-vm-service=0 --no-pause-isolates-on-exit bin/tasks/plugin_lint_mac.dart locally but it hang and I got:

The Dart VM service is listening on http://127.0.0.1:51334/uZK7dl_Ajvg=/
SEVERE: 2023-04-28 15:21:55.069131: Task did not start in 0:01:00.000000.

hellohuanlin
hellohuanlin reviewed Apr 29, 2023
View reviewed changes
.ci.yaml
os: Mac-12
device_type: none
xcode: 14c18
xcode: 14e222b
Copy link
Contributor

@hellohuanlin hellohuanlin Apr 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering if it's better to use a variable so next time we only need to update one place?

@jmagman
Copy link
Member

jmagman commented May 1, 2023

Mac plugin_lint_mac failed:

Filed #125812

@jmagman jmagman mentioned this pull request May 1, 2023
Closed
8 tasks
@jmagman
Copy link
Member

jmagman commented May 1, 2023

Mac plugin_lint_mac failed:

In the meantime we can add --allow-warnings with a TODO to remove when infra updates the necessary gem in these two spots:

flutter/dev/devicelab/bin/tasks/plugin_lint_mac.dart

Line 41 in db7196c

'--verbose',

flutter/dev/devicelab/bin/tasks/plugin_lint_mac.dart

Line 52 in db7196c

'--verbose',

jmagman
jmagman approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyanglaz cyanglaz added the autosubmit Merge PR when tree becomes green via auto submit App label May 1, 2023
@auto-submit auto-submit bot merged commit 9fcb42d into flutter:master May 2, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2023
@engine-flutter-autoroll
9fcb42d Update xcode to 14e222b (flutter/flutter#125716)
88c7f84
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2023
@engine-flutter-autoroll
9fcb42d Update xcode to 14e222b (flutter/flutter#125716)
5956064
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2023
@engine-flutter-autoroll
9fcb42d Update xcode to 14e222b (flutter/flutter#125716)
392e59a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2023
@engine-flutter-autoroll
9fcb42d Update xcode to 14e222b (flutter/flutter#125716)
5dec5b3
@jmagman jmagman mentioned this pull request May 3, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
9fcb42d Update xcode to 14e222b (flutter/flutter#125716)
7a46d34
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
9fcb42d Update xcode to 14e222b (flutter/flutter#125716)
065b855
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
9fcb42d Update xcode to 14e222b (flutter/flutter#125716)
c4ecaa7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
9fcb42d Update xcode to 14e222b (flutter/flutter#125716)
f49bce2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
9fcb42d Update xcode to 14e222b (flutter/flutter#125716)
7e7c3f7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
9fcb42d Update xcode to 14e222b (flutter/flutter#125716)
097c2eb
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
9fcb42d Update xcode to 14e222b (flutter/flutter#125716)
fa0d91d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
9fcb42d Update xcode to 14e222b (flutter/flutter#125716)
db40c94
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
9fcb42d Update xcode to 14e222b (flutter/flutter#125716)
a4d9526
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
9fcb42d Update xcode to 14e222b (flutter/flutter#125716)
dc9df14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hellohuanlin hellohuanlin hellohuanlin left review comments

@jmagman jmagman jmagman approved these changes

@vashworth vashworth Awaiting requested review from vashworth

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cyanglaz @jmagman @hellohuanlin