Skip to content

Add back one Skia test on iOS #125663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zanderso merged 1 commit into from
Apr 28, 2023
Merged

Add back one Skia test on iOS #125663

zanderso merged 1 commit into from
Apr 28, 2023

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Apr 28, 2023 •
edited
Loading

Fixes #125648

@flutter-dashboard flutter-dashboard bot added a: animation Animation APIs a: text input Entering text in a text field or keyboard related problems f: scrolling Viewports, list views, slivers, etc. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Apr 28, 2023
@zanderso zanderso force-pushed the add-back-one-ios-skia branch 2 times, most recently from 0f6a27b to 908b276 Compare April 28, 2023 02:30
@zanderso zanderso force-pushed the add-back-one-ios-skia branch from 908b276 to 49a8247 Compare April 28, 2023 03:11
@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 28, 2023
@zanderso
Copy link
Member Author

zanderso commented Apr 28, 2023

Landing over Google testing being stuck. This change could not affect the internal repo.

@zanderso zanderso merged commit 50f83fc into flutter:master Apr 28, 2023
@zanderso zanderso deleted the add-back-one-ios-skia branch April 28, 2023 17:41
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
50f83fc Add back one Skia test on iOS (flutter/flutter#125663)
a816a58
@zanderso zanderso mentioned this pull request Apr 28, 2023
Merged
zanderso added a commit that referenced this pull request Apr 28, 2023
@zanderso
Remove bringup from new_gallery_skia_ios__transition_perf (#125715)
fef41cf 
Final step of #125663
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023
@engine-flutter-autoroll
50f83fc Add back one Skia test on iOS (flutter/flutter#125663)
d552afa
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023
@engine-flutter-autoroll
50f83fc Add back one Skia test on iOS (flutter/flutter#125663)
bc86c45
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023
@engine-flutter-autoroll
50f83fc Add back one Skia test on iOS (flutter/flutter#125663)
bafd16f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023
@engine-flutter-autoroll
50f83fc Add back one Skia test on iOS (flutter/flutter#125663)
219caac
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2023
@engine-flutter-autoroll
50f83fc Add back one Skia test on iOS (flutter/flutter#125663)
58e7669
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
50f83fc Add back one Skia test on iOS (flutter/flutter#125663)
13b000a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
50f83fc Add back one Skia test on iOS (flutter/flutter#125663)
4faf4f6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
50f83fc Add back one Skia test on iOS (flutter/flutter#125663)
843f839
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
50f83fc Add back one Skia test on iOS (flutter/flutter#125663)
b4fd2c1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
50f83fc Add back one Skia test on iOS (flutter/flutter#125663)
f71df65
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
50f83fc Add back one Skia test on iOS (flutter/flutter#125663)
6b1d78c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
50f83fc Add back one Skia test on iOS (flutter/flutter#125663)
041fc09
This was referenced May 1, 2023
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
50f83fc Add back one Skia test on iOS (flutter/flutter#125663)
6a93e31
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
50f83fc Add back one Skia test on iOS (flutter/flutter#125663)
740e733
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
50f83fc Add back one Skia test on iOS (flutter/flutter#125663)
8f10050
tarrinneal pushed a commit to flutter/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
Manual roll Flutter from 66fa4c5 to 828a040 (79 revisions) (#3874)
c3f4c46 
Manual roll Flutter from 66fa4c5 to 828a040 (79 revisions)

Manual roll requested by [email protected]

flutter/flutter@66fa4c5...828a040

2023-05-01 [email protected] Roll Flutter Engine from
666bc34c61aa to 687f4c761db1 (2 revisions) (flutter/flutter#125818)
2023-05-01 [email protected] Revert "Add
migrator to upgrade gradle version when conflict with And…
(flutter/flutter#125813)
2023-05-01 [email protected] Roll pub packages
(flutter/flutter#125801)
2023-05-01 [email protected] [tools] fix `expect` calls in
`FakeCommand` (flutter/flutter#125783)
2023-05-01 [email protected] Roll Packages from
7e3f5da to de6131d (41 revisions) (flutter/flutter#125811)
2023-05-01 [email protected] Introduce `TabBar.tabAlignment`
(flutter/flutter#125036)
2023-05-01 [email protected] Roll Flutter Engine from
b0da68e7e024 to 666bc34c61aa (1 revision) (flutter/flutter#125805)
2023-05-01 [email protected] add support to
customize Slider interacivity (flutter/flutter#121483)
2023-05-01 [email protected] Roll Flutter Engine from
b4551c72487c to b0da68e7e024 (1 revision) (flutter/flutter#125800)
2023-05-01 [email protected] Roll Flutter Engine from
605528f293d0 to b4551c72487c (1 revision) (flutter/flutter#125795)
2023-05-01 [email protected] Roll Flutter Engine from
bba66b658cee to 605528f293d0 (2 revisions) (flutter/flutter#125793)
2023-05-01 [email protected] Roll Flutter Engine from
2fa61b91d7c2 to bba66b658cee (1 revision) (flutter/flutter#125791)
2023-05-01 [email protected] Roll Flutter Engine from
30c91b8180e7 to 2fa61b91d7c2 (1 revision) (flutter/flutter#125789)
2023-05-01 [email protected] Roll Flutter Engine from
d76a22e67eea to 30c91b8180e7 (1 revision) (flutter/flutter#125787)
2023-05-01 [email protected] [tools] Apply Android Studio version
detection logic to explicitly configured installation directory
(`flutter config --android-studio-dir`) (flutter/flutter#125596)
2023-04-30 [email protected] Roll Flutter Engine from
f234d5e1dd26 to d76a22e67eea (1 revision) (flutter/flutter#125776)
2023-04-30 [email protected] Roll Flutter Engine from
c796390d14cb to f234d5e1dd26 (1 revision) (flutter/flutter#125773)
2023-04-30 [email protected] Roll Flutter Engine from
e99f31f4437d to c796390d14cb (1 revision) (flutter/flutter#125762)
2023-04-30 [email protected] Roll Flutter Engine from
1942b0c2cd9a to e99f31f4437d (1 revision) (flutter/flutter#125758)
2023-04-30 [email protected] Roll Flutter Engine from
7806f8a4fb4c to 1942b0c2cd9a (1 revision) (flutter/flutter#125757)
2023-04-29 [email protected] Roll Flutter Engine from
8167f909bc8d to 7806f8a4fb4c (2 revisions) (flutter/flutter#125750)
2023-04-29 [email protected] Roll Flutter Engine from
900b8a89b73b to 8167f909bc8d (1 revision) (flutter/flutter#125748)
2023-04-29 [email protected] Roll Flutter Engine from
c56ea398b0dc to 900b8a89b73b (1 revision) (flutter/flutter#125747)
2023-04-29 [email protected] Roll Flutter Engine from
0834c886f06a to c56ea398b0dc (1 revision) (flutter/flutter#125746)
2023-04-29 [email protected] Roll Flutter Engine from
68f2ed0a1db5 to 0834c886f06a (1 revision) (flutter/flutter#125736)
2023-04-29 [email protected] Roll Flutter Engine from
0079bb4a20d0 to 68f2ed0a1db5 (1 revision) (flutter/flutter#125735)
2023-04-29 [email protected] Fix crasher in DragableScrollableSheet
when controller is animating and switching widgets
(flutter/flutter#125721)
2023-04-29 [email protected] Roll Flutter Engine from
8f04b29c1b98 to 0079bb4a20d0 (2 revisions) (flutter/flutter#125734)
2023-04-29 [email protected] Roll Flutter Engine from
788d0ed5ed06 to 8f04b29c1b98 (1 revision) (flutter/flutter#125731)
2023-04-29 [email protected] Roll Flutter Engine from
89a8affdced0 to 788d0ed5ed06 (1 revision) (flutter/flutter#125729)
2023-04-29 [email protected] Roll Flutter Engine from
3835d975c8b0 to 89a8affdced0 (2 revisions) (flutter/flutter#125725)
2023-04-29 [email protected] Roll Flutter Engine from
1ae848ce6b55 to 3835d975c8b0 (1 revision) (flutter/flutter#125722)
2023-04-29 [email protected] fix package template
create platform folders (flutter/flutter#125292)
2023-04-28 [email protected] Sliver Cross Axis Group
(flutter/flutter#123862)
2023-04-28 [email protected] Roll Flutter Engine from
2a84ea55e4ef to 1ae848ce6b55 (1 revision) (flutter/flutter#125718)
2023-04-28 [email protected] Remove bringup from
new_gallery_skia_ios__transition_perf (flutter/flutter#125715)
2023-04-28 [email protected] Roll Flutter Engine from
98b6fabc66bb to 2a84ea55e4ef (10 revisions) (flutter/flutter#125714)
2023-04-28 [email protected] Opt into
CMake policy CMP0135 (flutter/flutter#125502)
2023-04-28 [email protected] Add a channel to query the engine
keyboard state (flutter/flutter#122885)
2023-04-28 [email protected] Roll pub packages
(flutter/flutter#125698)
2023-04-28 [email protected]
`Checkbox.fillColor` should be applied to checkbox's background color
when it is unchecked. (flutter/flutter#125643)
2023-04-28 [email protected] Add back one Skia test on
iOS (flutter/flutter#125663)
2023-04-28 [email protected] Roll pub packages
(flutter/flutter#125447)
2023-04-28 [email protected] Nit:
grammar in documentation (flutter/flutter#125462)
...
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@engine-flutter-autoroll @nploi
Manual roll Flutter from 66fa4c5 to 828a040 (79 revisions) (flutter#3874
587ecc8 
)

Manual roll Flutter from 66fa4c5 to 828a040 (79 revisions)

Manual roll requested by [email protected]

flutter/flutter@66fa4c5...828a040

2023-05-01 [email protected] Roll Flutter Engine from
666bc34c61aa to 687f4c761db1 (2 revisions) (flutter/flutter#125818)
2023-05-01 [email protected] Revert "Add
migrator to upgrade gradle version when conflict with And…
(flutter/flutter#125813)
2023-05-01 [email protected] Roll pub packages
(flutter/flutter#125801)
2023-05-01 [email protected] [tools] fix `expect` calls in
`FakeCommand` (flutter/flutter#125783)
2023-05-01 [email protected] Roll Packages from
7e3f5da to de6131d (41 revisions) (flutter/flutter#125811)
2023-05-01 [email protected] Introduce `TabBar.tabAlignment`
(flutter/flutter#125036)
2023-05-01 [email protected] Roll Flutter Engine from
b0da68e7e024 to 666bc34c61aa (1 revision) (flutter/flutter#125805)
2023-05-01 [email protected] add support to
customize Slider interacivity (flutter/flutter#121483)
2023-05-01 [email protected] Roll Flutter Engine from
b4551c72487c to b0da68e7e024 (1 revision) (flutter/flutter#125800)
2023-05-01 [email protected] Roll Flutter Engine from
605528f293d0 to b4551c72487c (1 revision) (flutter/flutter#125795)
2023-05-01 [email protected] Roll Flutter Engine from
bba66b658cee to 605528f293d0 (2 revisions) (flutter/flutter#125793)
2023-05-01 [email protected] Roll Flutter Engine from
2fa61b91d7c2 to bba66b658cee (1 revision) (flutter/flutter#125791)
2023-05-01 [email protected] Roll Flutter Engine from
30c91b8180e7 to 2fa61b91d7c2 (1 revision) (flutter/flutter#125789)
2023-05-01 [email protected] Roll Flutter Engine from
d76a22e67eea to 30c91b8180e7 (1 revision) (flutter/flutter#125787)
2023-05-01 [email protected] [tools] Apply Android Studio version
detection logic to explicitly configured installation directory
(`flutter config --android-studio-dir`) (flutter/flutter#125596)
2023-04-30 [email protected] Roll Flutter Engine from
f234d5e1dd26 to d76a22e67eea (1 revision) (flutter/flutter#125776)
2023-04-30 [email protected] Roll Flutter Engine from
c796390d14cb to f234d5e1dd26 (1 revision) (flutter/flutter#125773)
2023-04-30 [email protected] Roll Flutter Engine from
e99f31f4437d to c796390d14cb (1 revision) (flutter/flutter#125762)
2023-04-30 [email protected] Roll Flutter Engine from
1942b0c2cd9a to e99f31f4437d (1 revision) (flutter/flutter#125758)
2023-04-30 [email protected] Roll Flutter Engine from
7806f8a4fb4c to 1942b0c2cd9a (1 revision) (flutter/flutter#125757)
2023-04-29 [email protected] Roll Flutter Engine from
8167f909bc8d to 7806f8a4fb4c (2 revisions) (flutter/flutter#125750)
2023-04-29 [email protected] Roll Flutter Engine from
900b8a89b73b to 8167f909bc8d (1 revision) (flutter/flutter#125748)
2023-04-29 [email protected] Roll Flutter Engine from
c56ea398b0dc to 900b8a89b73b (1 revision) (flutter/flutter#125747)
2023-04-29 [email protected] Roll Flutter Engine from
0834c886f06a to c56ea398b0dc (1 revision) (flutter/flutter#125746)
2023-04-29 [email protected] Roll Flutter Engine from
68f2ed0a1db5 to 0834c886f06a (1 revision) (flutter/flutter#125736)
2023-04-29 [email protected] Roll Flutter Engine from
0079bb4a20d0 to 68f2ed0a1db5 (1 revision) (flutter/flutter#125735)
2023-04-29 [email protected] Fix crasher in DragableScrollableSheet
when controller is animating and switching widgets
(flutter/flutter#125721)
2023-04-29 [email protected] Roll Flutter Engine from
8f04b29c1b98 to 0079bb4a20d0 (2 revisions) (flutter/flutter#125734)
2023-04-29 [email protected] Roll Flutter Engine from
788d0ed5ed06 to 8f04b29c1b98 (1 revision) (flutter/flutter#125731)
2023-04-29 [email protected] Roll Flutter Engine from
89a8affdced0 to 788d0ed5ed06 (1 revision) (flutter/flutter#125729)
2023-04-29 [email protected] Roll Flutter Engine from
3835d975c8b0 to 89a8affdced0 (2 revisions) (flutter/flutter#125725)
2023-04-29 [email protected] Roll Flutter Engine from
1ae848ce6b55 to 3835d975c8b0 (1 revision) (flutter/flutter#125722)
2023-04-29 [email protected] fix package template
create platform folders (flutter/flutter#125292)
2023-04-28 [email protected] Sliver Cross Axis Group
(flutter/flutter#123862)
2023-04-28 [email protected] Roll Flutter Engine from
2a84ea55e4ef to 1ae848ce6b55 (1 revision) (flutter/flutter#125718)
2023-04-28 [email protected] Remove bringup from
new_gallery_skia_ios__transition_perf (flutter/flutter#125715)
2023-04-28 [email protected] Roll Flutter Engine from
98b6fabc66bb to 2a84ea55e4ef (10 revisions) (flutter/flutter#125714)
2023-04-28 [email protected] Opt into
CMake policy CMP0135 (flutter/flutter#125502)
2023-04-28 [email protected] Add a channel to query the engine
keyboard state (flutter/flutter#122885)
2023-04-28 [email protected] Roll pub packages
(flutter/flutter#125698)
2023-04-28 [email protected]
`Checkbox.fillColor` should be applied to checkbox's background color
when it is unchecked. (flutter/flutter#125643)
2023-04-28 [email protected] Add back one Skia test on
iOS (flutter/flutter#125663)
2023-04-28 [email protected] Roll pub packages
(flutter/flutter#125447)
2023-04-28 [email protected] Nit:
grammar in documentation (flutter/flutter#125462)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: animation Animation APIs a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. f: scrolling Viewports, list views, slivers, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Restore an iOS/Skia benchmark to CI

2 participants

@zanderso @dnfield