Skip to content

Increase Xcode minimum version to 14 #125639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Apr 27, 2023
Merged

Increase Xcode minimum version to 14 #125639

auto-submit merged 2 commits into from
Apr 27, 2023

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Apr 27, 2023 •
edited
Loading

Looks like CocoaPods 1.12.1 is incompatible with < Xcode 14 due to CocoaPods/CocoaPods#11828 (see #123890 for context).

Bump the minimum Xcode version allowed by tooling to 14, released September 2022.

[!] Xcode - develop for iOS and macOS (Xcode 13.4)
    ✗ Flutter requires Xcode 14 or higher.
      Download the latest version or update via the Mac App Store.

Fixes #125286.
Previous bump at #97746.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman added tool Affects the "flutter" command-line tool. See also t: labels. t: xcode "xcodebuild" on iOS and general Xcode project management labels Apr 27, 2023
@jmagman jmagman self-assigned this Apr 27, 2023
@flutter-dashboard flutter-dashboard bot added the a: text input Entering text in a text field or keyboard related problems label Apr 27, 2023
christopherfujino
christopherfujino approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, so cocoapods is going to dictate the minimum Xcode version we'll support? :'(

@jmagman
Copy link
Member Author

jmagman commented Apr 27, 2023 •
edited
Loading

Ugh, so cocoapods is going to dictate the minimum Xcode version we'll support? :'(

I still haven't seen someone reporting this to CocoaPods so they may not even know about it to fix it on their side. We've heard from a few Flutter customers that are hitting it though.

framework, engine, packages are all on higher Xcode versions. I don't think samples will break https://github.com/flutter/samples/blob/main/tool/ios_ci_script.sh. We'll find out quickly what else in CI is running on < Xcode 14...

@jmagman jmagman mentioned this pull request Apr 27, 2023
Closed
@jmagman jmagman removed the a: text input Entering text in a text field or keyboard related problems label Apr 27, 2023
cyanglaz
cyanglaz approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 27, 2023
@auto-submit auto-submit bot merged commit 6b73885 into flutter:master Apr 27, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
6b73885 Increase Xcode minimum version to 14 (flutter/flutter#125639)
25c1913
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
6b73885 Increase Xcode minimum version to 14 (flutter/flutter#125639)
5b18acc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
6b73885 Increase Xcode minimum version to 14 (flutter/flutter#125639)
d6fd8f7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
6b73885 Increase Xcode minimum version to 14 (flutter/flutter#125639)
d6e81db
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
6b73885 Increase Xcode minimum version to 14 (flutter/flutter#125639)
fa4da1f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
6b73885 Increase Xcode minimum version to 14 (flutter/flutter#125639)
775cce2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023
@engine-flutter-autoroll
6b73885 Increase Xcode minimum version to 14 (flutter/flutter#125639)
8759019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023
@engine-flutter-autoroll
6b73885 Increase Xcode minimum version to 14 (flutter/flutter#125639)
155eac0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023
@engine-flutter-autoroll
6b73885 Increase Xcode minimum version to 14 (flutter/flutter#125639)
5cbd9ae
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023
@engine-flutter-autoroll
6b73885 Increase Xcode minimum version to 14 (flutter/flutter#125639)
60f9b6d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2023
@engine-flutter-autoroll
6b73885 Increase Xcode minimum version to 14 (flutter/flutter#125639)
8c347e4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2023
@engine-flutter-autoroll
6b73885 Increase Xcode minimum version to 14 (flutter/flutter#125639)
3e0bf13
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
6b73885 Increase Xcode minimum version to 14 (flutter/flutter#125639)
ab641aa
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
6b73885 Increase Xcode minimum version to 14 (flutter/flutter#125639)
341e491
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
6b73885 Increase Xcode minimum version to 14 (flutter/flutter#125639)
85c4c7f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
6b73885 Increase Xcode minimum version to 14 (flutter/flutter#125639)
4f734de
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
6b73885 Increase Xcode minimum version to 14 (flutter/flutter#125639)
1cec23b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
6b73885 Increase Xcode minimum version to 14 (flutter/flutter#125639)
2a8816e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
6b73885 Increase Xcode minimum version to 14 (flutter/flutter#125639)
48410dd
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
6b73885 Increase Xcode minimum version to 14 (flutter/flutter#125639)
c1e0e52
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
6b73885 Increase Xcode minimum version to 14 (flutter/flutter#125639)
5afbcb4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
6b73885 Increase Xcode minimum version to 14 (flutter/flutter#125639)
41ba94f
@jmagman jmagman deleted the xcode-bump branch December 13, 2023 21:14
@bc-lee bc-lee mentioned this pull request Dec 15, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vashworth vashworth Awaiting requested review from vashworth

2 more reviewers

@cyanglaz cyanglaz cyanglaz approved these changes

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

autosubmit Merge PR when tree becomes green via auto submit App t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

readlink -f added in XCode < 14.3 causes archiving error

3 participants

@jmagman @cyanglaz @christopherfujino